fix: delete the file created by the first serialized check (#53)

Author: 12rambau

pytest_gee/dictionary_regression.py

@@ -37,20 +37,24 @@ def check(
             fullpath=fullpath,
             with_test_class_names=self.with_test_class_names,
         )
+        serialized_name = data_name.with_stem(f"serialized_{data_name.stem}").with_suffix(".yml")
 
         # check the previously registered serialized call from GEE. If it matches the current call,
         # we don't need to check the data
         with suppress(BaseException):
             check_serialized(
                 object=ee.Dictionary(data_dict),
-                path=data_name,
+                path=serialized_name,
                 datadir=self.datadir,
                 original_datadir=self.original_datadir,
                 request=self.request,
                 with_test_class_names=self.with_test_class_names,
             )
             return
 
+        # delete the previously created file if wasn't successful
+        serialized_name.unlink(missing_ok=True)
+
         # if it needs to be checked, we need to round the float values to the same precision as the
         # reference file
         data = round_data(data_dict.getInfo(), prescision)

pytest_gee/feature_collection_regression.py

@@ -43,20 +43,24 @@ def check(
             fullpath=fullpath,
             with_test_class_names=self.with_test_class_names,
         )
+        serialized_name = data_name.with_stem(f"serialized_{data_name.stem}").with_suffix(".yml")
 
         # check the previously registered serialized call from GEE. If it matches the current call,
         # we don't need to check the data
         with suppress(BaseException):
             check_serialized(
                 object=data_fc,
-                path=data_name,
+                path=serialized_name,
                 datadir=self.datadir,
                 original_datadir=self.original_datadir,
                 request=self.request,
                 with_test_class_names=self.with_test_class_names,
             )
             return
 
+        # delete the previously created file if wasn't successful
+        serialized_name.unlink(missing_ok=True)
+
         # round the geometry using geopandas to make sre with use the specific number of decimal places
         gdf = gpd.GeoDataFrame.from_features(data_fc.getInfo())
         gdf.geometry = gdf.set_precision(grid_size=10 ** (-prescision)).remove_repeated_points()

pytest_gee/image_regression.py

@@ -54,20 +54,24 @@ def check(
             fullpath=fullpath,
             with_test_class_names=self.with_test_class_names,
         )
+        serialized_name = data_name.with_stem(f"serialized_{data_name.stem}").with_suffix(".yml")
 
         # check the previously registered serialized call from GEE. If it matches the current call,
         # we don't need to check the data
         with suppress(BaseException):
             check_serialized(
                 object=data_image,
-                path=data_name,
+                path=serialized_name,
                 datadir=self.datadir,
                 original_datadir=self.original_datadir,
                 request=self.request,
                 with_test_class_names=self.with_test_class_names,
             )
             return
 
+        # delete the previously created file if wasn't successful
+        serialized_name.unlink(missing_ok=True)
+
         # extract min and max for visualization
         minMax = data_image.reduceRegion(ee.Reducer.minMax(), geometry, scale)
 

pytest_gee/list_regression.py

@@ -37,20 +37,24 @@ def check(
             fullpath=fullpath,
             with_test_class_names=self.with_test_class_names,
         )
+        serialized_name = data_name.with_stem(f"serialized_{data_name.stem}").with_suffix(".yml")
 
         # check the previously registered serialized call from GEE. If it matches the current call,
         # we don't need to check the data
         with suppress(BaseException):
             check_serialized(
                 object=data_list,
-                path=data_name,
+                path=serialized_name,
                 datadir=self.datadir,
                 original_datadir=self.original_datadir,
                 request=self.request,
                 with_test_class_names=self.with_test_class_names,
             )
             return
 
+        # delete the previously created file if wasn't successful
+        serialized_name.unlink(missing_ok=True)
+
         # if it needs to be checked, we need to round the float values to the same precision as the
         # reference file
         data = round_data(data_list.getInfo(), prescision)

pytest_gee/utils.py

@@ -321,7 +321,7 @@ def check_serialized(
 
     Args:
         object: the earthnegine object to check
-        path: the full path to the file to check against. a "serialized" prefix will be added.
+        path: the full path to the file to check against.
         datadir: Fixture embed_data.
         original_datadir: Fixture embed_data.
         request: Pytest request object.
@@ -334,12 +334,9 @@ def check_serialized(
     # serialize the object# extract the data from the computed object
     data_dict = json.loads(object.serialize())
 
-    # create a filename from the path
-    fullpath = path.with_stem(f"serialized_{path.stem}").with_suffix(".yml")
-
     # delete the file upstream if force_regen is set
     if force_regen is True:
-        fullpath.unlink(missing_ok=True)
+        path.unlink(missing_ok=True)
 
     def dump(filename: Path) -> None:
         """Dump dict contents to the given filename."""
@@ -362,6 +359,6 @@ def dump(filename: Path) -> None:
         check_fn=partial(check_text_files, encoding="UTF-8"),
         dump_fn=dump,
         extension=".yml",
-        fullpath=fullpath,
+        fullpath=path,
         with_test_class_names=with_test_class_names,
     )