fix: replace hardcoded lang strings with lang values in tests for cross-platform compatibility

Copilot · Blankll · Copilot · commit 7e081da51885 · 2026-01-06T10:27:09.000Z
Co-authored-by: Blankll &lt;28639911+Blankll@users.noreply.github.com&gt;
diff --git a/tests/common/iacHelper.test.ts b/tests/common/iacHelper.test.ts
@@ -14,7 +14,7 @@ const location = 'tests/fixtures/artifacts/artifact.zip';
 describe('Unit test for iacHelper', () => {
   beforeAll(() => {
     // Set locale to English for consistent test messages
-    lang.setLocale('en');
+    lang.setLocale('en-US');
   });
 
   beforeEach(() => {
@@ -158,7 +158,7 @@ describe('Unit test for iacHelper', () => {
 
       expect(value).toEqual('');
       expect(warnSpy).toHaveBeenCalledWith(
-        "Variable 'nonExistentVar' not found in vars or parameters, using empty string",
+        lang.__('VARIABLE_NOT_FOUND', { key: 'nonExistentVar' }),
       );
       warnSpy.mockRestore();
     });
@@ -169,7 +169,7 @@ describe('Unit test for iacHelper', () => {
 
       expect(value).toEqual('');
       expect(warnSpy).toHaveBeenCalledWith(
-        "Stage variable 'nonExistentStage' not found in stage 'test', using empty string",
+        lang.__('STAGE_VARIABLE_NOT_FOUND', { key: 'nonExistentStage', stage: 'test' }),
       );
       warnSpy.mockRestore();
     });
@@ -188,12 +188,8 @@ describe('Unit test for iacHelper', () => {
 
       expect(value).toEqual('--exists');
       expect(warnSpy).toHaveBeenCalledTimes(2);
-      expect(warnSpy).toHaveBeenCalledWith(
-        "Variable 'missing1' not found in vars or parameters, using empty string",
-      );
-      expect(warnSpy).toHaveBeenCalledWith(
-        "Variable 'missing2' not found in vars or parameters, using empty string",
-      );
+      expect(warnSpy).toHaveBeenCalledWith(lang.__('VARIABLE_NOT_FOUND', { key: 'missing1' }));
+      expect(warnSpy).toHaveBeenCalledWith(lang.__('VARIABLE_NOT_FOUND', { key: 'missing2' }));
       warnSpy.mockRestore();
     });
   });
diff --git a/tests/common/rosAssets.test.ts b/tests/common/rosAssets.test.ts
@@ -87,7 +87,7 @@ jest.mock('../../src/common/context', () => ({
 describe('Unit test for rosAssets', () => {
   beforeAll(() => {
     // Set locale to English for consistent test messages
-    lang.setLocale('en');
+    lang.setLocale('en-US');
   });
 
   beforeEach(() => {
@@ -165,15 +165,18 @@ describe('Unit test for rosAssets', () => {
       ]);
       expect(mockedInfoLogger.mock.calls).toEqual([
         [
-          'Folder compressed to: path&#x2F;to&#x2F;asset.55d1d2dd5d6c1b083a04c15431f70da1f2840b9de06383411cbf7eda2a512efe.zip',
+          lang.__('FOLDER_COMPRESSED_TO', {
+            zipPath:
+              'path/to/asset.55d1d2dd5d6c1b083a04c15431f70da1f2840b9de06383411cbf7eda2a512efe.zip',
+          }),
         ],
       ]);
     });
 
     it('should log and skip if no assets to publish', async () => {
       await publishAssets([]);
 
-      expect(mockedInfoLogger).toHaveBeenCalledWith('No assets to publish, skipped!');
+      expect(mockedInfoLogger).toHaveBeenCalledWith(lang.__('NO_ASSETS_TO_PUBLISH'));
     });
   });
 
@@ -200,7 +203,7 @@ describe('Unit test for rosAssets', () => {
     it('should skip the cleanupAssets when there is no assets', async () => {
       await cleanupAssets([]);
 
-      expect(mockedInfoLogger).toHaveBeenCalledWith('No assets to cleanup, skipped!');
+      expect(mockedInfoLogger).toHaveBeenCalledWith(lang.__('NO_ASSETS_TO_CLEANUP'));
     });
   });
 });
diff --git a/tests/common/rosClient.test.ts b/tests/common/rosClient.test.ts
@@ -48,7 +48,7 @@ jest.mock('../../src/common/context', () => ({
 describe('Unit test for rosClient', () => {
   beforeAll(() => {
     // Set locale to English for consistent test messages
-    lang.setLocale('en');
+    lang.setLocale('en-US');
   });
 
   beforeEach(() => {
@@ -62,12 +62,16 @@ describe('Unit test for rosClient', () => {
       mockedGetStore.mockReturnValue({ stackName });
       mockedListStacks.mockResolvedValue({ statusCode: 200, body: { stacks: [] } });
       mockedCreateStack.mockResolvedValue({ body: { stackId: 'newStackId' } });
-      mockedGetStack.mockResolvedValue({ body: { status: 'CREATE_COMPLETE' } });
+      mockedGetStack.mockResolvedValue({
+        body: { status: 'CREATE_COMPLETE', stackName: 'newStack', stackId: 'newStackId' },
+      });
 
       await rosStackDeploy(stackName, {});
 
       expect(mockedCreateStack).toHaveBeenCalled();
-      expect(mockedLoggerInfo).toHaveBeenCalledWith(expect.stringContaining('createStack success'));
+      expect(mockedLoggerInfo).toHaveBeenCalledWith(
+        lang.__('CREATE_STACK_SUCCESS', { stackName: 'newStack', stackId: 'newStackId' }),
+      );
     });
 
     it('should update an existing stack if it exists', async () => {
@@ -78,12 +82,16 @@ describe('Unit test for rosClient', () => {
         body: { stacks: [{ stackId: 'existingStackId', Status: 'CREATE_COMPLETE' }] },
       });
       mockedUpdateStack.mockResolvedValue({ body: { stackId: 'existingStackId' } });
-      mockedGetStack.mockResolvedValue({ body: { status: 'UPDATE_COMPLETE' } });
+      mockedGetStack.mockResolvedValue({
+        body: { status: 'UPDATE_COMPLETE', stackName: 'existingStack', stackId: 'existingStackId' },
+      });
 
       await rosStackDeploy(stackName, {});
 
       expect(mockedUpdateStack).toHaveBeenCalled();
-      expect(mockedLoggerInfo).toHaveBeenCalledWith(expect.stringContaining('stackUpdate success'));
+      expect(mockedLoggerInfo).toHaveBeenCalledWith(
+        lang.__('STACK_UPDATE_SUCCESS', { stackName: 'existingStack', stackId: 'existingStackId' }),
+      );
     });
 
     it('should throw an error if the stack is in progress', async () => {
@@ -142,15 +150,21 @@ describe('Unit test for rosClient', () => {
 
       await rosStackDelete(context);
 
-      expect(mockedLoggerInfo).toHaveBeenCalledWith('stack status: DELETE_COMPLETE');
-      expect(mockedLoggerInfo).toHaveBeenCalledWith('Stack: testStack deleted!🗑 ');
+      expect(mockedLoggerInfo).toHaveBeenCalledWith(
+        lang.__('STACK_STATUS', { status: 'DELETE_COMPLETE' }),
+      );
+      expect(mockedLoggerInfo).toHaveBeenCalledWith(
+        lang.__('STACK_DELETED', { stackName: 'testStack' }),
+      );
     });
 
     it('should throw an error when the stack does not exist', async () => {
       mockedListStacks.mockResolvedValue({ statusCode: 404, body: { stacks: [] } });
       await rosStackDelete(context);
 
-      expect(mockedLoggerWarn).toHaveBeenCalledWith('Stack: testStack not exists, skipped! 🚫');
+      expect(mockedLoggerWarn).toHaveBeenCalledWith(
+        lang.__('STACK_NOT_EXISTS_SKIPPED', { stackName: 'testStack' }),
+      );
     });
 
     it('should throw error when delete stack failed', async () => {
@@ -164,7 +178,10 @@ describe('Unit test for rosClient', () => {
         JSON.stringify({ statusCode: 400, Message: 'DELETE_FAILED' }),
       );
       expect(mockedLoggerError).toHaveBeenCalledWith(
-        expect.stringContaining('Stack: testStack delete failed! ❌'),
+        lang.__('STACK_DELETE_FAILED', {
+          stackName: 'testStack',
+          error: JSON.stringify({ data: { statusCode: 400, Message: 'DELETE_FAILED' } }),
+        }),
       );
     });
   });
diff --git a/tests/lang/i18n.test.ts b/tests/lang/i18n.test.ts
@@ -3,7 +3,7 @@ import { lang } from '../../src/lang';
 describe('i18n Language Support', () => {
   describe('Translation Keys', () => {
     it('should have English translations', () => {
-      lang.setLocale('en');
+      lang.setLocale('en-US');
       expect(lang.__('YAML_VALID')).toBe('Yaml is valid! 🎉');
       expect(lang.__('VALIDATING_YAML')).toBe('Validating yaml...');
       expect(lang.__('DEPLOYING_STACK')).toBe('Deploying stack...');
@@ -19,7 +19,7 @@ describe('i18n Language Support', () => {
     });
 
     it('should support parameterized translations in English', () => {
-      lang.setLocale('en');
+      lang.setLocale('en-US');
       const result = lang.__('CREATING_STACK_ID', { stackId: 'stack-123' });
       expect(result).toBe('Creating, Stack ID: stack-123');
     });
@@ -31,7 +31,7 @@ describe('i18n Language Support', () => {
     });
 
     it('should translate error messages in English', () => {
-      lang.setLocale('en');
+      lang.setLocale('en-US');
       const result = lang.__('FUNCTION_EXECUTION_ERROR', { error: 'Test error' });
       expect(result).toBe('Function execution error: Test error');
     });
@@ -43,7 +43,7 @@ describe('i18n Language Support', () => {
     });
 
     it('should translate complex parameterized messages in English', () => {
-      lang.setLocale('en');
+      lang.setLocale('en-US');
       const result = lang.__('DESTROYING_STACK', {
         stackName: 'my-stack',
         provider: 'aliyun',
@@ -65,8 +65,8 @@ describe('i18n Language Support', () => {
 
   describe('Locale Support', () => {
     it('should support English locale', () => {
-      lang.setLocale('en');
-      expect(lang.getLocale()).toBe('en');
+      lang.setLocale('en-US');
+      expect(lang.getLocale()).toBe('en-US');
     });
 
     it('should support Chinese Simplified locale', () => {
@@ -76,7 +76,7 @@ describe('i18n Language Support', () => {
 
     it('should have both locales available', () => {
       const locales = lang.getLocales();
-      expect(locales).toContain('en');
+      expect(locales).toContain('en-US');
       expect(locales).toContain('zh-CN');
     });
   });
@@ -106,7 +106,7 @@ describe('i18n Language Support', () => {
     ];
 
     it('should have all critical keys in English', () => {
-      lang.setLocale('en');
+      lang.setLocale('en-US');
       criticalKeys.forEach((key) => {
         const translation = lang.__(key);
         expect(translation).toBeTruthy();
