Skip to content

Fix unused variable warning #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix unused variable warning #12

wants to merge 1 commit into from

Conversation

nobodyinperson
Copy link

There is a compiler warning about the unused retval variable in void shell_task():

Compiling .pio/build/mega-station-debug/libbcc/GeekFactory Shell Library_ID1946/Shell.c.o                                                                                                                                                    
.pio/libdeps/mega-station-debug/GeekFactory Shell Library_ID1946/Shell.c: In function 'shell_task':                                                                                                                                          
.pio/libdeps/mega-station-debug/GeekFactory Shell Library_ID1946/Shell.c:290:6: warning: variable 'retval' set but not used [-Wunused-but-set-variable]                                                                                      
  int retval = 0;
      ^

This PR fixes this (and a couple of whitespace issues) by letting shell_task() return the retval which I assume you intended anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nobodyinperson