Skip to content

Commit 376a930

Browse files
committed
Issue #119: Some additional cleanups for Ruby deployment example.
1 parent acea186 commit 376a930

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

deployments/README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ The first 'production' release of this demo app is version `2.0.1`, which includ
1818

1919
Some notable releases you could test:
2020

21-
- `1.1.4`: First stable release, but not idempotent when deployed.
22-
- TODO: This version is deprecated, but a similar version may be added soon.
2321
- `2.0.1`: First stable release with Article CRUD deployable on modern Ruby versions.
2422
- `2.1.0`: Includes a fancy new header with a linear gradient background. Marketing is happy.
2523

deployments/playbooks/deploy.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
notify: restart nginx
3030

3131
- name: Install required dependencies with bundler.
32-
shell: "bundle install --path vendor/bundle chdir={{ app_directory }}"
32+
command: "bundle install --path vendor/bundle chdir={{ app_directory }}"
3333
when: app_updated.changed == true
3434
notify: restart nginx
3535

@@ -38,12 +38,12 @@
3838
register: app_db_exists
3939

4040
- name: Create database.
41-
shell: "bundle exec rake db:create chdir={{ app_directory }}"
41+
command: "bundle exec rake db:create chdir={{ app_directory }}"
4242
when: app_db_exists.stat.exists == false
4343
notify: restart nginx
4444

4545
- name: Perform deployment-related rake tasks.
46-
shell: "{{ item }} chdir={{ app_directory }}"
46+
command: "{{ item }} chdir={{ app_directory }}"
4747
with_items:
4848
- bundle exec rake db:migrate
4949
- bundle exec rake assets:precompile

deployments/playbooks/vars.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,4 @@ ruby_download_url: https://cache.ruby-lang.org/pub/ruby/2.6/ruby-2.6.0.tar.gz
2222
ruby_version: 2.6.0
2323

2424
# Variables for Node.js installation.
25-
nodejs_install_npm_user: root
25+
nodejs_install_npm_user: root

0 commit comments

Comments
 (0)