Skip to content

Commit d11bb05

Browse files
authored
Fix regression in debug dumping of spans (#8567)
PR #8538 rationalized the names of fields in spans, but this broke its implementation of `as_markup`, which wasn't updated. This code isn't really typechecked, apparently, and the failure is expressed only as ``` Exception during serialization to markup: <builtins.AttributeError: 'Span' object has no attribute 'name'> ``` being spewed when errors are printed to the server log, so no tests failed and the server still worked.
1 parent ffb52d2 commit d11bb05

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

edb/common/span.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,8 @@ def as_markup(cls, self, *, ctx):
138138

139139
endcol = end.column if start.line == end.line else None
140140
tbp = me.lang.TracebackPoint(
141-
name=self.name,
142-
filename=self.name,
141+
name=self.filename,
142+
filename=self.filename,
143143
lineno=start.line,
144144
colno=start.column,
145145
end_colno=endcol,

0 commit comments

Comments
 (0)