Skip to content

Commit 9385576

Browse files
committed
test all the supported GHC versions
and list them in the "tested-with" section of the cabal file
1 parent d4b6b51 commit 9385576

File tree

2 files changed

+18
-8
lines changed

2 files changed

+18
-8
lines changed

.github/workflows/haskell.yml

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -65,16 +65,22 @@ jobs:
6565
strategy:
6666
matrix:
6767
include:
68-
# Check that our upper bounds are correct by building with the latest
69-
# version of everything. We use cabal because it uses the latest
70-
# versions of our dependencies allowed by our upper bounds.
68+
# The purpose of that section is two-fold. First, because we are
69+
# using cabal and not stack, cabal will pick the most recent version
70+
# of our dependencies which has been released. This way, if a
71+
# dependency releases a breaking change, the next monthly CI will
72+
# pick that version and notify us if we are affected by the change.
7173
#
72-
# TODO: switch back to "ghc: latest" once we support ghc-9.0
73-
- name: oldest
74-
ghc: "8.10"
74+
# Second, since this project is a ghc plugin, we rely on details of
75+
# the GHC library which change between versions. It is thus quite
76+
# easy to accidentally make a change which works for the latest
77+
# version of GHC but not with older versions. CI should thus test all
78+
# the supported GHC versions.
79+
- name: ghc-8.10
80+
ghc: "8.10.7"
7581
os: ubuntu-latest
76-
- name: newest
77-
ghc: "9.0"
82+
- name: ghc-9.0
83+
ghc: "9.0.2"
7884
os: ubuntu-latest
7985

8086
steps:

package.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@ extra-source-files:
1818
# for release
1919
ghc-options: -W -Wall
2020

21+
tested-with:
22+
- GHC == 9.0.2
23+
- GHC == 8.10.7
24+
2125
dependencies:
2226
- base >= 4.12 && < 5
2327
- ghc-prim >= 0.5.3

0 commit comments

Comments
 (0)