Skip to content

Commit 8e29441

Browse files
Merge pull request #41 from gemini-testing/TESTPLANE-387.use_local
feat: use local browsers by default
2 parents a104658 + 60a6d60 commit 8e29441

File tree

4 files changed

+27
-10
lines changed

4 files changed

+27
-10
lines changed

__fixtures/config/jsConfig.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
module.exports = {
2-
gridUrl: 'http://localhost:4444/wd/hub',
2+
gridUrl: 'local',
33
baseUrl: 'http://localhost',
44
pageLoadTimeout: 0,
55
httpTimeout: 60000,
@@ -11,17 +11,23 @@ module.exports = {
1111
'testplane-tests/**/*.testplane.(t|j)s'
1212
],
1313
browsers: [
14-
'chrome'
14+
'chrome',
15+
'firefox'
1516
]
1617
}
1718
},
1819
browsers: {
1920
chrome: {
20-
automationProtocol: 'devtools',
2121
headless: true,
2222
desiredCapabilities: {
2323
browserName: 'chrome'
2424
}
25+
},
26+
firefox: {
27+
headless: true,
28+
desiredCapabilities: {
29+
browserName: 'firefox'
30+
}
2531
}
2632
}
2733
};

__fixtures/config/withEverything.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import path from "path";
44
const isCi = Boolean(process.env.CI);
55

66
export default {
7-
gridUrl: "http://localhost:4444/wd/hub",
7+
gridUrl: "local",
88
baseUrl: "http://localhost",
99
pageLoadTimeout: 0,
1010
httpTimeout: 60000,
@@ -16,17 +16,23 @@ export default {
1616
"testplane-tests/**/*.testplane.(t|j)s"
1717
],
1818
browsers: [
19-
"chrome"
19+
"chrome",
20+
"firefox"
2021
]
2122
}
2223
},
2324
browsers: {
2425
chrome: {
25-
automationProtocol: "devtools",
2626
headless: true,
2727
desiredCapabilities: {
2828
browserName: "chrome"
2929
}
30+
},
31+
firefox: {
32+
headless: true,
33+
desiredCapabilities: {
34+
browserName: "firefox"
35+
}
3036
}
3137
},
3238
plugins: {

src/constants/baseGeneralPrompts.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const baseGeneralPrompts: GeneralPrompt[] = [
1111
type: "input",
1212
name: "gridUrl",
1313
message: "GridUrl",
14-
default: "http://localhost:4444/wd/hub",
14+
default: "local",
1515
},
1616
{
1717
type: "confirm",

src/constants/defaultTestplaneConfig.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import type { TestplaneConfig } from "../types/testplaneConfig";
33
export const defaultTestplaneTestsDir = "testplane-tests";
44

55
const defaultTestplaneConfig: TestplaneConfig = {
6-
gridUrl: "http://localhost:4444/wd/hub",
6+
gridUrl: "local",
77
baseUrl: "http://localhost",
88

99
pageLoadTimeout: 0,
@@ -14,18 +14,23 @@ const defaultTestplaneConfig: TestplaneConfig = {
1414
sets: {
1515
desktop: {
1616
files: [`${defaultTestplaneTestsDir}/**/*.testplane.(t|j)s`],
17-
browsers: ["chrome"],
17+
browsers: ["chrome", "firefox"],
1818
},
1919
},
2020

2121
browsers: {
2222
chrome: {
23-
automationProtocol: "devtools",
2423
headless: true,
2524
desiredCapabilities: {
2625
browserName: "chrome",
2726
},
2827
},
28+
firefox: {
29+
headless: true,
30+
desiredCapabilities: {
31+
browserName: "firefox",
32+
},
33+
},
2934
},
3035
};
3136

0 commit comments

Comments
 (0)