Skip to content

Commit 2b2db1f

Browse files
Merge pull request #646 from gemini-testing/TESTPLANE-491.pwt_date_fix
fix: html-reporter gui playwright test launch (step.startTime.getTime)
2 parents 147996e + 1230591 commit 2b2db1f

File tree

2 files changed

+22
-1
lines changed

2 files changed

+22
-1
lines changed

lib/adapters/test-result/playwright.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ const getHistory = (steps?: PlaywrightTestResult['steps']): TestStepCompressed[]
159159
[TestStepKey.Name]: step.title,
160160
[TestStepKey.Args]: [],
161161
[TestStepKey.IsFailed]: Boolean(step.error),
162-
[TestStepKey.TimeStart]: step.startTime.getTime(),
162+
[TestStepKey.TimeStart]: step.startTime instanceof Date ? step.startTime.getTime() : new Date(step.startTime).getTime(),
163163
[TestStepKey.Duration]: step.duration,
164164
[TestStepKey.Children]: getHistory(step.steps),
165165
[TestStepKey.IsGroup]: step.steps?.length > 0

test/unit/lib/adapters/test-result/playwright.ts

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,27 @@ describe('PlaywrightTestResultAdapter', () => {
168168

169169
assert.deepEqual(adapter.history, expectedHistory);
170170
});
171+
172+
it('should work if step.startTime is ISO datetime string', () => {
173+
const steps = [
174+
{title: 'Step1', duration: 100, startTime: new Date(1000).toISOString()},
175+
{title: 'Step2', duration: 200, startTime: new Date(2000).toISOString()}
176+
];
177+
const adapter = new PlaywrightTestResultAdapter(mkTestCase(), mkTestResult({steps} as any), UNKNOWN_ATTEMPT);
178+
const expectedHistory = [mkTestStepCompressed({
179+
[TestStepKey.Name]: 'Step1',
180+
[TestStepKey.Duration]: 100,
181+
[TestStepKey.TimeStart]: 1000,
182+
[TestStepKey.Children]: []
183+
}), mkTestStepCompressed({
184+
[TestStepKey.Name]: 'Step2',
185+
[TestStepKey.Duration]: 200,
186+
[TestStepKey.TimeStart]: 2000,
187+
[TestStepKey.Children]: []
188+
})];
189+
190+
assert.deepEqual(adapter.history, expectedHistory);
191+
});
171192
});
172193

173194
describe('id', () => {

0 commit comments

Comments
 (0)