Skip to content

Commit 51836cf

Browse files
author
oldskytree
committed
chore(static): remove button "show skipped" and component "SkippedList"
1 parent 0217508 commit 51836cf

File tree

11 files changed

+0
-62
lines changed

11 files changed

+0
-62
lines changed

lib/static/components/controls/common-controls.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,6 @@ class ControlButtons extends Component {
5151
/>
5252
</div>
5353
<GroupTestsSelect />
54-
<ControlButton
55-
label="Show skipped"
56-
isActive={view.showSkipped}
57-
handler={actions.toggleSkipped}
58-
/>
5954
<ControlSelect
6055
label="Diff mode"
6156
value={view.diffMode}

lib/static/components/gui.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import {bindActionCreators} from 'redux';
77
import {ROOT} from '../../constants/extension-points';
88
import * as actions from '../modules/actions';
99
import ControlButtons from './controls/gui-controls';
10-
import SkippedList from './skipped-list';
1110
import Loading from './loading';
1211
import ModalContainer from '../containers/modal';
1312
import MainTree from './main-tree';
@@ -84,7 +83,6 @@ class Gui extends Component {
8483
<FaviconChanger />
8584
<ControlButtons />
8685
<main className="container">
87-
<SkippedList />
8886
<MainTree />
8987
</main>
9088
<Loading active={loading.active} content={loading.content} />

lib/static/components/report.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import * as actions from '../modules/actions';
99
import Loading from './loading';
1010
import Header from './header';
1111
import ControlButtons from './controls/report-controls';
12-
import SkippedList from './skipped-list';
1312
import MainTree from './main-tree';
1413
import CustomScripts from './custom-scripts';
1514
import FaviconChanger from './favicon-changer';
@@ -55,7 +54,6 @@ class Report extends Component {
5554
<Header/>
5655
<ControlButtons/>
5756
<main className="container">
58-
<SkippedList />
5957
<MainTree />
6058
</main>
6159
<BottomProgressBar />

lib/static/components/skipped-list.js

Lines changed: 0 additions & 46 deletions
This file was deleted.

lib/static/modules/action-names.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ export default {
2727
VIEW_EXPAND_RETRIES: 'VIEW_EXPAND_RETRIES',
2828
VIEW_COLLAPSE_ALL: 'VIEW_COLLAPSE_ALL',
2929
CHANGE_VIEW_MODE: 'CHANGE_VIEW_MODE',
30-
VIEW_TOGGLE_SKIPPED: 'VIEW_TOGGLE_SKIPPED',
3130
VIEW_UPDATE_BASE_HOST: 'VIEW_UPDATE_BASE_HOST',
3231
VIEW_UPDATE_FILTER_BY_NAME: 'VIEW_UPDATE_FILTER_BY_NAME',
3332
VIEW_SET_STRICT_MATCH_FILTER: 'VIEW_SET_STRICT_MATCH_FILTER',

lib/static/modules/actions.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,6 @@ export const expandAll = () => ({type: actionNames.VIEW_EXPAND_ALL});
187187
export const expandErrors = () => ({type: actionNames.VIEW_EXPAND_ERRORS});
188188
export const expandRetries = () => ({type: actionNames.VIEW_EXPAND_RETRIES});
189189
export const collapseAll = () => ({type: actionNames.VIEW_COLLAPSE_ALL});
190-
export const toggleSkipped = () => ({type: actionNames.VIEW_TOGGLE_SKIPPED});
191190
export const processBegin = () => ({type: actionNames.PROCESS_BEGIN});
192191
export const processEnd = () => ({type: actionNames.PROCESS_END});
193192
export const updateBaseHost = (host) => ({type: actionNames.VIEW_UPDATE_BASE_HOST, host});

lib/static/modules/default-state.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ export default Object.assign(defaults, {
6969
viewMode: viewModes.ALL,
7070
diffMode: diffModes.THREE_UP.id,
7171
expand: EXPAND_ERRORS,
72-
showSkipped: false,
7372
baseHost: '',
7473
testNameFilter: '',
7574
strictMatchFilter: false,

lib/static/modules/middlewares/local-storage.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ export default store => next => action => {
1313
expand: view.expand,
1414
viewMode: view.viewMode,
1515
diffMode: view.diffMode,
16-
showSkipped: view.showSkipped,
1716
strictMatchFilter: view.strictMatchFilter
1817
});
1918
}

lib/static/modules/middlewares/metrika.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ export default metrikaClass => store => next => action => {
6666
case actionNames.VIEW_COLLAPSE_ALL:
6767
case actionNames.VIEW_EXPAND_ERRORS:
6868
case actionNames.VIEW_EXPAND_RETRIES:
69-
case actionNames.VIEW_TOGGLE_SKIPPED:
7069
case actionNames.VIEW_UPDATE_BASE_HOST:
7170
case actionNames.VIEW_THREE_UP_DIFF:
7271
case actionNames.VIEW_THREE_UP_SCALED_DIFF:

test/unit/lib/static/modules/middlewares/local-storage.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ describe('lib/static/modules/middlewares/local-storage', () => {
5757

5858
assert.calledOnceWith(localStorageWrapper.setItem, 'view', {
5959
expand: EXPAND_ERRORS,
60-
showSkipped: false,
6160
strictMatchFilter: false,
6261
viewMode: viewModes.ALL,
6362
diffMode: diffModes.THREE_UP.id

0 commit comments

Comments
 (0)