fix: display error details even if test has successful assertView results and fix e2e tests (#516)

* fix: display error details even if test has successful assertView results

* test: fix e2e tests

Author: shadowusr

lib/static/components/icons/view-in-browser/index.styl

@@ -2,7 +2,6 @@
     display: inline-block;
     width: 16px;
     height: 19px;
-    vertical-align: middle;
     margin-left: 4px;
     margin-right: 0;
     padding: 0 2px;

lib/static/components/section/body/tabs.jsx

@@ -11,7 +11,6 @@ class Tabs extends Component {
             id: PropTypes.string.isRequired,
             status: PropTypes.string.isRequired,
             imageIds: PropTypes.array.isRequired,
-            multipleTabs: PropTypes.bool.isRequired,
             screenshot: PropTypes.bool.isRequired,
             error: PropTypes.object
         }).isRequired
@@ -20,7 +19,7 @@ class Tabs extends Component {
     _shouldAddErrorTab() {
         const {result} = this.props;
 
-        return result.multipleTabs && isErrorStatus(result.status) && !result.screenshot;
+        return isErrorStatus(result.status);
     }
 
     _drawTab({key, imageId = null}) {

lib/static/styles.css

@@ -21,7 +21,7 @@
 
 .report {
     font: 15px YS Text, Helvetica Neue, Arial, sans-serif;
-    line-height: 20px;
+    line-height: 15px;
     margin-bottom: 15px;
 }
 
@@ -320,7 +320,7 @@ main.container {
 
 .section__body .section__title {
     font-size: 15px;
-    line-height: 20px;
+    line-height: 15px;
 }
 
 .section__body .section__title.section__title_type_browser {
@@ -335,7 +335,7 @@ main.container {
 .sticky-header__wrap:before {
     content: '';
     width: 18px;
-    height: 16px;
+    height: 18px;
     display: inline-block;
     margin-right: 5px;
     vertical-align: middle;

test/func/common.hermione.conf.js

@@ -13,7 +13,7 @@ module.exports.getCommonConfig = (projectDir) => ({
             desiredCapabilities: {
                 browserName: 'chrome',
                 'goog:chromeOptions': {
-                    args: ['headless', 'no-sandbox'],
+                    args: ['headless', 'no-sandbox', 'hide-scrollbars'],
                     binary: CHROME_BINARY_PATH
                 }
             },

test/func/fixtures/hermione-gui/screens/797c021/chrome/paragraph.png renamed to test/func/fixtures/hermione-gui/screens/442f53a/chrome/paragraph.png

@@ -21,6 +21,14 @@ describe('failed describe', function() {
         throw new Error(`long_error_message ${'0123456789'.repeat(20)}\n message content`);
     });
 
+    it('test with successful assertView and error', async ({browser}) => {
+        await browser.url(browser.options.baseUrl);
+
+        await browser.assertView('header', 'header');
+
+        throw new Error('Some error');
+    });
+
     it.skip('test skipped', async ({browser}) => {
         await browser.url(browser.options.baseUrl);
     });

test/func/fixtures/hermione-gui/screens/812d576/chrome/paragraph.png

@@ -34,6 +34,14 @@ test.describe('failed describe', () => {
         test.skip(true, 'foo-bar');
     });
 
+    test('test with successful assertView and error', async ({page, baseURL}) => {
+        await page.goto(baseURL as string);
+
+        await expect(page.locator('header')).toHaveScreenshot('header-success.png');
+
+        throw new Error('Some error');
+    });
+
     test.skip('test skipped', async ({page, baseURL}) => {
         await page.goto(baseURL as string);
     });