Merge pull request #671 from gemini-testing/TESTPLANE-555.cannot_read_perBrowser

fix: do not fail if test statistics is empty

Author: DudaGod

lib/static/modules/reducers/stats.js renamed to lib/static/modules/reducers/stats.ts

@@ -1,18 +1,20 @@
 import actionNames from '../action-names';
+import {State} from '@/static/new-ui/types/store';
+import {SomeAction} from '@/static/modules/actions/types';
+import {applyStateUpdate} from '../utils';
 
-export default (state, action) => {
+export default (state: State, action: SomeAction): State => {
     switch (action.type) {
         case actionNames.INIT_STATIC_REPORT: {
             const {stats} = action.payload;
-            const {perBrowser, ...restStats} = stats;
+            const {perBrowser, ...restStats} = stats || {};
 
-            return {
-                ...state,
+            return applyStateUpdate(state, {
                 stats: {
                     all: restStats,
                     perBrowser
                 }
-            };
+            });
         }
 
         default:

lib/static/new-ui/types/store.ts

@@ -15,6 +15,7 @@ import {AcceptableImage} from '@/static/modules/static-image-accepter';
 import {CheckStatus} from '@/constants/checked-statuses';
 import {EntityType} from '@/static/new-ui/features/suites/components/SuitesPage/types';
 import {DbDetails} from '@/db-utils/common';
+import {Stats, PerBrowserStats} from '@/tests-tree-builder/static';
 
 export interface GroupEntity {
     id: string;
@@ -342,6 +343,7 @@ export interface State {
     };
     timestamp: number;
     fetchDbDetails: DbDetails[];
+    stats: {all: Stats | Record<string, never>, perBrowser: PerBrowserStats | undefined} | null;
 }
 
 declare module 'react-redux' {

lib/tests-tree-builder/static.ts

@@ -5,22 +5,22 @@ import {ReporterTestResult} from '../adapters/test-result';
 import {SqliteTestResultAdapter} from '../adapters/test-result/sqlite';
 import {BrowserItem, RawSuitesRow} from '../types';
 
-interface Stats {
+export interface Stats {
     total: number;
     passed: number;
     failed: number;
     skipped: number;
     retries: number;
 }
 
-export type FinalStats = Stats & {
-    perBrowser: {
-        [browserName: string]: {
-            [browserVersion: string]: Stats
-        }
+export interface PerBrowserStats {
+    [browserName: string]: {
+        [browserVersion: string]: Stats
     }
 }
 
+export type FinalStats = Stats & {perBrowser: PerBrowserStats}
+
 export interface SkipItem {
     browser: string;
     suite: string;

test/unit/lib/static/modules/reducers/stats.ts

@@ -0,0 +1,16 @@
+import reducer from 'lib/static/modules/reducers/stats';
+import actionNames from 'lib/static/modules/action-names';
+import type {State} from 'lib/static/new-ui/types/store';
+import type {InitStaticReportAction} from 'lib/static/modules/actions/lifecycle';
+
+describe('lib/static/modules/reducers/stats', () => {
+    describe(`"${actionNames.INIT_STATIC_REPORT}" action`, () => {
+        it('should not fail if stats is empty', () => {
+            const action = {type: actionNames.INIT_STATIC_REPORT, payload: {stats: null} as InitStaticReportAction['payload']};
+
+            const newState = reducer({} as State, action);
+
+            assert.deepEqual(newState.stats, {all: {}, perBrowser: undefined} as State['stats']);
+        });
+    });
+});