Skip to content

Commit e9f2365

Browse files
committed
fix: support "id" field from test for old hermione versions
1 parent feae5bb commit e9f2365

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

lib/gui/tool-runner/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,8 @@ module.exports = class ToolRunner {
170170
return;
171171
}
172172

173-
const testId = formatId(test.id, browserId);
173+
// TODO: remove toString after publish major version
174+
const testId = formatId(test.id.toString(), browserId);
174175
this._tests[testId] = _.extend(test, {browserId});
175176

176177
test.pending

lib/test-adapter.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,8 @@ module.exports = class TestAdapter {
9696
}
9797

9898
_getExpectedKey(stateName) {
99-
return this._testResult.id + '#' + stateName;
99+
// TODO: remove toString after publish major version
100+
return this._testResult.id.toString() + '#' + stateName;
100101
}
101102

102103
_getExpectedPath(stateName, status) {
@@ -274,7 +275,8 @@ module.exports = class TestAdapter {
274275
}
275276

276277
get imageDir() {
277-
return this._testResult.id;
278+
// TODO: remove toString after publish major version
279+
return this._testResult.id.toString();
278280
}
279281

280282
get state() {

0 commit comments

Comments
 (0)