Skip to content

Commit 7048dec

Browse files
fix(selectivity): ensure sort consistency
1 parent a3da54e commit 7048dec

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

src/browser/cdp/selectivity/testplane-selectivity.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,9 @@ export const readTestFileWithTestplaneDependenciesCollecting = <T>(file: string,
8181
}
8282

8383
return fn().finally(() => {
84-
testFileDependenciesCache.set(file, Array.from(jsTestplaneDeps).sort());
84+
testFileDependenciesCache.set(
85+
file,
86+
Array.from(jsTestplaneDeps).sort((a, b) => a.localeCompare(b)),
87+
);
8588
});
8689
};

src/browser/cdp/selectivity/utils.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,13 @@ export const transformSourceDependencies = (
243243
}
244244
}
245245

246-
return { css: Array.from(cssSet).sort(), js: Array.from(jsSet).sort(), modules: Array.from(modulesSet).sort() };
246+
const cmpStr = (a: string, b: string): number => a.localeCompare(b);
247+
248+
return {
249+
css: Array.from(cssSet).sort(cmpStr),
250+
js: Array.from(jsSet).sort(cmpStr),
251+
modules: Array.from(modulesSet).sort(cmpStr),
252+
};
247253
};
248254

249255
/** Merges two sorted deps array into one with uniq values */
@@ -299,7 +305,7 @@ export const mergeSourceDependencies = (
299305

300306
// Ensures file consistency
301307
export const shallowSortObject = (obj: Record<string, unknown>): void => {
302-
const testBrowsers = Object.keys(obj).sort();
308+
const testBrowsers = Object.keys(obj).sort((a, b) => a.localeCompare(b));
303309

304310
for (const testBrowser of testBrowsers) {
305311
const testBrowserDeps = obj[testBrowser];

0 commit comments

Comments
 (0)