Skip to content

Commit 727d40e

Browse files
committed
[TEST] Use tempfile for temporary file handling in tests
Replaced hardcoded file paths with `tempfile.NamedTemporaryFile` to ensure safe and temporary file handling during serialization tests. This improves test reliability and avoids residual files on disk.
1 parent 61ae466 commit 727d40e

File tree

1 file changed

+15
-8
lines changed

1 file changed

+15
-8
lines changed

test/test_modules/test_serialize_model.py

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import tempfile
2+
13
import json
24
import os
35
import pprint
@@ -49,23 +51,28 @@ def _validate_serialization(original_model, model_deserialized):
4951

5052
def test_save_model_to_disk():
5153
model = gp.generate_example_model(ExampleModel.COMBINATION, compute_model=False)
52-
save_model(model, "temp/test_save_model_to_disk.gempy")
54+
with tempfile.NamedTemporaryFile(mode='w+', delete=True) as tmp:
55+
tmp_name = tmp.name + ".gempy" # Store the name to use it later
56+
save_model(model, tmp_name)
5357

54-
# Load the model from disk
55-
loaded_model = load_model("temp/test_save_model_to_disk.gempy")
58+
# Load the model from disk
59+
loaded_model = load_model(tmp_name)
5660
_validate_serialization(model, loaded_model)
5761

5862
gp.compute_model(loaded_model)
5963
if True:
6064
import gempy_viewer as gpv
6165
gpv.plot_3d(loaded_model, image=True)
6266

67+
6368
# Test save after compute
64-
save_model(
65-
model=model,
66-
path="temp/test_save_model_to_disk.gempy",
67-
validate_serialization=True
68-
)
69+
with tempfile.NamedTemporaryFile(mode='w+', delete=True) as tmp:
70+
tmp_name = tmp.name + ".gempy" # Store the name to use it later
71+
save_model(
72+
model=model,
73+
path=tmp_name,
74+
validate_serialization=True
75+
)
6976

7077

7178
def test_interpolation_options():

0 commit comments

Comments
 (0)