[ENH/TEST] Add support for Greenstone model generation and corresponding test #1048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing test Integrated a new `Greenstone` example model into the `generate_example_model` API. Added its binary file and implemented a test for its functionality.
Switched the `use_gpu` configuration to `True` in the CG solver test, ensuring the test runs with GPU acceleration. Removed unused imports for cleanup.
Introduced a `clear_cache` method in the `WeightCache` class for better memory management. Enhanced the numerical stability of the conjugate gradient solver with improved initialization and adaptive tolerances. Refactored interpolation logic to handle weights more efficiently, and adjusted benchmarking to test expanded solver configurations.
Extended CG solver tests to include configurations using both the PYTORCH and PYKEOPS backends. Configured tests with varying `use_gpu` and `dtype` options, introduced a new Greenstone model test, and added 3D plotting support in the test suite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes.
Relates to
Checklist
or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).