Skip to content

Commit 7935462

Browse files
authored
[!!BUG] Chunking with faults were creating rogue voxels | GEN-13299 (#20)
### TL;DR Fixed a bug in the scalar kernel creation by correcting the `drift_start_post_y` parameter. ### What changed? Modified the `drift_start_post_y` parameter in the `create_scalar_kernel` function by removing the subtraction of `fault_n`. The parameter now uses the full `j_size` value instead of `j_size - fault_n`. ### How to test? 1. Run tests that involve the scalar kernel creation 2. Verify that fault-related calculations work correctly 3. Check that the covariance matrices are properly constructed with the updated parameter ### Why make this change? The previous implementation incorrectly reduced the `drift_start_post_y` parameter by `fault_n`, which could lead to incorrect selector matrix construction. This fix ensures that the selector components are properly calculated for the full range of the y-dimension, which is critical for accurate fault modeling in the geological simulations.
2 parents 5a53115 + a86dc7c commit 7935462

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

gempy_engine/modules/kernel_constructor/_kernels_assembler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ def create_scalar_kernel(ki: KernelInput, options: KernelOptions) -> tensor_type
8686
y_size=j_size,
8787
n_drift_eq=fault_n,
8888
drift_start_post_x=cov_size - fault_n,
89-
drift_start_post_y=j_size - fault_n
89+
drift_start_post_y=j_size
9090
)
9191

9292
selector = bt.t.sum(selector_components.sel_ui * (selector_components.sel_vj + 1), axis=-1)

0 commit comments

Comments
 (0)