Improve dependency graph

[gemcoder21]

 Here's a simplified text-based dependency graph:                                                                                                   
                                                                                                                                                     
  LEVEL 0 (No deps - compile first, parallel)                                                                                                        
  ┌─────────┐ ┌─────────┐ ┌──────────┐ ┌──────────┐ ┌───────┐                                                                                        
  │  Style  │ │ BigInt  │ │ Gemstone │ │ Keychain │ │ GRDB  │                                                                                        
  └────┬────┘ └────┬────┘ └────┬─────┘ └────┬─────┘ └───┬───┘                                                                                        
       │           │           │            │           │                                                                                            
  LEVEL 1          │           │            │           │                                                                                            
  ┌────┴─────┐     │           │            │           │                                                                                            
  │Components│     │           │            │           │                                                                                            
  └────┬─────┘     │           │            │           │                                                                                            
       │           │           │            │           │                                                                                            
  LEVEL 2          │           │            │           │                                                                                            
       │      ┌────┴────┐      │            │           │                                                                                            
       │      │Primitives│     │            │           │                                                                                            
       │      └────┬────┘      │            │           │                                                                                            
       │           │           │            │           │                                                                                            
  LEVEL 3 ─────────┼───────────┼────────────┼───────────┤                                                                                            
       │           │           │            │           │                                                                                            
  ┌────┴───┐ ┌─────┴────┐ ┌────┴─────┐ ┌────┴───┐ ┌─────┴──┐                                                                                         
  │Formatters│ │  Store   │ │GemstoneP │ │Preferen│ │ GemAPI │                                                                                       
  └────┬───┘ └────┬─────┘ └────┬─────┘ └────┬───┘ └────┬───┘                                                                                         
       │          │            │            │          │                                                                                             
  LEVEL 4        │            │            │          │                                                                                              
  ┌────┴───┐     │       ┌────┴────┐  ┌────┴───┐     │                                                                                               
  │Validators│    │       │Blockchain│  │Keystore│     │                                                                                             
  └────┬───┘     │       └────┬────┘  └────┬───┘     │                                                                                               
       │         │            │            │          │                                                                                              
  LEVEL 5 ───────┼────────────┼────────────┼──────────┤                                                                                              
       │         │            │            │          │                                                                                              
  ┌────┴─────────┴────────────┴────────────┴──────────┴──┐                                                                                           
  │              PrimitivesComponents (139 files)         │ ← BOTTLENECK                                                                             
  │   deps: Primitives, GemstonePrimitives, Components,   │                                                                                          
  │         Style, Localization, Validators, Formatters   │                                                                                          
  └──────────────────────────┬───────────────────────────┘                                                                                           
                             │                                                                                                                       
  LEVEL 6                    │                                                                                                                       
  ┌──────────────────────────┴───────────────────────────┐                                                                                           
  │                    ChainServices                      │                                                                                          
  │  (7 services: Node, Stake, Chain, Scan, Explorer...) │                                                                                           
  └──────────────────────────┬───────────────────────────┘                                                                                           
                             │                                                                                                                       
  ┌──────────────────────────┴───────────────────────────┐                                                                                           
  │                   FeatureServices                     │                                                                                          
  │ (23 services: Balance, Price, Wallet, Assets, NFT...)│                                                                                           
  └──────────────────────────┬───────────────────────────┘                                                                                           
                             │                                                                                                                       
  LEVEL 7 - FEATURES         │                                                                                                                       
  ┌──────────┬───────────┬───┴────┬──────────┬───────────┐                                                                                           
  │ Transfer │ Settings  │  Swap  │Onboarding│  Assets   │                                                                                           
  │(52 files)│(40 files) │(26 f.) │ (41 f.)  │ (18 f.)   │                                                                                           
  └──────────┴───────────┴────────┴──────────┴───────────┘                                                                                           
                                                                                                                                                     
  Critical Path (longest chain):                                                                                                                     
  BigInt → Primitives → Store → Blockchain → Signer → FeatureServices → Features                                                                     
           (8s)         (?)      (?)          (?)       (?)              (?)                                                                         
                                                                                                                                                     
  The Bottleneck:                                                                                                                                    
  - PrimitivesComponents waits for 7 packages before it can start                                                                                    
  - Most features depend on PrimitivesComponents                                                                                                     
  - This creates a "funnel" where parallelization is limited   
  - 

  Circular dependency issue:                                                                                                                         
  Blockchain → FeatureServices (NativeProviderService)                                                                                               
  ChainServices → FeatureServices                                                                                                                    
  FeatureServices → ChainServices                                                                                                                    
                                                                                                                                                     
  This cross-dependency between service packages adds complexity.                                                                                    

[gemcoder21]

Current Dependency Graph (Updated)                                                                                                          
                                                                                                                                              
  LEVEL 0 - Root Packages (No dependencies, compile in parallel)                                                                              
  ┌─────────┐ ┌───────────┐ ┌──────────┐ ┌──────────┐ ┌───────────────┐ ┌───────────────┐                                                     
  │  Style  │ │Localization│ │ Keychain │ │ Gemstone │ │SwiftHTTPClient│ │ SystemServices│                                                    
  └────┬────┘ └─────┬─────┘ └────┬─────┘ └────┬─────┘ └───────┬───────┘ └───────────────┘                                                     
       │            │            │            │               │                                                                               
  LEVEL 1 - Foundation (depend on Level 0)                                                                                                    
       │      ┌─────┴─────┐      │      ┌─────┴─────┐         │                                                                               
       │      │Primitives │──────┼──────│GemstonePrim│        │                                                                               
       │      └─────┬─────┘      │      └─────┬─────┘         │                                                                               
       │            │            │            │               │                                                                               
  ┌────┴────┐ ┌─────┴─────┐ ┌────┴────┐ ┌─────┴────┐   ┌──────┴──────┐                                                                        
  │Components│ │Formatters │ │Preferen.│ │WalletCore│   │   GemAPI    │                                                                       
  └────┬────┘ └─────┬─────┘ └────┬────┘ └─────┬────┘   └──────┬──────┘                                                                        
       │            │            │            │               │                                                                               
  LEVEL 2 - Core Infrastructure                                                                                                               
       │      ┌─────┴─────┐      │      ┌─────┴─────┐         │                                                                               
       │      │Validators │      │      │  Store    │─────────┤                                                                               
       │      └─────┬─────┘      │      └─────┬─────┘         │                                                                               
       │            │            │            │               │                                                                               
       │            │      ┌─────┴─────┐ ┌────┴─────┐         │                                                                               
       │            │      │ Keystore  │ │Blockchain│←────────┤                                                                               
       │            │      └─────┬─────┘ └────┬─────┘         │                                                                               
       │            │            │            │               │                                                                               
  LEVEL 3 - Signing & UI Bridge    ┌──────────┴───────────┐                                                                                   
       │            │              │       Signer         │                                                                                   
       │            │              └──────────┬───────────┘                                                                                   
       │            │                         │                                                                                               
  ┌────┴────────────┴─────────────────────────┴────────────────┐                                                                              
  │              PrimitivesComponents (139 files)               │ ← BOTTLENECK                                                                
  │   deps: Primitives, GemstonePrim, Components, Style,        │                                                                             
  │         Localization, Validators, Formatters                │                                                                             
  └──────────────────────────┬─────────────────────────────────┘                                                                              
                             │                                                                                                                
  LEVEL 4 - Service Aggregators                                                                                                               
  ┌──────────────────────────┴──────────────────────────────────┐                                                                             
  │                    ChainServices (8 services)                │ ← BOTTLENECK                                                               
  │  NodeService, StakeService, ChainService, ScanService,       │                                                                            
  │  ExplorerService, NameService, WalletConnectorService        │                                                                            
  └──────────────────────────┬──────────────────────────────────┘                                                                             
                             │                                                                                                                
  ┌──────────────────────────┴──────────────────────────────────┐                                                                             
  │                 FeatureServices (24 services)                │ ← MAJOR BOTTLENECK                                                         
  │  Wallet, Assets, Balance, Price, Transactions, NFT, Swap,    │                                                                            
  │  Banner, Notification, Auth, Rewards, Activity, etc.         │                                                                            
  └──────────────────────────┬──────────────────────────────────┘                                                                             
                             │                                                                                                                
  LEVEL 5 - Features (22 modules)                                                                                                             
  ┌──────────┬───────────┬───────────┬───────────┬───────────────┐                                                                            
  │ Transfer │ Settings  │   Swap    │Onboarding │    Assets     │                                                                            
  │(52 files)│(40 files) │ (26 f.)   │ (41 f.)   │   (18 f.)     │                                                                            
  ├──────────┼───────────┼───────────┼───────────┼───────────────┤                                                                            
  │  Staking │ManageWallet│   NFT    │Perpetuals │ MarketInsight │                                                                            
  │  (35 f.) │ (30 f.)   │ (22 f.)  │  (28 f.)  │   (15 f.)     │                                                                             
  └──────────┴───────────┴───────────┴───────────┴───────────────┘                                                                            
                                                                                                                                              
  Critical Path Analysis                                                                                                                      
                                                                                                                                              
  BigInt → Primitives → Store → Blockchain → Signer → ChainServices → FeatureServices → Features                                              
                                                                                                                                              
  Identified Issues                                                                                                                           
                                                                                                                                              
  1. Monolithic Service Packages                                                                                                              
                                                                                                                                              
  - ChainServices: 8 tightly bundled services                                                                                                 
  - FeatureServices: 24 services in one package - extremely monolithic                                                                        
                                                                                                                                              
  2. PrimitivesComponents Bottleneck                                                                                                          
                                                                                                                                              
  - 139 files with 7+ dependencies                                                                                                            
  - Most features wait for this package                                                                                                       
                                                                                                                                              
  3. Inter-Service Coupling within FeatureServices                                                                                            
                                                                                                                                              
  WalletsService → AssetsService, BalanceService, PriceService, BannerService                                                                 
  TransactionStateService → BalanceService, NFTService                                                                                        
  PriceAlertService → PriceService                                                                                                            
                                                                                                                                              
  Improvement Suggestions                                                                                                                     
                                                                                                                                              
  1. Split ChainServices into Domain-Specific Packages                                                                                        
                                                                                                                                              
  ChainServices/                                                                                                                              
  ├── NodeManagementServices/     # NodeService, ExplorerService                                                                              
  ├── StakingChainServices/       # StakeService                                                                                              
  ├── NameResolutionServices/     # NameService                                                                                               
  ├── WalletConnectionServices/   # WalletConnectorService                                                                                    
  └── ScanningServices/           # ScanService, ChainService                                                                                 
                                                                                                                                              
  Benefit: Features that only need name resolution don't wait for staking code to compile.                                                    
                                                                                                                                              
  2. Split FeatureServices by Domain                                                                                                          
                                                                                                                                              
  FeatureServices/ →                                                                                                                          
  ├── WalletCoreServices/         # WalletService, WalletsService, WalletSessionService                                                       
  ├── AssetManagementServices/    # AssetsService, BalanceService, NFTService, DiscoverAssetsService                                          
  ├── PricingServices/            # PriceService, PriceAlertService                                                                           
  ├── TransactionServices/        # TransactionsService, TransactionStateService                                                              
  ├── UIStateServices/            # BannerService, NotificationService, AvatarService                                                         
  └── CoreAppServices/            # AuthService, AppService, DeviceService, RewardsService                                                    
                                                                                                                                              
  Benefit: Features importing only pricing don't rebuild when wallet logic changes.                                                           
                                                                                                                                              
  3. Thin PrimitivesComponents                                                                                                                
                                                                                                                                              
  Split into:                                                                                                                                 
  PrimitivesComponents/ →                                                                                                                     
  ├── PrimitivesUI/           # Basic UI representations (AssetImage, AddressView)                                                            
  ├── ValidationComponents/   # Input validation views                                                                                        
  ├── FormatterComponents/    # Formatted display components                                                                                  
  └── InteractiveComponents/  # Buttons, lists with business logic                                                                            
                                                                                                                                              
  4. Protocol-Based Service Abstraction                                                                                                       
                                                                                                                                              
  Create protocol packages for cross-service communication:                                                                                   
                                                                                                                                              
  // In a new ServiceProtocols package                                                                                                        
  protocol BalanceProviding {                                                                                                                 
      func getBalance(for wallet: Wallet) async throws -> [AssetBalance]                                                                      
  }                                                                                                                                           
                                                                                                                                              
  protocol PriceProviding {                                                                                                                   
      func getPrice(for asset: AssetId) async throws -> Price?                                                                                
  }                                                                                                                                           
                                                                                                                                              
  Services depend on protocols, not concrete implementations. This breaks implicit cycles.                                                    
                                                                                                                                              
  5. Lazy Feature Loading                                                                                                                     
                                                                                                                                              
  Some features (Perpetuals, NFT, MarketInsight) could be optional modules:                                                                   
  Features/                                                                                                                                   
  ├── Core/                   # Always loaded: Assets, Transfer, Settings                                                                     
  └── Optional/               # Lazy loaded: Perpetuals, NFT, MarketInsight                                                                   
                                                                                                                                              
  Proposed New Architecture                                                                                                                   
                                                                                                                                              
  LEVEL 0: Root (unchanged)                                                                                                                   
  LEVEL 1: Foundation (unchanged)                                                                                                             
  LEVEL 2: Storage + Crypto (unchanged)                                                                                                       
  LEVEL 3:                                                                                                                                    
    ├── PrimitivesUI (thin layer)                                                                                                             
    ├── ServiceProtocols (interfaces only)                                                                                                    
    └── Signer                                                                                                                                
  LEVEL 4: Domain Services (split from ChainServices)                                                                                         
    ├── NodeManagementServices                                                                                                                
    ├── StakingChainServices                                                                                                                  
    ├── NameResolutionServices                                                                                                                
    └── WalletConnectionServices                                                                                                              
  LEVEL 5: Feature Services (split from FeatureServices)                                                                                      
    ├── WalletCoreServices                                                                                                                    
    ├── AssetManagementServices                                                                                                               
    ├── PricingServices                                                                                                                       
    ├── TransactionServices                                                                                                                   
    └── UIStateServices                                                                                                                       
  LEVEL 6: Features (can now depend on specific service packages)                                                                             
                                                                                                                                              
  Priority Order for Implementation                                                                                                           
                                                                                                                                              
  1. High Impact, Lower Risk: Split FeatureServices into domain packages                                                                      
  2. Medium Impact: Split ChainServices into focused packages                                                                                 
  3. Medium Impact: Thin out PrimitivesComponents                                                                                             
  4. Lower Priority: Protocol-based abstraction for cross-service deps                                                                        
                                                                                     

[gemcoder21]

Update: Removed ChainServices → PrimitivesComponents Dependency

Found and removed an unnecessary dependency: ChainServices was importing PrimitivesComponents but not actually using it. The NameService had an unused import.

Changes Made:

• Removed PrimitivesComponents from ChainServices package dependencies
• Removed unused import from NameService.swift

Impact on Dependency Graph:

BEFORE:
  PrimitivesComponents (139 files)
           │
           ▼
  ChainServices (8 services)  ← waited for PrimitivesComponents
           │
           ▼
  FeatureServices (24 services)


AFTER:
  PrimitivesComponents ────────────────────┐
           │                               │
  ChainServices (8 services)               │  ← can now compile in PARALLEL
           │                               │
           ▼                               ▼
  FeatureServices (24 services) ◄──────────┘

Updated Critical Path:

OLD: Primitives → Store → Blockchain → Signer → PrimitivesComponents → ChainServices → FeatureServices
NEW: Primitives → Store → Blockchain → Signer → ChainServices ─┐
                                                               ├─► FeatureServices
                                     PrimitivesComponents ─────┘

ChainServices can now start compiling as soon as its actual dependencies (Primitives, Store, Blockchain, GemAPI, Gemstone, GemstonePrimitives, Preferences) are ready, without waiting for PrimitivesComponents.

This is a small win but demonstrates there may be other unnecessary dependencies in the graph worth auditing.

[gemcoder21]

Updated Dependency Graph (after removing ChainServices → PrimitivesComponents)

LEVEL 0 - Root Packages (No dependencies, compile in parallel)
┌─────────┐ ┌───────────┐ ┌──────────┐ ┌──────────┐ ┌───────────────┐ ┌───────────────┐
│  Style  │ │Localization│ │ Keychain │ │ Gemstone │ │SwiftHTTPClient│ │ SystemServices│
└────┬────┘ └─────┬─────┘ └────┬─────┘ └────┬─────┘ └───────┬───────┘ └───────────────┘
     │            │            │            │               │
LEVEL 1 - Foundation
     │      ┌─────┴─────┐      │      ┌─────┴─────┐         │
     │      │Primitives │──────┼──────│GemstonePrim│        │
     │      └─────┬─────┘      │      └─────┬─────┘         │
     │            │            │            │               │
┌────┴────┐ ┌─────┴─────┐ ┌────┴────┐ ┌─────┴────┐   ┌──────┴──────┐
│Components│ │Formatters │ │Preferen.│ │WalletCore│   │   GemAPI    │
└────┬────┘ └─────┬─────┘ └────┬────┘ └─────┬────┘   └──────┬──────┘
     │            │            │            │               │
LEVEL 2 - Core Infrastructure
     │      ┌─────┴─────┐      │      ┌─────┴─────┐         │
     │      │Validators │      │      │  Store    │─────────┤
     │      └─────┬─────┘      │      └─────┬─────┘         │
     │            │            │            │               │
     │            │      ┌─────┴─────┐ ┌────┴─────┐         │
     │            │      │ Keystore  │ │Blockchain│◄────────┤
     │            │      └─────┬─────┘ └────┬─────┘         │
     │            │            │            │               │
LEVEL 3 - Signing & UI Bridge  │      ┌─────┴─────┐         │
     │            │            │      │  Signer   │         │
     │            │            │      └─────┬─────┘         │
     │            │            │            │               │
┌────┴────────────┴────────────┴────────────│───────────────┴───┐
│         PrimitivesComponents (139 files)  │                   │
│  deps: Primitives, GemstonePrim,          │                   │
│        Components, Style, Localization,   │                   │
│        Validators, Formatters             │                   │
└───────────────────────┬───────────────────┘                   │
                        │                                       │
LEVEL 4 - Services      │   ┌───────────────────────────────────┘
                        │   │
                        │   │  ┌────────────────────────────────────────────┐
                        │   │  │         ChainServices (7 services)         │
                        │   │  │  NodeService, StakeService, ChainService,  │
                        │   │  │  ScanService, ExplorerService, NameService,│
                        │   │  │  WalletConnectorService                    │
                        │   │  │                                            │
                        │   │  │  deps: Primitives, GemAPI, Store,          │
                        │   │  │        Blockchain, Gemstone, GemstonePrim, │
                        │   │  │        Preferences (NO PrimitivesComponents)│
                        │   │  └──────────────────┬─────────────────────────┘
                        │   │                     │
                        ▼   ▼                     ▼
┌───────────────────────────────────────────────────────────────┐
│                 FeatureServices (24 services)                 │
│  Wallet, Assets, Balance, Price, Transactions, NFT, Swap,     │
│  Banner, Notification, Auth, Rewards, Activity, Perpetual...  │
│                                                               │
│  deps: Primitives, Store, Blockchain, ChainServices, GemAPI,  │
│        Preferences, GemstonePrim, Gemstone, Signer, Keystore, │
│        Formatters, SwiftHTTPClient, NativeProviderService     │
└──────────────────────────┬────────────────────────────────────┘
                           │
LEVEL 5 - Features (22 modules)
┌──────────┬───────────┬───────────┬───────────┬───────────────┐
│ Transfer │ Settings  │   Swap    │Onboarding │    Assets     │
│(52 files)│(40 files) │ (26 f.)   │ (41 f.)   │   (18 f.)     │
├──────────┼───────────┼───────────┼───────────┼───────────────┤
│  Staking │ManageWallet│   NFT    │Perpetuals │ MarketInsight │
│  (35 f.) │ (30 f.)   │ (22 f.)  │  (28 f.)  │   (15 f.)     │
└──────────┴───────────┴───────────┴───────────┴───────────────┘

Key Change

ChainServices no longer depends on PrimitivesComponents - it was an unused import in NameService.

Build Parallelization Improvement

BEFORE: Sequential bottleneck
─────────────────────────────────────────────────────────────────►
Primitives → Store → Blockchain → PrimitivesComponents → ChainServices → FeatureServices

AFTER: Parallel paths merge at FeatureServices
─────────────────────────────────────────────────────────────────►
Primitives → Store → Blockchain → ChainServices ────────┐
                                                        ├──► FeatureServices
Primitives → Formatters → Validators ──────────────────┐│
                                                       ││
Style → Components ────────────────────────────────────┴┴──► PrimitivesComponents

ChainServices and PrimitivesComponents can now build in parallel since they have no dependency on each other.

[gemcoder21]

Dependency Analysis & Simple Parallelization Improvements

Current Bottlenecks Analysis

After analyzing all Package.swift files, the dependencies are well-maintained with no obvious dead weight. The main bottleneck is architectural rather than unused dependencies.

Current Critical Path (longest sequential chain):
Primitives → Store → Blockchain → ChainServices → FeatureServices → Features
     ↓                                                    ↑
Formatters → Validators ────────────────────────┐        │
     ↓                                          ↓        │
Components ──────────────────────► PrimitivesComponents ─┘

Problem: FeatureServices Monolith

FeatureServices contains 24 services in ONE package:

• WalletService, WalletsService, WalletSessionService
• AssetsService, BalanceService, DiscoverAssetsService
• PriceService, PriceAlertService
• TransactionsService, TransactionStateService
• NFTService, PerpetualService
• BannerService, NotificationService, ActivityService
• SwapService, DeviceService, AppService, AuthService, RewardsService...

Impact: Any change to ANY service rebuilds the entire FeatureServices package, which then triggers rebuild of ALL 22 Feature modules.

---

Simple Improvement Proposals

Proposal 1: Split FeatureServices by Domain (Medium Effort, High Impact)

FeatureServices/ (current: 1 package, 24 services)
         ↓
Split into 5 smaller packages:

┌─────────────────────┐  ┌─────────────────────┐  ┌──────────────────┐
│ WalletCoreServices  │  │AssetManagementServices│  │ PricingServices  │
│ - WalletService     │  │ - AssetsService      │  │ - PriceService   │
│ - WalletsService    │  │ - BalanceService     │  │ - PriceAlertSvc  │
│ - WalletSessionSvc  │  │ - NFTService         │  └──────────────────┘
└─────────────────────┘  │ - DiscoverAssetsSvc  │
                         └─────────────────────┘
┌─────────────────────┐  ┌─────────────────────┐
│TransactionServices  │  │  UIStateServices    │
│ - TransactionsSvc   │  │ - BannerService     │
│ - TransactionState  │  │ - NotificationSvc   │
│ - SwapService       │  │ - ActivityService   │
└─────────────────────┘  │ - AvatarService     │
                         └─────────────────────┘

Benefit: Features can depend on specific service packages. Changing PriceService wont rebuild TransactionServices.

---

Proposal 2: Extract High-Independence Services (Low Effort, Medium Impact)

Some services have minimal dependencies and could be standalone packages immediately:

Service	Current Deps	Can Be Standalone?
DeviceService	Primitives, Preferences	✅ Yes
AvatarService	Primitives, Store	✅ Yes
AuthService	Primitives, Keystore, Gemstone	✅ Yes
NotificationService	Primitives, Store	✅ Yes

Quick Win: Extract these 4 services into independent packages. They have no inter-service dependencies.

---

Proposal 3: Features Skip FeatureServices Where Possible (Low Effort)

Some Features might not need the full FeatureServices dependency. Audit each Feature to see if it can depend on specific services instead.

Example: If MarketInsight only needs PriceService, it could depend on a smaller PricingServices package instead of all of FeatureServices.

---

Proposal 4: Thin PrimitivesComponents (Medium Effort)

PrimitivesComponents has 139 files. Consider splitting:

PrimitivesComponents (current)
         ↓
┌─────────────────┐  ┌─────────────────┐  ┌─────────────────┐
│  PrimitivesUI   │  │ValidationViews  │  │ ChartComponents │
│ (AssetImage,    │  │(InputValidation,│  │ (ChartView,     │
│  AddressView,   │  │ validators)     │  │  ChartValues)   │
│  basic views)   │  └─────────────────┘  └─────────────────┘
└─────────────────┘

Features that dont need charts or validation can depend on lighter packages.

---

Priority Ranking

Proposal	Effort	Impact	Recommendation
2. Extract standalone services	Low	Medium	Start here
1. Split FeatureServices	Medium	High	Best ROI
3. Feature-specific deps	Low	Low-Med	Easy follow-up
4. Thin PrimitivesComponents	Medium	Medium	Future work

---

Immediate Action Items

1. ✅ Done: Remove ChainServices → PrimitivesComponents (already completed)
2. Next: Extract DeviceService, AvatarService, AuthService, NotificationService as standalone packages
3. Then: Group remaining FeatureServices into domain packages

[gemcoder21]

Detailed FeatureServices Split Proposal

Current Problem: Dependency Web

WalletsService depends on: BannerService, PriceService, BalanceService, AssetsService,
                          TransactionStateService, DiscoverAssetsService, WalletSessionService,
                          DeviceService, ChainService (10+ dependencies\!)

AppService depends on: BannerService, DeviceService, AssetsService, WalletService,
                      NotificationService, NodeService, ChainService (7+ dependencies\!)

These two "god services" create a dependency web where everything rebuilds together.

---

Proposed Split: 6 Domain Packages

┌──────────────────────────────────────────────────────────────────────────────┐
│ LEVEL 1: Foundation Services (no inter-service deps)                         │
├──────────────────────────────────────────────────────────────────────────────┤
│                                                                              │
│  ┌─────────────────────┐  ┌─────────────────────┐  ┌─────────────────────┐  │
│  │  DeviceServices     │  │  WalletCoreServices │  │  DataServices       │  │
│  │  ─────────────────  │  │  ──────────────────  │  │  ─────────────────  │  │
│  │  • DeviceService    │  │  • WalletService    │  │  • AddressNameSvc   │  │
│  │  • AvatarService    │  │  • WalletSessionSvc │  │  • ActivityService  │  │
│  │  • AuthService      │  │                     │  │                     │  │
│  │                     │  │  deps: Keystore,    │  │  deps: Store only   │  │
│  │  deps: Store, API   │  │        DeviceServices│  │                     │  │
│  └─────────────────────┘  └─────────────────────┘  └─────────────────────┘  │
│                                                                              │
└──────────────────────────────────────────────────────────────────────────────┘
                                       │
                                       ▼
┌──────────────────────────────────────────────────────────────────────────────┐
│ LEVEL 2: Domain Services (depend on Level 1)                                 │
├──────────────────────────────────────────────────────────────────────────────┤
│                                                                              │
│  ┌─────────────────────┐  ┌─────────────────────┐  ┌─────────────────────┐  │
│  │  AssetServices      │  │  PricingServices    │  │  NotificationServices│ │
│  │  ─────────────────  │  │  ──────────────────  │  │  ──────────────────  │ │
│  │  • AssetsService    │  │  • PriceService     │  │  • NotificationSvc  │  │
│  │  • BalanceService   │  │  • PriceAlertSvc    │  │  • BannerService    │  │
│  │  • NFTService       │  │                     │  │                     │  │
│  │  • PerpetualService │  │  deps: DeviceServices│ │  deps: DeviceServices│ │
│  │  • DiscoverAssetsSvc│  │        NotificationSvc│ │        WalletCoreSvc │ │
│  │                     │  │                     │  │                     │  │
│  │  deps: DeviceServices│  │                     │  │                     │  │
│  │        ChainServices│  │                     │  │                     │  │
│  └─────────────────────┘  └─────────────────────┘  └─────────────────────┘  │
│                                                                              │
│  ┌─────────────────────┐                                                    │
│  │ TransactionServices │                                                    │
│  │  ──────────────────  │                                                    │
│  │  • TransactionsSvc  │                                                    │
│  │  • TransactionState │                                                    │
│  │  • SwapService      │                                                    │
│  │                     │                                                    │
│  │  deps: AssetServices│                                                    │
│  │        DeviceServices│                                                   │
│  └─────────────────────┘                                                    │
│                                                                              │
└──────────────────────────────────────────────────────────────────────────────┘
                                       │
                                       ▼
┌──────────────────────────────────────────────────────────────────────────────┐
│ LEVEL 3: Orchestration Services (depend on Level 1 & 2)                      │
├──────────────────────────────────────────────────────────────────────────────┤
│                                                                              │
│  ┌─────────────────────────────────────────────────────────────────────┐    │
│  │                        AppServices                                   │    │
│  │  ─────────────────────────────────────────────────────────────────  │    │
│  │  • WalletsService (orchestrates wallet operations)                  │    │
│  │  • AppService (app lifecycle management)                            │    │
│  │  • RewardsService                                                   │    │
│  │                                                                     │    │
│  │  deps: All Level 1 & 2 packages                                     │    │
│  └─────────────────────────────────────────────────────────────────────┘    │
│                                                                              │
└──────────────────────────────────────────────────────────────────────────────┘

---

How This Simplifies Build Parallelization

Before (current):

FeatureServices (all 24 services) ────────► ALL Features
         │
    Any change to ANY service triggers rebuild of:
    - Entire FeatureServices package
    - All 22 Feature modules that depend on it

After (proposed):

                    ┌─► DeviceServices ───────────┐
                    │                             │
ChainServices ──────┼─► WalletCoreServices ───────┼───► Features that need wallets
                    │                             │
                    ├─► DataServices ─────────────┼───► Features that need data
                    │                             │
                    ├─► AssetServices ────────────┼───► Features that need assets
                    │                             │
                    ├─► PricingServices ──────────┼───► Features that need pricing
                    │                             │
                    ├─► NotificationServices ─────┼───► Features that need notifications
                    │                             │
                    └─► TransactionServices ──────┼───► Features that need transactions
                                                  │
                                    AppServices ──┘ (only for features that need orchestration)

Benefits:

Scenario	Before	After
Change PriceService	Rebuilds 24 services + 22 features	Rebuilds PricingServices + features that import it
Change DeviceService	Rebuilds everything	Rebuilds DeviceServices + dependent packages
Change WalletsService	Rebuilds everything	Rebuilds AppServices only
Add new NFT feature	Waits for all services	Only needs AssetServices

---

Concrete Package Structure

Packages/
├── DeviceServices/
│   ├── Package.swift
│   ├── DeviceService/
│   ├── AvatarService/
│   └── AuthService/
│
├── WalletCoreServices/
│   ├── Package.swift
│   ├── WalletService/
│   └── WalletSessionService/
│
├── DataServices/
│   ├── Package.swift
│   ├── AddressNameService/
│   └── ActivityService/
│
├── AssetServices/
│   ├── Package.swift
│   ├── AssetsService/
│   ├── BalanceService/
│   ├── NFTService/
│   ├── PerpetualService/
│   └── DiscoverAssetsService/
│
├── PricingServices/
│   ├── Package.swift
│   ├── PriceService/
│   └── PriceAlertService/
│
├── NotificationServices/
│   ├── Package.swift
│   ├── NotificationService/
│   └── BannerService/
│
├── TransactionServices/
│   ├── Package.swift
│   ├── TransactionsService/
│   ├── TransactionStateService/
│   └── SwapService/
│
└── AppServices/
    ├── Package.swift
    ├── WalletsService/
    ├── AppService/
    └── RewardsService/

---

Migration Path (Incremental)

1. Phase 1: Extract DeviceServices (low risk, no dependents within FeatureServices)
2. Phase 2: Extract DataServices (AddressNameService, ActivityService - isolated)
3. Phase 3: Extract WalletCoreServices
4. Phase 4: Extract PricingServices
5. Phase 5: Extract remaining domain packages
6. Phase 6: Rename remaining FeatureServices → AppServices

Each phase can be done independently and tested before proceeding.