addressing PR comments

Author: avinash2692

test/backends/test_huggingface.py

@@ -37,15 +37,15 @@ def session(backend):
     yield session
     session.reset()
 
-@pytest.mark.qualitative
+
 def test_system_prompt(session):
     result = session.chat(
         "Where are we going?",
         model_options={ModelOption.SYSTEM_PROMPT: "Talk like a pirate."},
     )
     print(result)
 
-@pytest.mark.qualitative
+
 def test_constraint_alora(session, backend):
     answer = session.instruct(
         "Corporate wants you to find the difference between these two strings: aaaaaaaaaa aaaaabaaaa. Be concise and don't write code to answer the question.",
@@ -63,7 +63,7 @@ def test_constraint_alora(session, backend):
     )
     assert alora_output in ["Y", "N"], alora_output
 
-@pytest.mark.qualitative
+
 def test_constraint_lora_with_requirement(session, backend):
     answer = session.instruct(
         "Corporate wants you to find the difference between these two strings: aaaaaaaaaa aaaaabaaaa"
@@ -79,6 +79,7 @@ def test_constraint_lora_with_requirement(session, backend):
     assert isinstance(val_result, ValidationResult)
     assert str(val_result.reason) in ["Y", "N"]
 
+
 @pytest.mark.qualitative
 def test_constraint_lora_override(session, backend):
     backend.default_to_constraint_checking_alora = False  # type: ignore
@@ -94,6 +95,7 @@ def test_constraint_lora_override(session, backend):
     assert isinstance(default_output_to_bool(str(val_result.reason)), bool)
     backend.default_to_constraint_checking_alora = True
 
+
 @pytest.mark.qualitative
 def test_constraint_lora_override_does_not_override_alora(session, backend):
     backend.default_to_constraint_checking_alora = False  # type: ignore
@@ -111,6 +113,7 @@ def test_constraint_lora_override_does_not_override_alora(session, backend):
     assert str(val_result.reason) in ["Y", "N"]
     backend.default_to_constraint_checking_alora = True
 
+
 @pytest.mark.qualitative
 def test_llmaj_req_does_not_use_alora(session, backend):
     backend.default_to_constraint_checking_alora = True  # type: ignore
@@ -127,11 +130,12 @@ def test_llmaj_req_does_not_use_alora(session, backend):
     assert isinstance(val_result, ValidationResult)
     assert str(val_result.reason) not in ["Y", "N"]
 
-@pytest.mark.qualitative
+
 def test_instruct(session):
     result = session.instruct("Compute 1+1.")
     print(result)
 
+
 @pytest.mark.qualitative
 def test_multiturn(session):
     session.instruct("Compute 1+1")
@@ -142,6 +146,7 @@ def test_multiturn(session):
     words = session.instruct("Now list five English words that start with that letter.")
     print(words)
 
+
 @pytest.mark.qualitative
 def test_format(session):
     class Person(pydantic.BaseModel):
@@ -172,7 +177,7 @@ class Email(pydantic.BaseModel):
         "The email address should be at example.com"
     )
 
-@pytest.mark.qualitative
+
 def test_generate_from_raw(session):
     prompts = ["what is 1+1?", "what is 2+2?", "what is 3+3?", "what is 4+4?"]
 
@@ -182,6 +187,7 @@ def test_generate_from_raw(session):
 
     assert len(results) == len(prompts)
 
+
 @pytest.mark.qualitative
 def test_generate_from_raw_with_format(session):
     prompts = ["what is 1+1?", "what is 2+2?", "what is 3+3?", "what is 4+4?"]

test/stdlib_basics/test_contextual_session.py

@@ -160,7 +160,7 @@ def test_all_convenience_functions(model_id):
 
 def test_session_with_parameters(model_id):
     """Test contextual session with custom parameters."""
-    with start_session(backend_name="ollama", model_id=META_LLAMA_3_2_1B) as m:
+    with start_session(backend_name="ollama", model_id=model_id) as m:
         result = instruct("test with parameters")
         assert isinstance(result, ModelOutputThunk)
         assert isinstance(m, MelleaSession)