[Refactor] Make types_core_test work on MacOS (StarRocks#70288)

alvin-celerdata · web-flow · commit d6230155b769 · 2026-03-15T20:59:45.000+08:00
Signed-off-by: alvin-celerdata &lt;alvin.zhao@celerdata.com&gt;
diff --git a/be/cmake_modules/ThirdParty.cmake b/be/cmake_modules/ThirdParty.cmake
@@ -282,9 +282,23 @@ set_target_properties(benchmark_main PROPERTIES IMPORTED_LOCATION ${THIRDPARTY_D
 
 if (ENABLE_MULTI_DYNAMIC_LIBS)
     add_library(fmt SHARED IMPORTED)
-    set_target_properties(fmt PROPERTIES IMPORTED_LOCATION ${THIRDPARTY_DIR}/lib64/libfmt.so.8)
-    file(GLOB FMT_SO_FILES "${THIRDPARTY_DIR}/lib64/libfmt.so*")
-    install(FILES ${FMT_SO_FILES} DESTINATION ${OUTPUT_DIR}/lib)
+    if (APPLE)
+        if (EXISTS "${THIRDPARTY_DIR}/lib64/libfmt.dylib" OR EXISTS "${THIRDPARTY_DIR}/lib64/libfmt.12.dylib")
+            set(FMT_SHARED_DIR "${THIRDPARTY_DIR}/lib64")
+        else()
+            set(FMT_SHARED_DIR "${THIRDPARTY_DIR}/lib")
+        endif()
+        find_library(FMT_SHARED_LIBRARY NAMES fmt PATHS ${FMT_SHARED_DIR} NO_DEFAULT_PATH)
+        if (NOT FMT_SHARED_LIBRARY)
+            message(FATAL_ERROR "fmt shared library not found under ${FMT_SHARED_DIR}")
+        endif()
+        set_target_properties(fmt PROPERTIES IMPORTED_LOCATION ${FMT_SHARED_LIBRARY})
+        file(GLOB FMT_SHARED_FILES "${FMT_SHARED_DIR}/libfmt*.dylib")
+    else()
+        set_target_properties(fmt PROPERTIES IMPORTED_LOCATION ${THIRDPARTY_DIR}/lib64/libfmt.so.8)
+        file(GLOB FMT_SHARED_FILES "${THIRDPARTY_DIR}/lib64/libfmt.so*")
+    endif()
+    install(FILES ${FMT_SHARED_FILES} DESTINATION ${OUTPUT_DIR}/lib)
 else()
     add_library(fmt STATIC IMPORTED)
     set_target_properties(fmt PROPERTIES IMPORTED_LOCATION ${THIRDPARTY_DIR}/lib64/libfmt.a)
diff --git a/be/src/base/crypto/sha.cpp b/be/src/base/crypto/sha.cpp
@@ -16,6 +16,7 @@
 
 #include <iomanip>
 #include <iostream>
+#include <sstream>
 #include <string>
 
 namespace starrocks {
diff --git a/be/src/base/status.h b/be/src/base/status.h
@@ -5,6 +5,8 @@
 #pragma once
 
 #include <cstdint>
+#include <ostream>
+#include <sstream>
 #include <string>
 #include <string_view>
 
diff --git a/be/src/base/statusor.h b/be/src/base/statusor.h
@@ -38,6 +38,7 @@
 #include <exception>
 #include <initializer_list>
 #include <new>
+#include <ostream>
 #include <string>
 #include <type_traits>
 #include <utility>
diff --git a/be/src/base/string/string_parser.hpp b/be/src/base/string/string_parser.hpp
@@ -770,7 +770,7 @@ inline T StringParser::string_to_decimal(const char* s, int len, int type_precis
                 if (LIKELY(divisor >= 0)) {
                     T remainder = value % divisor;
                     value /= divisor;
-                    if (std::abs(remainder) >= (divisor >> 1)) {
+                    if (remainder >= (divisor >> 1)) {
                         value += 1;
                     }
                 } else {
diff --git a/be/src/base/time/date_func.cpp b/be/src/base/time/date_func.cpp
@@ -18,6 +18,7 @@
 #include "base/time/date_func.h"
 
 #include <iomanip>
+#include <sstream>
 
 namespace starrocks {
 
diff --git a/be/src/base/types/int128.h b/be/src/base/types/int128.h
@@ -26,6 +26,18 @@ namespace starrocks {
 using int128_t = __int128;
 using uint128_t = unsigned __int128;
 
+inline constexpr uint128_t abs_as_uint128(int128_t value) {
+    uint128_t abs_value = static_cast<uint128_t>(value);
+    if (value < 0) {
+        abs_value = ~abs_value + 1;
+    }
+    return abs_value;
+}
+
+inline constexpr int128_t abs(int128_t value) {
+    return static_cast<int128_t>(abs_as_uint128(value));
+}
+
 inline std::string int128_to_string(__int128 value) {
     return integer_to_string<__int128>(value);
 }
diff --git a/be/src/base/types/int256.h b/be/src/base/types/int256.h
@@ -17,6 +17,7 @@
 #include <fmt/format.h>
 
 #include <cmath>
+#include <ostream>
 #include <string>
 #include <type_traits>
 
diff --git a/be/src/column/binary_column.h b/be/src/column/binary_column.h
@@ -15,6 +15,7 @@
 #pragma once
 
 #include <memory>
+#include <sstream>
 #include <type_traits>
 
 #include "base/string/slice.h"
diff --git a/be/src/column/column_access_path.h b/be/src/column/column_access_path.h
@@ -15,6 +15,7 @@
 #pragma once
 
 #include <memory>
+#include <ostream>
 #include <string>
 #include <vector>
 
diff --git a/be/src/column/const_column.h b/be/src/column/const_column.h
@@ -14,6 +14,8 @@
 
 #pragma once
 
+#include <sstream>
+
 #include "column/column.h"
 #include "column/vectorized_fwd.h"
 #include "common/logging.h"
diff --git a/be/src/column/german_string.h b/be/src/column/german_string.h
@@ -17,6 +17,7 @@
 #include <glog/logging.h>
 
 #include <cstdint>
+#include <ostream>
 #include <string>
 #include <string_view>
 #include <vector>
diff --git a/be/src/column/nullable_column.h b/be/src/column/nullable_column.h
@@ -14,6 +14,8 @@
 
 #pragma once
 
+#include <sstream>
+
 #include "column/fixed_length_column.h"
 #include "column/vectorized_fwd.h"
 #include "common/logging.h"
diff --git a/be/src/column/object_column.h b/be/src/column/object_column.h
@@ -15,6 +15,7 @@
 #pragma once
 
 #include <memory>
+#include <sstream>
 
 #include "column/column.h"
 #include "column/vectorized_fwd.h"
diff --git a/be/src/column/schema.h b/be/src/column/schema.h
@@ -15,6 +15,7 @@
 #pragma once
 
 #include <numeric>
+#include <sstream>
 #include <string_view>
 #include <utility>
 
diff --git a/be/src/exprs/math_functions.cpp b/be/src/exprs/math_functions.cpp
@@ -249,17 +249,17 @@ DEFINE_MATH_UNARY_FN_WITH_IMPL(abs_float, TYPE_FLOAT, TYPE_FLOAT, std::fabs);
 
 // integer abs
 // std::abs(TYPE_MIN) is still TYPE_MIN, so integers except largeint need to cast to ResultType
-// before std::abs.
-DEFINE_MATH_UNARY_FN_WITH_IMPL(abs_largeint, TYPE_LARGEINT, TYPE_LARGEINT, std::abs);
-DEFINE_MATH_UNARY_FN_CAST_WITH_IMPL(abs_bigint, TYPE_BIGINT, TYPE_LARGEINT, std::abs);
+// before std::abs. largeint uses starrocks::abs so int128 remains portable across libstdc++ and libc++.
+DEFINE_MATH_UNARY_FN_WITH_IMPL(abs_largeint, TYPE_LARGEINT, TYPE_LARGEINT, starrocks::abs);
+DEFINE_MATH_UNARY_FN_CAST_WITH_IMPL(abs_bigint, TYPE_BIGINT, TYPE_LARGEINT, starrocks::abs);
 DEFINE_MATH_UNARY_FN_CAST_WITH_IMPL(abs_int, TYPE_INT, TYPE_BIGINT, std::abs);
 DEFINE_MATH_UNARY_FN_CAST_WITH_IMPL(abs_smallint, TYPE_SMALLINT, TYPE_INT, std::abs);
 DEFINE_MATH_UNARY_FN_CAST_WITH_IMPL(abs_tinyint, TYPE_TINYINT, TYPE_SMALLINT, std::abs);
 
 // decimal abs
 DEFINE_MATH_UNARY_FN_WITH_IMPL(abs_decimal32, TYPE_DECIMAL32, TYPE_DECIMAL32, std::abs);
 DEFINE_MATH_UNARY_FN_WITH_IMPL(abs_decimal64, TYPE_DECIMAL64, TYPE_DECIMAL64, std::abs);
-DEFINE_MATH_UNARY_FN_WITH_IMPL(abs_decimal128, TYPE_DECIMAL128, TYPE_DECIMAL128, std::abs);
+DEFINE_MATH_UNARY_FN_WITH_IMPL(abs_decimal128, TYPE_DECIMAL128, TYPE_DECIMAL128, starrocks::abs);
 DEFINE_MATH_UNARY_FN_WITH_IMPL(abs_decimal256, TYPE_DECIMAL256, TYPE_DECIMAL256, std::abs);
 
 // degrees
diff --git a/be/src/gutil/port.h b/be/src/gutil/port.h
@@ -12,7 +12,7 @@
 #include <cstring> // for memcpy()
 
 #if defined(__APPLE__)
-#include <unistd.h> // for getpagesize() on mac
+#include <unistd.h> // for sysconf() on mac
 #elif defined(OS_CYGWIN)
 #include <malloc.h> // for memalign()
 #endif
@@ -620,7 +620,8 @@ inline void* aligned_malloc(size_t size, int minimum_alignment) {
     // mac allocs are already 16-byte aligned.
     if (minimum_alignment <= 16) return malloc(size);
     // next, try to return page-aligned memory. perhaps overkill
-    if (minimum_alignment <= getpagesize()) return valloc(size);
+    long page_size = sysconf(_SC_PAGESIZE);
+    if (page_size > 0 && minimum_alignment <= page_size) return valloc(size);
     // give up
     return NULL;
 #elif defined(OS_CYGWIN)
diff --git a/be/src/types/date_value.h b/be/src/types/date_value.h
@@ -16,6 +16,7 @@
 
 #include <chrono>
 #include <cstdint>
+#include <ostream>
 #include <string>
 
 #include "base/string/slice.h"
diff --git a/be/src/types/decimalv2_value.cpp b/be/src/types/decimalv2_value.cpp
@@ -100,10 +100,6 @@ int128_t div_gcc_x86_64(const int128_t& x, const int128_t& y) {
 }
 #endif // defined(__x86_64__) && defined(__GNUC__)
 
-static inline int128_t abs(const int128_t& x) {
-    return (x < 0) ? -x : x;
-}
-
 static inline int128_t do_add(int128_t x, int128_t y) {
     auto res = x + y;
     auto s = res >> 127;
@@ -200,7 +196,7 @@ int128_t mul(const int128_t& x, const int128_t& y) {
 
     bool is_positive = (x > 0 && y > 0) || (x < 0 && y < 0);
 
-    do_mul(abs(x), abs(y), &result);
+    do_mul(starrocks::abs(x), starrocks::abs(y), &result);
 
     if (!is_positive) result = -result;
 
@@ -220,7 +216,7 @@ int128_t div(const int128_t& x, const int128_t& y) {
     //todo: return 0 for divide zero
     if (x == 0 || y == 0) return DecimalV2Value(0);
     bool is_positive = (x > 0 && y > 0) || (x < 0 && y < 0);
-    do_div(abs(x), abs(y), &result);
+    do_div(starrocks::abs(x), starrocks::abs(y), &result);
 
     if (!is_positive) result = -result;
 
@@ -440,7 +436,7 @@ int DecimalV2Value::round(DecimalV2Value* to, int rounding_scale, DecimalRoundMo
     switch (op) {
     case HALF_UP:
     case HALF_EVEN:
-        if (abs(remainder) >= (base >> 1)) {
+        if (starrocks::abs_as_uint128(remainder) >= static_cast<uint128_t>(base >> 1)) {
             result = (result + one) * base;
         } else {
             result = result * base;
diff --git a/be/src/types/decimalv3.h b/be/src/types/decimalv3.h
@@ -99,9 +99,20 @@ class DecimalV3Arithmetics {
         // [b/2] == r means round half to up.
         // carry depends on sign of a^b.
         Type carry = ((a ^ b) >> (sizeof(Type) * 8 - 1)) | 1;
-        Type abs_b = std::abs(b);
-        Type abs_r = std::abs(r);
-        bool need_carry = ((abs_b >> 1) + (abs_b & 1)) <= abs_r;
+        bool need_carry = false;
+        if constexpr (std::is_same_v<Type, int128_t>) {
+            uint128_t abs_b = abs_as_uint128(b);
+            uint128_t abs_r = abs_as_uint128(r);
+            need_carry = ((abs_b >> 1) + (abs_b & 1)) <= abs_r;
+        } else if constexpr (std::is_same_v<Type, int256_t>) {
+            Type abs_b = starrocks::abs(b);
+            Type abs_r = starrocks::abs(r);
+            need_carry = ((abs_b >> 1) + (abs_b & 1)) <= abs_r;
+        } else {
+            Type abs_b = std::abs(b);
+            Type abs_r = std::abs(r);
+            need_carry = ((abs_b >> 1) + (abs_b & 1)) <= abs_r;
+        }
         *c += carry & -Type(need_carry);
         return false;
     }
diff --git a/be/src/types/json_value_converter.cpp b/be/src/types/json_value_converter.cpp
@@ -97,6 +97,10 @@ class SimdJsonConverter {
             RETURN_IF_ERROR(convert_null(field_name, is_object, builder));
             break;
         }
+        default: {
+            auto err_msg = strings::Substitute("Unsupported simdjson value type. field_name=$0", field_name);
+            return Status::InvalidArgument(err_msg);
+        }
         }
         return Status::OK();
     }
@@ -189,10 +193,11 @@ class SimdJsonConverter {
 
     static inline Status convert(std::string_view str, std::string_view field_name, bool is_object,
                                  vpack::Builder* builder) {
+        auto value = vpack::ValuePair(toStringRef(str), vpack::ValueType::String);
         if (is_object) {
-            builder->add(toStringRef(field_name), vpack::Value(str));
+            builder->add(toStringRef(field_name), value);
         } else {
-            builder->add(vpack::Value(str));
+            builder->add(value);
         }
         return Status::OK();
     }
@@ -216,7 +221,9 @@ class SimdJsonConverter {
     }
 
 private:
-    static inline vpack::StringRef toStringRef(std::string_view view) { return {view.data(), view.length()}; }
+    static inline vpack::StringRef toStringRef(std::string_view view) {
+        return {view.empty() ? "" : view.data(), view.length()};
+    }
 };
 
 // Convert SIMD-JSON object/value to a JsonValue
diff --git a/be/src/types/logical_type.h b/be/src/types/logical_type.h
@@ -14,7 +14,7 @@
 
 #pragma once
 
-#include <iosfwd>
+#include <ostream>
 
 #include "base/utility/guard.h"
 #include "gen_cpp/Opcodes_types.h"
diff --git a/be/src/types/timestamp_value.h b/be/src/types/timestamp_value.h
@@ -18,6 +18,7 @@
 #include <cctz/time_zone.h>
 
 #include <chrono>
+#include <ostream>
 #include <string>
 
 #include "types/date_value.h"
diff --git a/be/src/types/type_descriptor.h b/be/src/types/type_descriptor.h
@@ -14,6 +14,7 @@
 
 #pragma once
 
+#include <ostream>
 #include <string>
 #include <vector>
 
diff --git a/be/src/types/variant.h b/be/src/types/variant.h
@@ -19,6 +19,7 @@
 
 #include <cstddef>
 #include <cstdint>
+#include <sstream>
 #include <string_view>
 
 #include "base/decimal_types.h"
diff --git a/be/test/column/CMakeLists.txt b/be/test/column/CMakeLists.txt
@@ -53,7 +53,7 @@ set(COLUMN_TEST_LINK_LIBS
     StarRocksGen
     ${STARROCKS_DEPENDENCIES}
     ${STARROCKS_STATIC_LINK_LIBS}
-    ${WL_LINK_DYNAMIC} -lresolv -liberty -lc -lm -ldl -rdynamic -pthread ${WRAP_LINKER_FLAGS}
+    ${WL_LINK_DYNAMIC} ${STARROCKS_SYSTEM_LINK_LIBS} ${WRAP_LINKER_FLAGS}
     ${WL_START_GROUP}
     gmock
     gtest
@@ -83,7 +83,7 @@ set(CHUNK_TEST_LINK_LIBS
     StarRocksGen
     ${STARROCKS_DEPENDENCIES}
     ${STARROCKS_STATIC_LINK_LIBS}
-    ${WL_LINK_DYNAMIC} -lresolv -liberty -lc -lm -ldl -rdynamic -pthread ${WRAP_LINKER_FLAGS}
+    ${WL_LINK_DYNAMIC} ${STARROCKS_SYSTEM_LINK_LIBS} ${WRAP_LINKER_FLAGS}
     ${WL_START_GROUP}
     gmock
     gtest
diff --git a/be/test/exprs/CMakeLists.txt b/be/test/exprs/CMakeLists.txt
@@ -55,7 +55,7 @@ set(EXPR_CORE_TEST_LINK_LIBS
     StarRocksGen
     ${STARROCKS_DEPENDENCIES}
     ${STARROCKS_STATIC_LINK_LIBS}
-    ${WL_LINK_DYNAMIC} -lresolv -liberty -lc -lm -ldl -rdynamic -pthread ${WRAP_LINKER_FLAGS}
+    ${WL_LINK_DYNAMIC} ${STARROCKS_SYSTEM_LINK_LIBS} ${WRAP_LINKER_FLAGS}
     ${WL_START_GROUP}
     gmock
     gtest
diff --git a/be/test/fs/CMakeLists.txt b/be/test/fs/CMakeLists.txt
@@ -27,7 +27,7 @@ set(FS_CORE_TEST_LINK_LIBS
     StarRocksGen
     ${STARROCKS_DEPENDENCIES}
     ${STARROCKS_STATIC_LINK_LIBS}
-    ${WL_LINK_DYNAMIC} -lresolv -liberty -lc -lm -ldl -rdynamic -pthread ${WRAP_LINKER_FLAGS}
+    ${WL_LINK_DYNAMIC} ${STARROCKS_SYSTEM_LINK_LIBS} ${WRAP_LINKER_FLAGS}
     ${WL_START_GROUP}
     gmock
     gtest
diff --git a/be/test/io/CMakeLists.txt b/be/test/io/CMakeLists.txt
@@ -27,7 +27,7 @@ set(IO_TEST_LINK_LIBS
     StarRocksGen
     ${STARROCKS_DEPENDENCIES}
     ${STARROCKS_STATIC_LINK_LIBS}
-    ${WL_LINK_DYNAMIC} -lresolv -liberty -lc -lm -ldl -rdynamic -pthread ${WRAP_LINKER_FLAGS}
+    ${WL_LINK_DYNAMIC} ${STARROCKS_SYSTEM_LINK_LIBS} ${WRAP_LINKER_FLAGS}
     ${WL_START_GROUP}
     gmock
     gtest
diff --git a/be/test/runtime/CMakeLists.txt b/be/test/runtime/CMakeLists.txt
@@ -37,7 +37,7 @@ set(RUNTIME_CORE_TEST_LINK_LIBS
     StarRocksGen
     ${STARROCKS_DEPENDENCIES}
     ${STARROCKS_STATIC_LINK_LIBS}
-    ${WL_LINK_DYNAMIC} -lresolv -liberty -lc -lm -ldl -rdynamic -pthread ${WRAP_LINKER_FLAGS}
+    ${WL_LINK_DYNAMIC} ${STARROCKS_SYSTEM_LINK_LIBS} ${WRAP_LINKER_FLAGS}
     ${WL_START_GROUP}
     gmock
     gtest
diff --git a/be/test/types/CMakeLists.txt b/be/test/types/CMakeLists.txt
@@ -38,7 +38,7 @@ set(TYPES_TEST_LINK_LIBS
     StarRocksGen
     ${STARROCKS_DEPENDENCIES}
     ${STARROCKS_STATIC_LINK_LIBS}
-    ${WL_LINK_DYNAMIC} -lresolv -liberty -lc -lm -ldl -rdynamic -pthread ${WRAP_LINKER_FLAGS}
+    ${WL_LINK_DYNAMIC} ${STARROCKS_SYSTEM_LINK_LIBS} ${WRAP_LINKER_FLAGS}
     ${WL_START_GROUP}
     gmock
     gtest
diff --git a/be/test/types/json_value_test.cpp b/be/test/types/json_value_test.cpp

Original file line number	Diff line number	Diff line change
`@@ -770,7 +770,7 @@ inline T StringParser::string_to_decimal(const char* s, int len, int type_precis`
`770`	`770`	`if (LIKELY(divisor >= 0)) {`
`771`	`771`	`T remainder = value % divisor;`
`772`	`772`	`value /= divisor;`
`773`		`- if (std::abs(remainder) >= (divisor >> 1)) {`
	`773`	`+ if (remainder >= (divisor >> 1)) {`
`774`	`774`	`value += 1;`
`775`	`775`	`}`
`776`	`776`	`} else {`