Deps version fix (#59)

* limit hf version to prevent using transformers v5 for now

* remove an no-op duplicate line in MLX

Author: shepardxia

.github/workflows/coverage.yml

@@ -24,14 +24,12 @@ jobs:
 
       - name: Install dependencies
         run: |
-          python -m venv venv
-          source venv/bin/activate
-          pip install -e .[test]
+          python -m pip install -U pip
+          pip install -e .
           pip install -r requirements-dev.txt
 
       - name: Run tests
         run: |
-          source venv/bin/activate
           coverage run --source=genlm/backend -m pytest --benchmark-disable --ignore=tests/test_mlx.py
           coverage json --omit "*/test*"
           coverage report --omit "*/test*"
@@ -59,14 +57,12 @@ jobs:
 
       - name: Install dependencies
         run: |
-          python -m venv venv
-          source venv/bin/activate
+          python -m pip install -U pip
           pip install -e .[mlx]
           pip install -r requirements-dev.txt
 
       - name: Run MLX tests
         run: |
-          source venv/bin/activate
           coverage run --source=genlm/backend -m pytest tests/test_mlx.py
           coverage json --omit "*/test*"
           coverage report --omit "*/test*"

.github/workflows/pytest.yml

@@ -11,7 +11,7 @@ on:
 
 jobs:
   test:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
 
     steps:
       - uses: actions/checkout@v4
@@ -23,10 +23,12 @@ jobs:
           python-version: 3.11.5
           cache: 'pip'
 
-      - name: Run Tests
+      - name: Install dependencies
         run: |
-          python -m venv venv
-          source venv/bin/activate
-          pip install -e .[test]
+          python -m pip install -U pip
+          pip install -e .
           pip install -r requirements-dev.txt
+
+      - name: Run Tests
+        run: |
           python -m pytest tests --ignore=tests/test_mlx.py

genlm/backend/llm/mlx.py

@@ -383,7 +383,6 @@ def batch_evaluate_queries(self):
 
             assert len(results) == len(unique_queries)
 
-            results = results
             for i, q in enumerate(unique_queries):
                 for dup_query in query_groups[tuple(q.prompt)]:
                     dup_query.future.set_result(results[i])

pyproject.toml

@@ -9,7 +9,7 @@ authors = [
 ]
 dependencies = [
     "torch",
-    "transformers>=4.36.0",
+    "transformers>=4.36.0,<5.0.0.rc0",
     "sentencepiece",
     "protobuf",
     "accelerate",