no to deploy in prod, investigate spring local invoker service context corruption

Author: cmangeat

core/src/main/java/jeeves/server/context/ServiceContext.java

@@ -67,6 +67,18 @@ public class ServiceContext extends BasicContext {
     private JeevesServlet _servlet;
     private boolean _startupError = false;
     private Map<String, String> _startupErrors;
+
+    public static InheritableThreadLocal<Broken> broken = new InheritableThreadLocal<Broken>();
+
+    public static class Broken {
+        public ServiceContext corrupted;
+        public StackTraceElement callingFrame;
+
+        public Broken setBroken(ServiceContext srvContext) {
+            this.corrupted = srvContext;
+            return this;
+        }
+    }
     /**
      * Property to be able to add custom response headers depending on the code (and not the xml of
      * Jeeves)
@@ -96,6 +108,7 @@ public ServiceContext(final String service, final ConfigurableApplicationContext
         setResponseHeaders(new HashMap<String, String>());
     }
 
+
     /**
      * ServiceManager sets the service context thread local when dispatch is called.  this method
      * will return null or the service context
@@ -104,6 +117,9 @@ public ServiceContext(final String service, final ConfigurableApplicationContext
      */
     @CheckForNull
     public static ServiceContext get() {
+        if (broken.get() != null && broken.get().corrupted != null) {
+            new Throwable("someone use a corrupted context").printStackTrace(System.err);
+        }
         return THREAD_LOCAL_INSTANCE.get();
     }
 

core/src/main/java/jeeves/xlink/Processor.java

@@ -186,7 +186,7 @@ private static Element resolveXLink(String uri, String idSearch, ServiceContext
             if (uri.startsWith(XLink.LOCAL_PROTOCOL)) {
                 SpringLocalServiceInvoker springLocalServiceInvoker = srvContext.getBean(SpringLocalServiceInvoker.class);
                 remoteFragment = (Element)springLocalServiceInvoker.invoke(uri);
-                srvContext.setAsThreadLocal();
+                ServiceContext.broken.set(new ServiceContext.Broken().setBroken(srvContext));
             } else {
                 // Avoid references to filesystem
                 if (uri.toLowerCase().startsWith("file://")) {