Fix version resolution in CLI

This was broken in quarkusio#49926 where the property name was changed
mistakenly.

To be honest, I'm also not sure the new method is as safe as it used to
be, especially on Windows as we also dropped the specific handling of
the jar pattern. There was a specific comment about it in the
preexisting method.
I suppose we will see how it goes...

Author: gsmet

devtools/cli-common/src/main/java/io/quarkus/cli/common/VersionHelper.java

@@ -34,7 +34,7 @@ public static String clientVersion() {
                     props.load(is);
                 }
             }
-            version = props.getProperty("quarkus.version", "999-SNAPSHOT");
+            version = props.getProperty("quarkus-core-version", "999-SNAPSHOT");
         } catch (Exception e) {
             version = "999-SNAPSHOT"; // fallback version
         }

devtools/cli/src/test/java/io/quarkus/cli/CliVersionTest.java

@@ -18,6 +18,7 @@ public void testCommandVersion() throws Exception {
                 "Version output for command aliases should be the same.");
 
         CliDriver.Result result2 = CliDriver.execute(workspaceRoot, "--version");
+        result2.echoSystemOut();
         Assertions.assertEquals(result.stdout, result2.stdout, "Version output for command aliases should be the same.");
     }
 }