Skip to content

Commit e5358e6

Browse files
authored
Merge pull request quarkusio#50646 from geoand/quarkusio#49504
Improve handling of `quarkus.test.continuous-testing=false`
2 parents dfa40f6 + e9f7bea commit e5358e6

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

core/deployment/src/main/java/io/quarkus/deployment/dev/testing/TestHandler.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
import io.quarkus.banner.BannerConfig;
99
import io.quarkus.builder.BuildResult;
10+
import io.quarkus.deployment.dev.testing.TestConfig.Mode;
1011
import io.quarkus.deployment.steps.BannerProcessor;
1112
import io.quarkus.dev.console.QuarkusConsole;
1213
import io.quarkus.runtime.BannerRecorder;
@@ -33,6 +34,9 @@ public boolean enabled() {
3334
return config.getOptionalValue("quarkus.banner.enabled", Boolean.class).orElse(true);
3435
}
3536
})), banner).getBannerSupplier());
36-
Logger.getLogger("io.quarkus.test").info("Quarkus continuous testing mode started");
37+
if (!config.getOptionalValue("quarkus.test.continuous-testing", Mode.class).orElse(Mode.PAUSED)
38+
.equals(Mode.DISABLED)) {
39+
Logger.getLogger("io.quarkus.test").info("Quarkus continuous testing mode started");
40+
}
3741
}
3842
}

core/deployment/src/main/java/io/quarkus/deployment/dev/testing/TestTracingProcessor.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,12 @@ TestListenerBuildItem sharedStateListener() {
7474
@Produce(ServiceStartBuildItem.class)
7575
void startTesting(TestConfig config, LiveReloadBuildItem liveReloadBuildItem,
7676
LaunchModeBuildItem launchModeBuildItem, List<TestListenerBuildItem> testListenerBuildItems) {
77-
if (TestSupport.instance().isEmpty() || config.continuousTesting() == TestConfig.Mode.DISABLED
78-
|| config.flatClassPath()) {
77+
if (TestSupport.instance().isEmpty()) {
78+
return;
79+
}
80+
TestSupport testSupport = TestSupport.instance().get();
81+
testSupport.setConfig(config);
82+
if ((config.continuousTesting() == TestConfig.Mode.DISABLED) || config.flatClassPath()) {
7983
return;
8084
}
8185
DevModeType devModeType = launchModeBuildItem.getDevModeType().orElse(null);
@@ -86,11 +90,9 @@ void startTesting(TestConfig config, LiveReloadBuildItem liveReloadBuildItem,
8690
return;
8791
}
8892
testingSetup = true;
89-
TestSupport testSupport = TestSupport.instance().get();
9093
for (TestListenerBuildItem i : testListenerBuildItems) {
9194
testSupport.addListener(i.listener);
9295
}
93-
testSupport.setConfig(config);
9496
testSupport.setTags(config.includeTags().orElse(Collections.emptyList()),
9597
config.excludeTags().orElse(Collections.emptyList()));
9698
testSupport.setPatterns(config.includePattern().orElse(null),

0 commit comments

Comments
 (0)