Skip to content

Commit 31151c5

Browse files
authored
Remove functionality moved to geoarrow-js (#83)
* Use functionality moved to geoarrow-js * fix import * remove duplicative validation functions * fmt
1 parent 6a8294c commit 31151c5

File tree

20 files changed

+181
-478
lines changed

20 files changed

+181
-478
lines changed

examples/linestring/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
},
1010
"dependencies": {
1111
"@geoarrow/deck.gl-layers": "../../",
12-
"apache-arrow": "^13.0.0",
12+
"apache-arrow": ">=14",
1313
"deck.gl": "^8.9.23",
1414
"react": "^18.0.0",
1515
"react-dom": "^18.0.0",

examples/multilinestring/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"build": "vite build"
99
},
1010
"dependencies": {
11-
"apache-arrow": "^13.0.0",
11+
"apache-arrow": ">=14",
1212
"deck.gl": "^8.9.23",
1313
"react": "^18.0.0",
1414
"react-dom": "^18.0.0",

examples/multipoint/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"build": "vite build"
99
},
1010
"dependencies": {
11-
"apache-arrow": "^13.0.0",
11+
"apache-arrow": ">=14",
1212
"deck.gl": "^8.9.23",
1313
"react": "^18.0.0",
1414
"react-dom": "^18.0.0",

examples/multipolygon/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
},
1010
"dependencies": {
1111
"@geoarrow/deck.gl-layers": "../../",
12-
"apache-arrow": "^13.0.0",
12+
"apache-arrow": ">=14",
1313
"deck.gl": "^8.9.23",
1414
"react": "^18.0.0",
1515
"react-dom": "^18.0.0",

examples/point/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"build": "vite build"
99
},
1010
"dependencies": {
11-
"apache-arrow": "^13.0.0",
11+
"apache-arrow": ">=14",
1212
"deck.gl": "^8.9.23",
1313
"react": "^18.0.0",
1414
"react-dom": "^18.0.0",

examples/polygon/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
},
1010
"dependencies": {
1111
"@geoarrow/deck.gl-layers": "../../",
12-
"apache-arrow": "^13.0.0",
12+
"apache-arrow": ">=14",
1313
"deck.gl": "^8.9.23",
1414
"react": "^18.0.0",
1515
"react-dom": "^18.0.0",

examples/text/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
},
1010
"dependencies": {
1111
"@geoarrow/deck.gl-layers": "../../",
12-
"apache-arrow": "^13.0.0",
12+
"apache-arrow": ">=14",
1313
"deck.gl": "^8.9.23",
1414
"react": "^18.0.0",
1515
"react-dom": "^18.0.0",

package-lock.json

Lines changed: 68 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
"@deck.gl/geo-layers": "^8.9.23",
4747
"@deck.gl/layers": "^8.9.23",
4848
"@math.gl/polygon": "^3.6.2",
49-
"apache-arrow": "^13.0.0"
49+
"apache-arrow": ">=14"
5050
},
5151
"devDependencies": {
5252
"@deck.gl/aggregation-layers": "^8.9.23",
@@ -56,7 +56,7 @@
5656
"@math.gl/polygon": "^3.6.2",
5757
"@rollup/plugin-terser": "^0.4.3",
5858
"@rollup/plugin-typescript": "^11.1.2",
59-
"apache-arrow": "^13.0.0",
59+
"apache-arrow": ">=14",
6060
"prettier": "^3.1.0",
6161
"rimraf": "^5.0.5",
6262
"rollup": "^3.26.2",
@@ -72,5 +72,8 @@
7272
"volta": {
7373
"node": "20.8.0",
7474
"npm": "10.2.0"
75+
},
76+
"dependencies": {
77+
"@geoarrow/geoarrow-js": "^0.1.0"
7578
}
7679
}

src/arc-layer.ts

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -5,23 +5,17 @@ import {
55
GetPickingInfoParams,
66
Layer,
77
LayersList,
8+
assert,
89
} from "@deck.gl/core/typed";
910
import { ArcLayer } from "@deck.gl/layers/typed";
1011
import type { ArcLayerProps } from "@deck.gl/layers/typed";
1112
import * as arrow from "apache-arrow";
12-
import {
13-
assignAccessor,
14-
extractAccessorsFromProps,
15-
getPointChild,
16-
} from "./utils.js";
13+
import * as ga from "@geoarrow/geoarrow-js";
14+
import { assignAccessor, extractAccessorsFromProps } from "./utils.js";
15+
import { child } from "@geoarrow/geoarrow-js";
1716
import { getPickingInfo } from "./picking.js";
18-
import {
19-
ColorAccessor,
20-
FloatAccessor,
21-
GeoArrowPickingInfo,
22-
PointVector,
23-
} from "./types.js";
24-
import { validateAccessors, validatePointType } from "./validate.js";
17+
import { ColorAccessor, FloatAccessor, GeoArrowPickingInfo } from "./types.js";
18+
import { validateAccessors } from "./validate.js";
2519

2620
/** All properties supported by GeoArrowArcLayer */
2721
export type GeoArrowArcLayerProps = Omit<
@@ -45,12 +39,12 @@ type _GeoArrowArcLayerProps = {
4539
/**
4640
* Method called to retrieve the source position of each object.
4741
*/
48-
getSourcePosition: PointVector;
42+
getSourcePosition: ga.vector.PointVector;
4943

5044
/**
5145
* Method called to retrieve the target position of each object.
5246
*/
53-
getTargetPosition: PointVector;
47+
getTargetPosition: ga.vector.PointVector;
5448

5549
/**
5650
* The rgba color is in the format of `[r, g, b, [a]]`.
@@ -133,8 +127,8 @@ export class GeoArrowArcLayer<
133127

134128
// Note: below we iterate over table batches anyways, so this layer won't
135129
// work as-is if data/table is null
136-
validatePointType(sourcePosition.type);
137-
validatePointType(targetPosition.type);
130+
assert(ga.vector.isPointVector(sourcePosition));
131+
assert(ga.vector.isPointVector(targetPosition));
138132
}
139133

140134
// Exclude manually-set accessors
@@ -150,9 +144,9 @@ export class GeoArrowArcLayer<
150144
recordBatchIdx++
151145
) {
152146
const sourceData = sourcePosition.data[recordBatchIdx];
153-
const sourceValues = getPointChild(sourceData).values;
147+
const sourceValues = child.getPointChild(sourceData).values;
154148
const targetData = targetPosition.data[recordBatchIdx];
155-
const targetValues = getPointChild(targetData).values;
149+
const targetValues = child.getPointChild(targetData).values;
156150

157151
const props: ArcLayerProps = {
158152
// Note: because this is a composite layer and not doing the rendering

0 commit comments

Comments
 (0)