chore(python): Rename FileReader to SyncReader (#1375)

Closes #1013

Author: kylebarron

python/Cargo.lock

@@ -1,6 +1,6 @@
 use crate::error::{PyGeoArrowError, PyGeoArrowResult};
 use crate::flatgeobuf::utils::apply_projection;
-use crate::input::{AsyncFileReader, construct_async_reader};
+use crate::input::{AsyncReader, construct_async_reader};
 
 use flatgeobuf::HttpFgbReader;
 use futures::TryStreamExt;
@@ -51,7 +51,7 @@ pub fn read_flatgeobuf_async<'py>(
 
 #[allow(clippy::too_many_arguments)]
 async fn read_flatgeobuf_async_inner(
-    async_reader: AsyncFileReader,
+    async_reader: AsyncReader,
     batch_size: usize,
     bbox: Option<(f64, f64, f64, f64)>,
     coord_type: CoordType,

python/geoarrow-io/src/flatgeobuf/async.rs

@@ -10,22 +10,22 @@ use object_store::{
 use pyo3::pybacked::PyBackedStr;
 #[cfg(feature = "async")]
 use pyo3_object_store::AnyObjectStore;
-use sync::FileReader;
+use sync::SyncReader;
 
 use pyo3::prelude::*;
 use url::Url;
 
 #[cfg(feature = "async")]
 #[derive(Debug, Clone)]
-pub struct AsyncFileReader {
+pub struct AsyncReader {
     pub store: Arc<dyn ObjectStore>,
     pub path: Path,
 }
 
 pub enum AnyFileReader {
-    Sync(FileReader),
+    Sync(SyncReader),
     #[cfg(feature = "async")]
-    Async(AsyncFileReader),
+    Async(AsyncReader),
 }
 
 /// Construct a reader for the user that will always be asynchronous
@@ -36,12 +36,12 @@ pub enum AnyFileReader {
 pub fn construct_async_reader(
     file: Bound<PyAny>,
     store: Option<Bound<PyAny>>,
-) -> PyGeoArrowResult<AsyncFileReader> {
+) -> PyGeoArrowResult<AsyncReader> {
     // If the user passed an object store instance, use that
 
     use pyo3_object_store::AnyObjectStore;
     if let Some(store) = store {
-        let async_reader = AsyncFileReader {
+        let async_reader = AsyncReader {
             store: store.extract::<AnyObjectStore>()?.into(),
             path: file.extract::<String>()?.into(),
         };
@@ -70,7 +70,7 @@ pub fn construct_reader(
     // If the user passed an object store instance, use that
     #[cfg(feature = "async")]
     if let Some(store) = store {
-        let async_reader = AsyncFileReader {
+        let async_reader = AsyncReader {
             store: store.extract::<AnyObjectStore>()?.into(),
             path: file.extract::<String>()?.into(),
         };
@@ -91,7 +91,7 @@ pub fn construct_reader(
 
 #[allow(dead_code)]
 #[cfg(feature = "async")]
-fn default_http_store(path_or_url: &str) -> PyGeoArrowResult<AsyncFileReader> {
+fn default_http_store(path_or_url: &str) -> PyGeoArrowResult<AsyncReader> {
     let url = Url::parse(path_or_url)?;
 
     let store_input = format!("{}://{}", url.scheme(), url.domain().unwrap());
@@ -103,16 +103,16 @@ fn default_http_store(path_or_url: &str) -> PyGeoArrowResult<AsyncFileReader> {
         .build()?;
     let path = url.path().trim_start_matches('/');
 
-    let async_reader = AsyncFileReader {
+    let async_reader = AsyncReader {
         store: Arc::new(store),
         path: path.into(),
     };
     Ok(async_reader)
 }
 
 #[cfg(feature = "async")]
-fn default_local_store(path: &str) -> PyGeoArrowResult<AsyncFileReader> {
-    let async_reader = AsyncFileReader {
+fn default_local_store(path: &str) -> PyGeoArrowResult<AsyncReader> {
+    let async_reader = AsyncReader {
         store: Arc::new(LocalFileSystem::new()),
         path: path.into(),
     };

python/geoarrow-io/src/input/mod.rs

@@ -15,12 +15,12 @@ use std::path::{Path, PathBuf};
 
 /// Implements Read + Seek
 #[derive(Debug)]
-pub enum FileReader {
+pub enum SyncReader {
     File(String, BufReader<File>),
     FileLike(BufReader<PyFileLikeObject>),
 }
 
-impl FileReader {
+impl SyncReader {
     pub(crate) fn try_clone(&self) -> std::io::Result<Self> {
         match self {
             Self::File(path, f) => Ok(Self::File(
@@ -32,7 +32,7 @@ impl FileReader {
     }
 }
 
-impl Read for FileReader {
+impl Read for SyncReader {
     fn read(&mut self, buf: &mut [u8]) -> io::Result<usize> {
         match self {
             Self::File(_, reader) => reader.read(buf),
@@ -41,7 +41,7 @@ impl Read for FileReader {
     }
 }
 
-impl Seek for FileReader {
+impl Seek for SyncReader {
     fn seek(&mut self, pos: SeekFrom) -> Result<u64, io::Error> {
         match self {
             Self::File(_, reader) => reader.seek(pos),
@@ -50,7 +50,7 @@ impl Seek for FileReader {
     }
 }
 
-impl BufRead for FileReader {
+impl BufRead for SyncReader {
     fn fill_buf(&mut self) -> io::Result<&[u8]> {
         match self {
             Self::File(_, reader) => reader.fill_buf(),
@@ -66,7 +66,7 @@ impl BufRead for FileReader {
     }
 }
 
-impl Length for FileReader {
+impl Length for SyncReader {
     fn len(&self) -> u64 {
         match self {
             Self::File(_path, f) => f.get_ref().len(),
@@ -87,8 +87,8 @@ impl Length for FileReader {
     }
 }
 
-impl ChunkReader for FileReader {
-    type T = FileReader;
+impl ChunkReader for SyncReader {
+    type T = SyncReader;
 
     fn get_read(&self, start: u64) -> parquet::errors::Result<Self::T> {
         let mut reader = self.try_clone()?;
@@ -111,7 +111,7 @@ impl ChunkReader for FileReader {
     }
 }
 
-impl<'py> FromPyObject<'py> for FileReader {
+impl<'py> FromPyObject<'py> for SyncReader {
     fn extract_bound(ob: &Bound<'py, PyAny>) -> PyResult<Self> {
         if let Ok(path_buf) = ob.extract::<PathBuf>() {
             let path = path_buf.to_string_lossy().to_string();

python/geoarrow-io/src/input/sync.rs

@@ -1,7 +1,7 @@
 use std::sync::Arc;
 
 use crate::error::{PyGeoArrowError, PyGeoArrowResult};
-use crate::input::{AnyFileReader, AsyncFileReader, construct_reader};
+use crate::input::{AnyFileReader, AsyncReader, construct_reader};
 use crate::parquet::options::{
     PyGeoParquetBboxQuery, PyGeoParquetReadOptions, PyRect, apply_options,
 };
@@ -60,7 +60,7 @@ pub fn read_parquet_async(
 }
 
 async fn read_parquet_async_inner(
-    async_reader: AsyncFileReader,
+    async_reader: AsyncReader,
     batch_size: Option<usize>,
     parse_to_native: bool,
     coord_type: Option<PyCoordType>,

python/geoarrow-io/src/parquet/async.rs

@@ -1,3 +1,7 @@
+# Changelog
+
+## 0.6.0 - 2025-10-15
+
 * feat(geoarrow-csv): Initial CSV reader, wrapping upstream arrow-csv by @kylebarron in https://github.com/geoarrow/geoarrow-rs/pull/1050
 * feat(geoarrow-csv): add CSV writer by @kylebarron in https://github.com/geoarrow/geoarrow-rs/pull/1314
 * docs: Geoarrow-csv docs by @nuts-rice in https://github.com/geoarrow/geoarrow-rs/pull/1340

rust/geoarrow-csv/CHANGELOG.md

@@ -4,6 +4,8 @@
 
 ## Unreleased
 
+## 0.6.0 - 2025-10-15
+
 - Make `infer_geoarrow_schema` public. #1251
 
 ## 0.5.0 - 2025-08-07