Skip to content

Commit 798d16d

Browse files
authored
Move to upstream geo-traits (#841)
1 parent ee90acf commit 798d16d

File tree

151 files changed

+630
-2272
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

151 files changed

+630
-2272
lines changed

Cargo.lock

Lines changed: 23 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ futures = { version = "0.3", optional = true }
6464
gdal = { version = "0.17", optional = true }
6565
geo = "0.28"
6666
geo-index = "0.1.1"
67+
geo-traits = "0.1.1"
6768
geos = { version = "9.0", features = ["v3_10_0", "geo"], optional = true }
6869
geozero = { version = "0.14", features = ["with-wkb"] }
6970
half = { version = "2.4.1" }
@@ -95,7 +96,8 @@ sqlx = { version = "0.7", optional = true, default-features = false, features =
9596
] }
9697
thiserror = "1"
9798
tokio = { version = "1", default-features = false, optional = true }
98-
wkt = "0.11"
99+
# wkt = "0.11"
100+
wkt = { git = "https://github.com/georust/wkt", branch = "kyle/geo-traits-writer" }
99101

100102

101103
[dev-dependencies]

js/Cargo.lock

Lines changed: 25 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

js/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ bytes = { version = "1", optional = true }
8989
console_error_panic_hook = { version = "0.1.6", optional = true }
9090
futures = { version = "0.3.30", optional = true }
9191
geo = "0.28"
92+
geo-traits = "0.1.1"
9293
geoarrow = { path = "../" }
9394
geodesy = { version = "0.12", optional = true, features = ["js"] }
9495
object_store = { version = "0.11", optional = true }

js/src/io/parquet/async.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use crate::error::{GeoArrowWasmError, WasmResult};
33
use crate::io::parquet::options::JsParquetReaderOptions;
44
use arrow_wasm::{RecordBatch, Table};
55
use futures::stream::StreamExt;
6-
use geoarrow::geo_traits::CoordTrait;
6+
use geo_traits::CoordTrait;
77
use geoarrow::io::parquet::metadata::GeoParquetBboxCovering;
88
use geoarrow::io::parquet::{
99
GeoParquetDatasetMetadata, GeoParquetReaderMetadata, GeoParquetReaderOptions,

python/Cargo.lock

Lines changed: 26 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

python/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ arrow = "53"
1818
arrow-array = "53"
1919
arrow-buffer = "53"
2020
arrow-schema = "53"
21+
geo-traits = "0.1.1"
2122
geoarrow = { path = "../" }
2223
# Uncomment when publishing
2324
# geoarrow = { version = "0.4.0-beta.1" }

python/geoarrow-io/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ pyo3-asyncio-0-21 = { version = "0.21", features = [
5050
], optional = true }
5151
pythonize = "0.21"
5252
geo = "0.28"
53+
geo-traits = { workspace = true }
5354
geoarrow = { path = "../../", features = [
5455
"csv",
5556
"flatgeobuf",

python/geoarrow-io/src/io/parquet/async.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ use crate::io::object_store::PyObjectStore;
88
use crate::io::parquet::options::create_options;
99
use crate::util::table_to_pytable;
1010

11+
use geo_traits::CoordTrait;
1112
use geoarrow::error::GeoArrowError;
12-
use geoarrow::geo_traits::CoordTrait;
1313
use geoarrow::io::parquet::metadata::GeoParquetBboxCovering;
1414
use geoarrow::io::parquet::{
1515
GeoParquetDatasetMetadata, GeoParquetReaderMetadata, GeoParquetReaderOptions,

src/algorithm/geo/contains.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,6 @@ use crate::algorithm::native::{Binary, Unary};
22
use crate::array::*;
33
use crate::datatypes::{Dimension, NativeType};
44
use crate::error::GeoArrowError;
5-
use crate::geo_traits::{
6-
GeometryCollectionTrait, GeometryTrait, LineStringTrait, MultiLineStringTrait, MultiPointTrait,
7-
MultiPolygonTrait, PointTrait, PolygonTrait,
8-
};
95
use crate::io::geo::{
106
geometry_collection_to_geo, geometry_to_geo, line_string_to_geo, multi_line_string_to_geo,
117
multi_point_to_geo, multi_polygon_to_geo, point_to_geo, polygon_to_geo,
@@ -15,6 +11,10 @@ use crate::NativeArray;
1511
use arrow_array::builder::BooleanBuilder;
1612
use arrow_array::BooleanArray;
1713
use geo::Contains as _Contains;
14+
use geo_traits::{
15+
GeometryCollectionTrait, GeometryTrait, LineStringTrait, MultiLineStringTrait, MultiPointTrait,
16+
MultiPolygonTrait, PointTrait, PolygonTrait,
17+
};
1818

1919
/// Checks if `rhs` is completely contained within `self`.
2020
/// More formally, the interior of `rhs` has non-empty

0 commit comments

Comments
 (0)