Exposes Here provider to the bundle (#222)

* Exposes Here provider to the bundle

* Add support to Here CIT (Customer Integration Testing) environment

* app_id and app_code must not be null

* app_id and app_code are required

* Add dev requirement regarding geocoder-php/here-provider

* Add relevant functional test config regarding geocoder-php/here-provider

Author: DamienHarper

ProviderFactory/HereFactory.php

@@ -0,0 +1,44 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the BazingaGeocoderBundle package.
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ *
+ * @license    MIT License
+ */
+
+namespace Bazinga\GeocoderBundle\ProviderFactory;
+
+use Geocoder\Provider\Here\Here;
+use Geocoder\Provider\Provider;
+use Http\Discovery\HttpClientDiscovery;
+use Symfony\Component\OptionsResolver\OptionsResolver;
+
+final class HereFactory extends AbstractFactory
+{
+    protected static $dependencies = [
+        ['requiredClass' => Here::class, 'packageName' => 'geocoder-php/here-provider'],
+    ];
+
+    protected function getProvider(array $config): Provider
+    {
+        $httplug = $config['httplug_client'] ?: HttpClientDiscovery::find();
+
+        return new Here($httplug, $config['app_id'], $config['app_code'], $config['use_cit']);
+    }
+
+    protected static function configureOptionResolver(OptionsResolver $resolver)
+    {
+        $resolver->setDefaults([
+            'httplug_client' => null,
+            'use_cit' => false,
+        ]);
+
+        $resolver->setAllowedTypes('httplug_client', ['object', 'null']);
+        $resolver->setAllowedTypes('use_cit', ['bool', 'false']);
+        $resolver->setRequired(['app_id', 'app_code']);
+    }
+}

Resources/doc/services.md

@@ -20,6 +20,7 @@ Here is a list of all provider factories and their options.
 | `Bazinga\GeocoderBundle\ProviderFactory\GeonamesFactory` | httplug_client, username
 | `Bazinga\GeocoderBundle\ProviderFactory\GeoPluginFactory` | httplug_client
 | `Bazinga\GeocoderBundle\ProviderFactory\GoogleMapsFactory` | httplug_client, api_key, region
+| `Bazinga\GeocoderBundle\ProviderFactory\HereFactory` | httplug_client, app_id, app_code, use_cit
 | `Bazinga\GeocoderBundle\ProviderFactory\HostIpFactory` | httplug_client
 | `Bazinga\GeocoderBundle\ProviderFactory\IpInfoFactory` | httplug_client
 | `Bazinga\GeocoderBundle\ProviderFactory\IpInfoDbFactory` | httplug_client, api_key, precision

Tests/Functional/ProviderFactoryTest.php

@@ -23,6 +23,7 @@
 use Geocoder\Provider\Geonames\Geonames;
 use Geocoder\Provider\GeoPlugin\GeoPlugin;
 use Geocoder\Provider\GoogleMaps\GoogleMaps;
+use Geocoder\Provider\Here\Here;
 use Geocoder\Provider\HostIp\HostIp;
 use Geocoder\Provider\IpInfo\IpInfo;
 use Geocoder\Provider\IpInfoDb\IpInfoDb;
@@ -66,6 +67,7 @@ public function getProviders()
             [Geonames::class, ['acme']],
             [GeoPlugin::class, ['empty']],
             [GoogleMaps::class, ['empty']],
+            [Here::class, ['acme']],
             [HostIp::class, ['empty']],
             [IpInfo::class, ['acme']],
             [IpInfoDb::class, ['empty', 'acme']],

Tests/Functional/config/provider/here.yml

@@ -0,0 +1,9 @@
+bazinga_geocoder:
+  profiling:
+    enabled: false
+  providers:
+    acme:
+      factory: Bazinga\GeocoderBundle\ProviderFactory\HereFactory
+      options:
+        app_id: 'foo'
+        app_code: 'bar'

composer.json

@@ -39,6 +39,7 @@
     "geocoder-php/geonames-provider": "^4.0",
     "geocoder-php/geoips-provider": "^4.0",
     "geocoder-php/geoip2-provider": "^4.0",
+    "geocoder-php/here-provider": "^0.2",
     "geocoder-php/ip-info-provider": "^0.1",
     "geocoder-php/ip-info-db-provider": "^4.0",
     "geocoder-php/ipstack-provider": "^0.1",