Merge pull request #383 from norkunas/deprecate

Deprecate using options array to configure Address validation constraint

Author: norkunas

composer.json

@@ -19,6 +19,7 @@
     "php-http/curl-client": "^2.3",
     "php-http/discovery": "^1.14",
     "symfony/console": "^5.4 || ^6.4 || ^7.0",
+    "symfony/deprecation-contracts": "2.5",
     "symfony/framework-bundle": "^5.4 || ^6.4 || ^7.0",
     "symfony/http-kernel": "^5.4 || ^6.4 || ^7.0",
     "symfony/options-resolver": "^5.4 || ^6.4 || ^7.0",

src/Validator/Constraint/Address.php

@@ -51,6 +51,10 @@ class Address extends Constraint
      */
     public function __construct(?array $options = null, ?string $message = null, ?array $groups = null, $payload = null)
     {
+        if (\is_array($options)) {
+            trigger_deprecation('willdurand/geocoder-bundle', '5.24', 'Passing an array of options to configure the "%s" constraint is deprecated, use named arguments instead.', static::class);
+        }
+
         parent::__construct($options, $groups, $payload);
 
         $this->message = $message ?? $this->message;

tests/baseline-ignore

@@ -90,3 +90,7 @@
 %Not enabling native lazy objects is deprecated and will be impossible in Doctrine ORM 4.0%
 %Not setting "doctrine.orm.enable_native_lazy_objects" to true is deprecated%
 %Disabling native lazy objects is deprecated and will be impossible in Doctrine ORM 4.0%
+%Passing an array of options to configure the "Bazinga\\GeocoderBundle\\Validator\\Constraint\\Address" constraint is deprecated, use named arguments instead%
+%The "Symfony\\Bundle\\FrameworkBundle\\Console\\Application::add\(\)" method is deprecated and will be removed in Symfony 8.0, use "Symfony\\Bundle\\FrameworkBundle\\Console\\Application::addCommand\(\)" instead%
+%XML configuration format is deprecated, use YAML or PHP instead%
+%Support for evaluating options in the base Constraint class is deprecated. Initialize properties in the constructor of Bazinga\\GeocoderBundle\\Validator\\Constraint\\Address instead%