Merge pull request #79 from giosh94mhz/master

CacheProvider: better hashing function and namespace

Author: willdurand

Provider/CacheProvider.php

@@ -65,7 +65,7 @@ public function __construct(Cache $cache, ProviderInterface $provider, $lifetime
      */
     public function getGeocodedData($address)
     {
-        $key = crc32($this->locale.$address);
+        $key = 'geocoder_' . sha1($this->locale . $address);
 
         if (false !== $data = $this->cache->fetch($key)) {
             return unserialize($data);
@@ -82,7 +82,7 @@ public function getGeocodedData($address)
      */
     public function getReversedData(array $coordinates)
     {
-        $key = crc32(serialize($this->locale . json_encode($coordinates)));
+        $key = 'geocoder_' . sha1($this->locale . json_encode($coordinates));
 
         if (false !== $data = $this->cache->fetch($key)) {
             return unserialize($data);

Tests/Provider/CacheProviderTest.php

@@ -14,6 +14,7 @@ public function testGetGeocodedData()
     {
         $address = 'Paris, France';
         $coordinates = array('lat' => 48.857049,'lng' => 2.35223);
+        $cacheKey = 'geocoder_' . sha1($address);
 
         $delegate = $this->getMock('Geocoder\\Provider\\ProviderInterface');
         $delegate->expects($this->once())
@@ -24,12 +25,12 @@ public function testGetGeocodedData()
         $cache = $this->getMock('Doctrine\\Common\\Cache\\Cache');
         $cache->expects($this->once())
             ->method('fetch')
-            ->with(crc32($address))
+            ->with($cacheKey)
             ->will($this->returnValue(false));
 
         $cache->expects($this->once())
             ->method('save')
-            ->with(crc32($address), serialize($coordinates), 0);
+            ->with($cacheKey, serialize($coordinates), 0);
 
         $provider = new CacheProvider($cache, $delegate);
         $this->assertEquals($coordinates, $provider->getGeocodedData($address));
@@ -39,6 +40,7 @@ public function testGetCachedGeocodedData()
     {
         $address = 'Paris, France';
         $coordinates = array('lat' => 48.857049,'lng' => 2.35223);
+        $cacheKey = 'geocoder_' . sha1($address);
 
         $delegate = $this->getMock('Geocoder\\Provider\\ProviderInterface');
         $delegate->expects($this->once())
@@ -51,7 +53,7 @@ public function testGetCachedGeocodedData()
         $provider->getGeocodedData($address);
         $provider->getGeocodedData($address);
 
-        $this->assertTrue($cache->contains(crc32($address)));
+        $this->assertTrue($cache->contains($cacheKey));
     }
 
     public function testGetReversedData()