Throw exception if use_faker is enabled without faker library

Add unit test for FakeIpPlugin

Author: qdequippe

DependencyInjection/BazingaGeocoderExtension.php

@@ -18,6 +18,7 @@
 use Bazinga\GeocoderBundle\Plugin\ProfilingPlugin;
 use Bazinga\GeocoderBundle\ProviderFactory\PluginProviderFactory;
 use Bazinga\GeocoderBundle\ProviderFactory\ProviderFactoryInterface;
+use Faker\Generator;
 use Geocoder\Plugin\Plugin\CachePlugin;
 use Geocoder\Plugin\Plugin\LimitPlugin;
 use Geocoder\Plugin\Plugin\LocalePlugin;
@@ -55,6 +56,10 @@ public function load(array $configs, ContainerBuilder $container)
             $definition = $container->getDefinition(FakeIpPlugin::class);
             $definition->replaceArgument(1, $config['fake_ip']['ip']);
             $definition->replaceArgument(2, $config['fake_ip']['use_faker']);
+
+            if ($config['fake_ip']['use_faker'] && !class_exists(Generator::class)) {
+                throw new \LogicException('To enable this option, you must install fzaninotto/faker package.');
+            }
         } else {
             $container->removeDefinition(FakeIpPlugin::class);
         }

Plugin/FakeIpPlugin.php

@@ -12,7 +12,8 @@
 
 namespace Bazinga\GeocoderBundle\Plugin;
 
-use Faker\Factory;
+use Faker\Generator;
+use Faker\Provider\Internet;
 use Geocoder\Plugin\Plugin;
 use Geocoder\Query\GeocodeQuery;
 use Geocoder\Query\Query;
@@ -39,11 +40,21 @@ class FakeIpPlugin implements Plugin
      */
     private $useFaker;
 
+    /**
+     * @var Generator|null
+     */
+    private $faker;
+
     public function __construct(string $needle, string $replacement = null, bool $useFaker = false)
     {
         $this->needle = $needle;
         $this->replacement = $replacement;
         $this->useFaker = $useFaker;
+
+        if ($useFaker) {
+            $this->faker = new Generator();
+            $this->faker->addProvider(new Internet($this->faker));
+        }
     }
 
     /**
@@ -57,9 +68,8 @@ public function handleQuery(Query $query, callable $next, callable $first)
 
         $replacement = $this->replacement;
 
-        if ($this->useFaker) {
-            $faker = Factory::create();
-            $replacement = $faker->ipv4;
+        if (null !== $this->faker) {
+            $replacement = $this->faker->ipv4;
         }
 
         $text = str_replace($this->needle, $replacement, $query->getText(), $count);

Tests/Plugin/FakeIpPluginTest.php

@@ -0,0 +1,43 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the BazingaGeocoderBundle package.
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ *
+ * @license    MIT License
+ */
+
+namespace Bazinga\GeocoderBundle\Tests\Plugin;
+
+use Bazinga\GeocoderBundle\Plugin\FakeIpPlugin;
+use Geocoder\Query\GeocodeQuery;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @author Quentin Dequippe <[email protected]
+ */
+class FakeIpPluginTest extends TestCase
+{
+    public function testSimpleHandleQuery()
+    {
+        $fakeIpPlugin = new FakeIpPlugin('127.0.0.1', '123.123.123.123');
+        $query = GeocodeQuery::create('127.0.0.1');
+
+        $fakeIpPlugin->handleQuery($query, function () {}, function () {});
+
+        $this->assertSame($query->getText(), '123.123.123.123');
+    }
+
+    public function testHandleQueryUsingFaker()
+    {
+        $fakeIpPlugin = new FakeIpPlugin('127.0.0.1', '192.168.1.1', true);
+        $query = GeocodeQuery::create('127.0.0.1');
+
+        $fakeIpPlugin->handleQuery($query, function () {}, function () {});
+
+        $this->assertNotSame($query->getText(), '192.168.1.1');
+    }
+}