Skip to content

Commit 0499e88

Browse files
committed
Merge pull request #259 from Richtermeister/master
Revert GoogleBusinessProvider "client_id" parameter back to just "client"
2 parents 23484d2 + 08d9e8d commit 0499e88

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/Geocoder/Provider/GoogleMapsBusinessProvider.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public function getName()
6161
protected function buildQuery($query)
6262
{
6363
$query = parent::buildQuery($query);
64-
$query = sprintf('%s&client_id=%s', $query, $this->clientId);
64+
$query = sprintf('%s&client=%s', $query, $this->clientId);
6565

6666
if (null !== $this->privateKey) {
6767
$query = $this->signQuery($query);

tests/Geocoder/Tests/Provider/GoogleMapsBusinessProviderTest.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ public function testBuildQueryWithNoPrivateKey()
2828

2929
$query = 'http://maps.googleapis.com/maps/api/geocode/json?address=blah&sensor=false';
3030

31-
$this->assertEquals($query.'&client_id=foo', $method->invoke($provider, $query));
31+
32+
$this->assertEquals($query.'&client=foo', $method->invoke($provider, $query));
3233
}
3334

3435
public function testBuildQueryWithPrivateKey()
@@ -47,7 +48,7 @@ public function testBuildQueryWithPrivateKey()
4748

4849
$query = 'http://maps.googleapis.com/maps/api/geocode/json?address=blah&sensor=false';
4950

50-
$this->assertEquals($query.'&client_id=foo&signature=jIGtKeuAW-UjGrj9Mfcclww0rmc=', $method->invoke($provider, $query));
51+
$this->assertEquals($query.'&client=foo&signature=JY4upbd7fi76C-bMGYk410gmB5g=', $method->invoke($provider, $query));
5152
}
5253

5354
public function testSignQuery()

0 commit comments

Comments
 (0)