[Pelias] Fix NULL value for $bounds (#1046)

* Update Pelias.php

Fix #1043

* Update GeocodeEarthTest.php

Add test for address with no bounds.

* Update GeocodeEarthTest.php

Fix testGeocodeNoBounds.

* Add cached response for testGeocodeNoBounds

Author: jbelien

src/Provider/GeocodeEarth/Tests/.cached_responses/api.geocode.earth_bcf5bd9fe5f5350148dbed04ef8fc7d93b192179

@@ -0,0 +1 @@
+s:5675:"{"geocoding":{"version":"0.2","attribution":"https://geocode.earth/guidelines","query":{"text":"dworzec centralny","size":5,"layers":["venue","street","country","macroregion","region","county","localadmin","locality","borough","neighbourhood","continent","empire","dependency","macrocounty","macrohood","microhood","disputed","postalcode","ocean","marinearea"],"private":false,"lang":{"name":"English","iso6391":"en","iso6393":"eng","defaulted":true},"querySize":20,"parser":"pelias","parsed_text":{"subject":"dworzec centralny"}},"warnings":["performance optimization: excluding 'address' layer"],"engine":{"name":"Pelias","author":"Mapzen","version":"1.0"},"timestamp":1587573572737},"type":"FeatureCollection","features":[{"type":"Feature","geometry":{"type":"Point","coordinates":[21.002758,52.229253]},"properties":{"id":"node/341341208","gid":"openstreetmap:venue:node/341341208","layer":"venue","source":"openstreetmap","source_id":"node/341341208","name":"Dworzec Centralny 23","confidence":1,"match_type":"exact","accuracy":"point","country":"Poland","country_gid":"whosonfirst:country:85633723","country_a":"POL","region":"Mazowieckie","region_gid":"whosonfirst:region:85687257","region_a":"MZ","county":"Warszawa","county_gid":"whosonfirst:county:1477743805","localadmin":"Warsaw","localadmin_gid":"whosonfirst:localadmin:1125365875","locality":"Warsaw","locality_gid":"whosonfirst:locality:101752777","borough":"Śródmieście","borough_gid":"whosonfirst:borough:1477921687","neighbourhood":"Śródmieście","neighbourhood_gid":"whosonfirst:neighbourhood:85898119","continent":"Europe","continent_gid":"whosonfirst:continent:102191581","label":"Dworzec Centralny 23, Warsaw, Poland"}},{"type":"Feature","geometry":{"type":"Point","coordinates":[21.005287,52.229541]},"properties":{"id":"node/334557966","gid":"openstreetmap:venue:node/334557966","layer":"venue","source":"openstreetmap","source_id":"node/334557966","name":"Dworzec Centralny 16","confidence":1,"match_type":"exact","accuracy":"point","country":"Poland","country_gid":"whosonfirst:country:85633723","country_a":"POL","region":"Mazowieckie","region_gid":"whosonfirst:region:85687257","region_a":"MZ","county":"Warszawa","county_gid":"whosonfirst:county:1477743805","localadmin":"Warsaw","localadmin_gid":"whosonfirst:localadmin:1125365875","locality":"Warsaw","locality_gid":"whosonfirst:locality:101752777","borough":"Śródmieście","borough_gid":"whosonfirst:borough:1477921687","neighbourhood":"Śródmieście","neighbourhood_gid":"whosonfirst:neighbourhood:85898119","continent":"Europe","continent_gid":"whosonfirst:continent:102191581","label":"Dworzec Centralny 16, Warsaw, Poland"}},{"type":"Feature","geometry":{"type":"Point","coordinates":[21.004452,52.230099]},"properties":{"id":"node/334559445","gid":"openstreetmap:venue:node/334559445","layer":"venue","source":"openstreetmap","source_id":"node/334559445","name":"Dworzec Centralny 11","confidence":1,"match_type":"exact","accuracy":"point","country":"Poland","country_gid":"whosonfirst:country:85633723","country_a":"POL","region":"Mazowieckie","region_gid":"whosonfirst:region:85687257","region_a":"MZ","county":"Warszawa","county_gid":"whosonfirst:county:1477743805","localadmin":"Warsaw","localadmin_gid":"whosonfirst:localadmin:1125365875","locality":"Warsaw","locality_gid":"whosonfirst:locality:101752777","borough":"Śródmieście","borough_gid":"whosonfirst:borough:1477921687","neighbourhood":"Śródmieście","neighbourhood_gid":"whosonfirst:neighbourhood:85898119","continent":"Europe","continent_gid":"whosonfirst:continent:102191581","label":"Dworzec Centralny 11, Warsaw, Poland"}},{"type":"Feature","geometry":{"type":"Point","coordinates":[21.003501,52.227901]},"properties":{"id":"node/334558526","gid":"openstreetmap:venue:node/334558526","layer":"venue","source":"openstreetmap","source_id":"node/334558526","name":"Dworzec Centralny 01","confidence":1,"match_type":"exact","accuracy":"point","country":"Poland","country_gid":"whosonfirst:country:85633723","country_a":"POL","region":"Mazowieckie","region_gid":"whosonfirst:region:85687257","region_a":"MZ","county":"Warszawa","county_gid":"whosonfirst:county:1477743805","localadmin":"Warsaw","localadmin_gid":"whosonfirst:localadmin:1125365875","locality":"Warsaw","locality_gid":"whosonfirst:locality:101752777","borough":"Śródmieście","borough_gid":"whosonfirst:borough:1477921687","neighbourhood":"Śródmieście","neighbourhood_gid":"whosonfirst:neighbourhood:85898119","continent":"Europe","continent_gid":"whosonfirst:continent:102191581","label":"Dworzec Centralny 01, Warsaw, Poland"}},{"type":"Feature","geometry":{"type":"Point","coordinates":[21.000745,52.22887]},"properties":{"id":"way/285280427","gid":"openstreetmap:venue:way/285280427","layer":"venue","source":"openstreetmap","source_id":"way/285280427","name":"Dworzec Centralny 03","confidence":1,"match_type":"exact","accuracy":"point","country":"Poland","country_gid":"whosonfirst:country:85633723","country_a":"POL","region":"Mazowieckie","region_gid":"whosonfirst:region:85687257","region_a":"MZ","county":"Warszawa","county_gid":"whosonfirst:county:1477743805","localadmin":"Warsaw","localadmin_gid":"whosonfirst:localadmin:1125365875","locality":"Warsaw","locality_gid":"whosonfirst:locality:101752777","borough":"Wola","borough_gid":"whosonfirst:borough:1477921679","neighbourhood":"Śródmieście","neighbourhood_gid":"whosonfirst:neighbourhood:85898119","continent":"Europe","continent_gid":"whosonfirst:continent:102191581","label":"Dworzec Centralny 03, Warsaw, Poland"},"bbox":[21.0006503,52.2287427,21.0008859,52.2290291]}],"bbox":[21.0006503,52.227901,21.005287,52.230099]}";

src/Provider/GeocodeEarth/Tests/GeocodeEarthTest.php

@@ -193,6 +193,29 @@ public function testGeocodeWithCityDistrict()
         $this->assertEquals('DEU', $result->getCountry()->getCode());
     }
 
+    public function testGeocodeNoBounds()
+    {
+        if (!isset($_SERVER['GEOCODE_EARTH_API_KEY'])) {
+            $this->markTestSkipped('You need to configure the GEOCODE_EARTH_API_KEY value in phpunit.xml');
+        }
+
+        $provider = new GeocodeEarth($this->getHttpClient($_SERVER['GEOCODE_EARTH_API_KEY']), $_SERVER['GEOCODE_EARTH_API_KEY']);
+        $results = $provider->geocodeQuery(GeocodeQuery::create('dworzec centralny'));
+
+        $this->assertInstanceOf('Geocoder\Model\AddressCollection', $results);
+        $this->assertCount(5, $results);
+
+        /** @var \Geocoder\Model\Address $result */
+        $result = $results->first();
+        $this->assertInstanceOf('\Geocoder\Model\Address', $result);
+        $this->assertEquals(52.230428, $result->getCoordinates()->getLatitude(), '', 0.01);
+        $this->assertEquals(21.004552, $result->getCoordinates()->getLongitude(), '', 0.01);
+        $this->assertEquals('Warsaw', $result->getLocality());
+        $this->assertEquals('Poland', $result->getCountry()->getName());
+        $this->assertEquals('POL', $result->getCountry()->getCode());
+        $this->assertNull($result->getBounds());
+    }
+
     /**
      * @expectedException \Geocoder\Exception\QuotaExceeded
      * @expectedExceptionMessage Valid request but quota exceeded.

src/Provider/Pelias/Pelias.php

@@ -166,7 +166,12 @@ protected function executeQuery(string $url): AddressCollection
                     'east' => $location['bbox'][0],
                 ];
             } else {
-                $bounds = null;
+                $bounds = [
+                    'south' => null,
+                    'west' => null,
+                    'north' => null,
+                    'east' => null,
+                ];
             }
 
             $props = $location['properties'];