Fixed some code smell (#709)

Nyholm · web-flow · commit 534e99eecd7b · 2017-06-17T21:39:39.000+02:00
* Fixed type issues

* Fixed code smell
diff --git a/Geonames.php b/Geonames.php
@@ -139,8 +139,8 @@ private function executeQuery(string $url, string $locale = null): AddressCollec
             for ($level = 1; $level <= AdminLevelCollection::MAX_LEVEL_DEPTH; ++$level) {
                 $adminNameProp = 'adminName'.$level;
                 $adminCodeProp = 'adminCode'.$level;
-                if (!empty($item->$adminNameProp) || !empty($item->$adminCodeProp)) {
-                    $builder->addAdminLevel($level, $item->$adminNameProp ?? null, $item->$adminCodeProp ?? null);
+                if (!empty($item->$adminNameProp)) {
+                    $builder->addAdminLevel($level, $item->$adminNameProp, $item->$adminCodeProp ?? null);
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -139,8 +139,8 @@ private function executeQuery(string $url, string $locale = null): AddressCollec`
`139`	`139`	`for ($level = 1; $level <= AdminLevelCollection::MAX_LEVEL_DEPTH; ++$level) {`
`140`	`140`	`$adminNameProp = 'adminName'.$level;`
`141`	`141`	`$adminCodeProp = 'adminCode'.$level;`
`142`		`- if (!empty($item->$adminNameProp) \|\| !empty($item->$adminCodeProp)) {`
`143`		`- $builder->addAdminLevel($level, $item->$adminNameProp ?? null, $item->$adminCodeProp ?? null);`
	`142`	`+ if (!empty($item->$adminNameProp)) {`
	`143`	`+ $builder->addAdminLevel($level, $item->$adminNameProp, $item->$adminCodeProp ?? null);`
`144`	`144`	`}`
`145`	`145`	`}`
`146`	`146`