Skip to content

Commit 60b5b52

Browse files
fbuchlakjbelien
fbuchlak
and
jbelien
authored
style: convert string class names to constants (#1252)
* style: convert string class names to constants * style: fix php-cs-fixer --------- Co-authored-by: Jonathan Beliën <[email protected]>
1 parent 980c05e commit 60b5b52

File tree

2 files changed

+20
-20
lines changed

2 files changed

+20
-20
lines changed

‎Tests/CountryInfoTest.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ public function testCountryInfoWithOneCountry(): void
3838
/* @var CountryInfo $result */
3939
$result = current($results);
4040

41-
$this->assertInstanceOf('Geocoder\Provider\Geonames\Model\CountryInfo', $result);
42-
$this->assertInstanceOf('Geocoder\Model\Bounds', $result->getBounds());
41+
$this->assertInstanceOf(CountryInfo::class, $result);
42+
$this->assertInstanceOf(\Geocoder\Model\Bounds::class, $result->getBounds());
4343
$this->assertEquals('AS', $result->getContinent());
4444
$this->assertEquals('New Delhi', $result->getCapital());
4545
$this->assertIsArray($result->getLanguages());

‎Tests/GeonamesTest.php‎

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,11 @@ public function testGeocodeWithRealPlace(): void
7575
$provider = new Geonames($this->getHttpClient($_SERVER['GEONAMES_USERNAME']), $_SERVER['GEONAMES_USERNAME']);
7676
$results = $provider->geocodeQuery(GeocodeQuery::create('Harrods, London'));
7777

78-
$this->assertInstanceOf('Geocoder\Model\AddressCollection', $results);
78+
$this->assertInstanceOf(\Geocoder\Model\AddressCollection::class, $results);
7979

8080
/** @var GeonamesAddress $result */
8181
$result = $results->first();
82-
$this->assertInstanceOf('\Geocoder\Model\Address', $result);
82+
$this->assertInstanceOf(\Geocoder\Model\Address::class, $result);
8383
$this->assertEqualsWithDelta(51.49957, $result->getCoordinates()->getLatitude(), 0.01);
8484
$this->assertEqualsWithDelta(-0.16359, $result->getCoordinates()->getLongitude(), 0.01);
8585
$this->assertEquals('United Kingdom', $result->getCountry()->getName());
@@ -104,12 +104,12 @@ public function testGeocodeWithMultipleRealPlaces(): void
104104
$provider = new Geonames($this->getHttpClient($_SERVER['GEONAMES_USERNAME']), $_SERVER['GEONAMES_USERNAME']);
105105
$results = $provider->geocodeQuery(GeocodeQuery::create('London'));
106106

107-
$this->assertInstanceOf('Geocoder\Model\AddressCollection', $results);
107+
$this->assertInstanceOf(\Geocoder\Model\AddressCollection::class, $results);
108108
$this->assertCount(5, $results);
109109

110110
/** @var Location $result */
111111
$result = $results->first();
112-
$this->assertInstanceOf('\Geocoder\Model\Address', $result);
112+
$this->assertInstanceOf(\Geocoder\Model\Address::class, $result);
113113
$this->assertEqualsWithDelta(51.508528775863, $result->getCoordinates()->getLatitude(), 0.01);
114114
$this->assertEqualsWithDelta(-0.12574195861816, $result->getCoordinates()->getLongitude(), 0.01);
115115
$this->assertNotNull($result->getBounds());
@@ -127,7 +127,7 @@ public function testGeocodeWithMultipleRealPlaces(): void
127127

128128
/** @var Location $result */
129129
$result = $results->get(1);
130-
$this->assertInstanceOf('\Geocoder\Model\Address', $result);
130+
$this->assertInstanceOf(\Geocoder\Model\Address::class, $result);
131131
$this->assertEqualsWithDelta(-33.015285093464, $result->getCoordinates()->getLatitude(), 0.01);
132132
$this->assertEqualsWithDelta(27.911624908447, $result->getCoordinates()->getLongitude(), 0.01);
133133
$this->assertNotNull($result->getBounds());
@@ -146,7 +146,7 @@ public function testGeocodeWithMultipleRealPlaces(): void
146146

147147
/** @var Location $result */
148148
$result = $results->get(2);
149-
$this->assertInstanceOf('\Geocoder\Model\Address', $result);
149+
$this->assertInstanceOf(\Geocoder\Model\Address::class, $result);
150150
$this->assertEqualsWithDelta(51.512788890295, $result->getCoordinates()->getLatitude(), 0.01);
151151
$this->assertEqualsWithDelta(-0.091838836669922, $result->getCoordinates()->getLongitude(), 0.01);
152152
$this->assertNotNull($result->getBounds());
@@ -165,7 +165,7 @@ public function testGeocodeWithMultipleRealPlaces(): void
165165

166166
/** @var Location $result */
167167
$result = $results->get(3);
168-
$this->assertInstanceOf('\Geocoder\Model\Address', $result);
168+
$this->assertInstanceOf(\Geocoder\Model\Address::class, $result);
169169
$this->assertEqualsWithDelta(42.983389283, $result->getCoordinates()->getLatitude(), 0.01);
170170
$this->assertEqualsWithDelta(-81.233042387, $result->getCoordinates()->getLongitude(), 0.01);
171171
$this->assertNotNull($result->getBounds());
@@ -182,7 +182,7 @@ public function testGeocodeWithMultipleRealPlaces(): void
182182

183183
/** @var Location $result */
184184
$result = $results->get(4);
185-
$this->assertInstanceOf('\Geocoder\Model\Address', $result);
185+
$this->assertInstanceOf(\Geocoder\Model\Address::class, $result);
186186
$this->assertEqualsWithDelta(41.3556539, $result->getCoordinates()->getLatitude(), 0.01);
187187
$this->assertEqualsWithDelta(-72.0995209, $result->getCoordinates()->getLongitude(), 0.01);
188188
$this->assertNotNull($result->getBounds());
@@ -208,12 +208,12 @@ public function testGeocodeWithMultipleRealPlacesWithLocale(): void
208208
$provider = new Geonames($this->getHttpClient($_SERVER['GEONAMES_USERNAME']), $_SERVER['GEONAMES_USERNAME']);
209209
$results = $provider->geocodeQuery(GeocodeQuery::create('London')->withLocale('it_IT'));
210210

211-
$this->assertInstanceOf('Geocoder\Model\AddressCollection', $results);
211+
$this->assertInstanceOf(\Geocoder\Model\AddressCollection::class, $results);
212212
$this->assertCount(5, $results);
213213

214214
/** @var Location $result */
215215
$result = $results->first();
216-
$this->assertInstanceOf('\Geocoder\Model\Address', $result);
216+
$this->assertInstanceOf(\Geocoder\Model\Address::class, $result);
217217
$this->assertEqualsWithDelta(51.50853, $result->getCoordinates()->getLatitude(), 0.01);
218218
$this->assertEqualsWithDelta(-0.12574, $result->getCoordinates()->getLongitude(), 0.01);
219219
$this->assertNotNull($result->getBounds());
@@ -231,7 +231,7 @@ public function testGeocodeWithMultipleRealPlacesWithLocale(): void
231231

232232
/** @var Location $result */
233233
$result = $results->get(1);
234-
$this->assertInstanceOf('\Geocoder\Model\Address', $result);
234+
$this->assertInstanceOf(\Geocoder\Model\Address::class, $result);
235235
$this->assertEqualsWithDelta(-33.015285093464, $result->getCoordinates()->getLatitude(), 0.01);
236236
$this->assertEqualsWithDelta(27.911624908447, $result->getCoordinates()->getLongitude(), 0.01);
237237
$this->assertNotNull($result->getBounds());
@@ -250,7 +250,7 @@ public function testGeocodeWithMultipleRealPlacesWithLocale(): void
250250

251251
/** @var Location $result */
252252
$result = $results->get(2);
253-
$this->assertInstanceOf('\Geocoder\Model\Address', $result);
253+
$this->assertInstanceOf(\Geocoder\Model\Address::class, $result);
254254
$this->assertEqualsWithDelta(51.512788890295, $result->getCoordinates()->getLatitude(), 0.01);
255255
$this->assertEqualsWithDelta(-0.091838836669922, $result->getCoordinates()->getLongitude(), 0.01);
256256
$this->assertNotNull($result->getBounds());
@@ -269,7 +269,7 @@ public function testGeocodeWithMultipleRealPlacesWithLocale(): void
269269

270270
/** @var Location $result */
271271
$result = $results->get(3);
272-
$this->assertInstanceOf('\Geocoder\Model\Address', $result);
272+
$this->assertInstanceOf(\Geocoder\Model\Address::class, $result);
273273
$this->assertEqualsWithDelta(42.983389283, $result->getCoordinates()->getLatitude(), 0.01);
274274
$this->assertEqualsWithDelta(-81.233042387, $result->getCoordinates()->getLongitude(), 0.01);
275275
$this->assertNotNull($result->getBounds());
@@ -286,7 +286,7 @@ public function testGeocodeWithMultipleRealPlacesWithLocale(): void
286286

287287
/** @var Location $result */
288288
$result = $results->get(4);
289-
$this->assertInstanceOf('\Geocoder\Model\Address', $result);
289+
$this->assertInstanceOf(\Geocoder\Model\Address::class, $result);
290290
$this->assertEqualsWithDelta(41.3556539, $result->getCoordinates()->getLatitude(), 0.01);
291291
$this->assertEqualsWithDelta(-72.0995209, $result->getCoordinates()->getLongitude(), 0.01);
292292
$this->assertNotNull($result->getBounds());
@@ -312,12 +312,12 @@ public function testReverseWithRealCoordinates(): void
312312
$provider = new Geonames($this->getHttpClient($_SERVER['GEONAMES_USERNAME']), $_SERVER['GEONAMES_USERNAME']);
313313
$results = $provider->reverseQuery(ReverseQuery::fromCoordinates(51.50853, -0.12574));
314314

315-
$this->assertInstanceOf('Geocoder\Model\AddressCollection', $results);
315+
$this->assertInstanceOf(\Geocoder\Model\AddressCollection::class, $results);
316316
$this->assertCount(1, $results);
317317

318318
/** @var Location $result */
319319
$result = $results->first();
320-
$this->assertInstanceOf('\Geocoder\Model\Address', $result);
320+
$this->assertInstanceOf(\Geocoder\Model\Address::class, $result);
321321
$this->assertEqualsWithDelta(51.50853, $result->getCoordinates()->getLatitude(), 0.01);
322322
$this->assertEqualsWithDelta(-0.12574, $result->getCoordinates()->getLongitude(), 0.01);
323323
$this->assertEquals('London', $result->getLocality());
@@ -338,12 +338,12 @@ public function testReverseWithRealCoordinatesWithLocale(): void
338338
$provider = new Geonames($this->getHttpClient($_SERVER['GEONAMES_USERNAME']), $_SERVER['GEONAMES_USERNAME']);
339339
$results = $provider->reverseQuery(ReverseQuery::fromCoordinates(51.50853, -0.12574)->withLocale('it_IT'));
340340

341-
$this->assertInstanceOf('Geocoder\Model\AddressCollection', $results);
341+
$this->assertInstanceOf(\Geocoder\Model\AddressCollection::class, $results);
342342
$this->assertCount(1, $results);
343343

344344
/** @var Location $result */
345345
$result = $results->first();
346-
$this->assertInstanceOf('\Geocoder\Model\Address', $result);
346+
$this->assertInstanceOf(\Geocoder\Model\Address::class, $result);
347347
$this->assertEqualsWithDelta(51.50853, $result->getCoordinates()->getLatitude(), 0.01);
348348
$this->assertEqualsWithDelta(-0.12574, $result->getCoordinates()->getLongitude(), 0.01);
349349
$this->assertEquals('Londra', $result->getLocality());

0 commit comments

Comments
 (0)