Add PHPStan in CI (#1193)

* Add PHPStan

* Update php.yml

* Update composer.json

* Fix PHPStan level 0

* Fix PHPStan level 1

* Update phpstan.neon

* Fix PHPStan level 2

* Update composer.json

* Fix PHPStan level 3

* Fix tests

* Fix PHPStan level 4

* Update src/Common/Tests/TimedGeocoderTest.php

Co-authored-by: Tomas Norkūnas <[email protected]>

* Update src/Provider/Cache/Tests/ProviderCacheTest.php

Co-authored-by: Tomas Norkūnas <[email protected]>

* Update src/Provider/Cache/Tests/ProviderCacheTest.php

Co-authored-by: Tomas Norkūnas <[email protected]>

* Update src/Provider/GeoIP2/Tests/GeoIP2Test.php

Co-authored-by: Tomas Norkūnas <[email protected]>

* Fix PHPStan level 5

* Normalize composer.json

* Rename analyse script

* Update composer.json

* Update IntegrationTest

* Update AlgoliaPlacesTest

* Update composer.json

* Update RequestInterface vs. getParsedResponse()

* Update src/Plugin/PluginProvider.php

Co-authored-by: Tomas Norkūnas <[email protected]>

* Update src/Plugin/PluginProvider.php

Co-authored-by: Tomas Norkūnas <[email protected]>

* Use PHPStan baseline instead of ignore

See https://phpstan.org/user-guide/baseline

---------

Co-authored-by: Tomas Norkūnas <[email protected]>

Author: jbelien

Tests/IP2LocationBinaryTest.php

@@ -68,8 +68,8 @@ public function testLocationResultContainsExpectedFieldsForAnAmericanIp()
         $result = $results->first();
         $this->assertInstanceOf('\Geocoder\Model\Address', $result);
 
-        $this->assertEquals('37.405990600586', $result->getCoordinates()->getLatitude(), '', 0.001);
-        $this->assertEquals('-122.07851409912', $result->getCoordinates()->getLongitude(), '', 0.001);
+        $this->assertEqualsWithDelta(37.405990600586, $result->getCoordinates()->getLatitude(), 0.001);
+        $this->assertEqualsWithDelta(-122.07851409912, $result->getCoordinates()->getLongitude(), 0.001);
         $this->assertNull($result->getBounds());
         $this->assertNull($result->getStreetNumber());
         $this->assertNull($result->getStreetName());
@@ -96,8 +96,8 @@ public function testLocationResultContainsExpectedFieldsForAChinaIp()
         $result = $results->first();
         $this->assertInstanceOf('\Geocoder\Model\Address', $result);
 
-        $this->assertEquals('39.907501220703', $result->getCoordinates()->getLatitude(), '', 0.001);
-        $this->assertEquals('116.39723205566', $result->getCoordinates()->getLongitude(), '', 0.001);
+        $this->assertEqualsWithDelta(39.907501220703, $result->getCoordinates()->getLatitude(), 0.001);
+        $this->assertEqualsWithDelta(116.39723205566, $result->getCoordinates()->getLongitude(), 0.001);
         $this->assertNull($result->getBounds());
         $this->assertNull($result->getStreetNumber());
         $this->assertNull($result->getStreetName());
@@ -124,8 +124,8 @@ public function testGeocodeWithRealIPv6()
         $result = $results->first();
         $this->assertInstanceOf('\Geocoder\Model\Address', $result);
 
-        $this->assertEquals('37.386051', $result->getCoordinates()->getLatitude(), '', 0.001);
-        $this->assertEquals('-122.083847', $result->getCoordinates()->getLongitude(), '', 0.001);
+        $this->assertEqualsWithDelta(37.386051, $result->getCoordinates()->getLatitude(), 0.001);
+        $this->assertEqualsWithDelta(-122.083847, $result->getCoordinates()->getLongitude(), 0.001);
         $this->assertNull($result->getBounds());
         $this->assertNull($result->getStreetNumber());
         $this->assertNull($result->getStreetName());

Tests/IntegrationTest.php

@@ -21,16 +21,15 @@
  */
 class IntegrationTest extends ProviderIntegrationTest
 {
-    protected $skippedTests = [
-    ];
+    protected array $skippedTests = [];
 
-    protected $testAddress = false;
+    protected bool $testAddress = false;
 
-    protected $testReverse = false;
+    protected bool $testReverse = false;
 
-    protected $testIpv6 = false;
+    protected bool $testIpv6 = false;
 
-    protected $testHttpProvider = false;
+    protected bool $testHttpProvider = false;
 
     public static function setUpBeforeClass(): void
     {
@@ -47,13 +46,13 @@ protected function createProvider(ClientInterface $httpClient)
         return new IP2LocationBinary(__DIR__.'/fixtures/IP2LOCATION-LITE-DB9.IPV6.BIN', \IP2Location\Database::FILE_IO);
     }
 
-    protected function getCacheDir()
+    protected function getCacheDir(): string
     {
         return __DIR__.'/.cached_responses';
     }
 
-    protected function getApiKey()
+    protected function getApiKey(): string
     {
-        return null;
+        return '';
     }
 }