Add PHPStan in CI (#1193)

jbelien · norkunas · web-flow · commit 3525f298dcad · 2023-07-16T16:36:39.000+02:00
* Add PHPStan * Update php.yml * Update composer.json * Fix PHPStan level 0 * Fix PHPStan level 1 * Update phpstan.neon * Fix PHPStan level 2 * Update composer.json * Fix PHPStan level 3 * Fix tests * Fix PHPStan level 4 * Update src/Common/Tests/TimedGeocoderTest.php Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com> * Update src/Provider/Cache/Tests/ProviderCacheTest.php Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com> * Update src/Provider/Cache/Tests/ProviderCacheTest.php Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com> * Update src/Provider/GeoIP2/Tests/GeoIP2Test.php Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com> * Fix PHPStan level 5 * Normalize composer.json * Rename analyse script * Update composer.json * Update IntegrationTest * Update AlgoliaPlacesTest * Update composer.json * Update RequestInterface vs. getParsedResponse() * Update src/Plugin/PluginProvider.php Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com> * Update src/Plugin/PluginProvider.php Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com> * Use PHPStan baseline instead of ignore See https://phpstan.org/user-guide/baseline --------- Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>
diff --git a/IP2Location.php b/IP2Location.php
@@ -97,8 +97,6 @@ public function getName(): string
 
     /**
      * @param string $url
-     *
-     * @return Collection
      */
     private function executeQuery(string $url): AddressCollection
     {
diff --git a/Tests/IntegrationTest.php b/Tests/IntegrationTest.php
@@ -19,21 +19,21 @@
  */
 class IntegrationTest extends ProviderIntegrationTest
 {
-    protected $testAddress = false;
+    protected bool $testAddress = false;
 
-    protected $testReverse = false;
+    protected bool $testReverse = false;
 
     protected function createProvider(ClientInterface $httpClient)
     {
         return new IP2Location($httpClient, $this->getApiKey());
     }
 
-    protected function getCacheDir()
+    protected function getCacheDir(): string
     {
         return __DIR__.'/.cached_responses';
     }
 
-    protected function getApiKey()
+    protected function getApiKey(): string
     {
         if (!isset($_SERVER['IP2Location_API_KEY'])) {
             $this->markTestSkipped('No IP2Location API key');

Original file line number	Diff line number	Diff line change
`@@ -97,8 +97,6 @@ public function getName(): string`
`97`	`97`
`98`	`98`	`/**`
`99`	`99`	`* @param string $url`
`100`		`- *`
`101`		`- * @return Collection`
`102`	`100`	`*/`
`103`	`101`	`private function executeQuery(string $url): AddressCollection`
`104`	`102`	`{`
Original file line number	Diff line number	Diff line change
`@@ -19,21 +19,21 @@`
`19`	`19`	`*/`
`20`	`20`	`class IntegrationTest extends ProviderIntegrationTest`
`21`	`21`	`{`
`22`		`- protected $testAddress = false;`
	`22`	`+ protected bool $testAddress = false;`
`23`	`23`
`24`		`- protected $testReverse = false;`
	`24`	`+ protected bool $testReverse = false;`
`25`	`25`
`26`	`26`	`protected function createProvider(ClientInterface $httpClient)`
`27`	`27`	`{`
`28`	`28`	`return new IP2Location($httpClient, $this->getApiKey());`
`29`	`29`	`}`
`30`	`30`
`31`		`- protected function getCacheDir()`
	`31`	`+ protected function getCacheDir(): string`
`32`	`32`	`{`
`33`	`33`	`return __DIR__.'/.cached_responses';`
`34`	`34`	`}`
`35`	`35`
`36`		`- protected function getApiKey()`
	`36`	`+ protected function getApiKey(): string`
`37`	`37`	`{`
`38`	`38`	`if (!isset($_SERVER['IP2Location_API_KEY'])) {`
`39`	`39`	`$this->markTestSkipped('No IP2Location API key');`