Add PHP Coding Standards Fixer in CI (#1196)

* Update composer.json

* Update .gitignore

* Update php.yml

* Apply PHPCSFixer fixes

* Switch to php-cs-fixer/shim

* Create .php-cs-fixer.dist.php

Author: jbelien

MapQuest.php

@@ -25,9 +25,9 @@
 use Geocoder\Model\AdminLevel;
 use Geocoder\Model\Bounds;
 use Geocoder\Model\Country;
+use Geocoder\Provider\Provider;
 use Geocoder\Query\GeocodeQuery;
 use Geocoder\Query\ReverseQuery;
-use Geocoder\Provider\Provider;
 use Psr\Http\Client\ClientInterface;
 use Psr\Http\Message\ResponseInterface;
 
@@ -36,50 +36,50 @@
  */
 final class MapQuest extends AbstractHttpProvider implements Provider
 {
-    const DATA_KEY_ADDRESS = 'address';
+    public const DATA_KEY_ADDRESS = 'address';
 
-    const KEY_API_KEY = 'key';
+    public const KEY_API_KEY = 'key';
 
-    const KEY_LOCATION = 'location';
+    public const KEY_LOCATION = 'location';
 
-    const KEY_OUT_FORMAT = 'outFormat';
+    public const KEY_OUT_FORMAT = 'outFormat';
 
-    const KEY_MAX_RESULTS = 'maxResults';
+    public const KEY_MAX_RESULTS = 'maxResults';
 
-    const KEY_THUMB_MAPS = 'thumbMaps';
+    public const KEY_THUMB_MAPS = 'thumbMaps';
 
-    const KEY_INTL_MODE = 'intlMode';
+    public const KEY_INTL_MODE = 'intlMode';
 
-    const KEY_BOUNDING_BOX = 'boundingBox';
+    public const KEY_BOUNDING_BOX = 'boundingBox';
 
-    const KEY_LAT = 'lat';
+    public const KEY_LAT = 'lat';
 
-    const KEY_LNG = 'lng';
+    public const KEY_LNG = 'lng';
 
-    const MODE_5BOX = '5BOX';
+    public const MODE_5BOX = '5BOX';
 
-    const OPEN_BASE_URL = 'https://open.mapquestapi.com/geocoding/v1/';
+    public const OPEN_BASE_URL = 'https://open.mapquestapi.com/geocoding/v1/';
 
-    const LICENSED_BASE_URL = 'https://www.mapquestapi.com/geocoding/v1/';
+    public const LICENSED_BASE_URL = 'https://www.mapquestapi.com/geocoding/v1/';
 
-    const GEOCODE_ENDPOINT = 'address';
+    public const GEOCODE_ENDPOINT = 'address';
 
-    const DEFAULT_GEOCODE_PARAMS = [
+    public const DEFAULT_GEOCODE_PARAMS = [
         self::KEY_LOCATION => '',
         self::KEY_OUT_FORMAT => 'json',
         self::KEY_API_KEY => '',
     ];
 
-    const DEFAULT_GEOCODE_OPTIONS = [
+    public const DEFAULT_GEOCODE_OPTIONS = [
         self::KEY_MAX_RESULTS => 3,
         self::KEY_THUMB_MAPS => false,
     ];
 
-    const REVERSE_ENDPOINT = 'reverse';
+    public const REVERSE_ENDPOINT = 'reverse';
 
-    const ADMIN_LEVEL_STATE = 1;
+    public const ADMIN_LEVEL_STATE = 1;
 
-    const ADMIN_LEVEL_COUNTY = 2;
+    public const ADMIN_LEVEL_COUNTY = 2;
 
     /**
      * MapQuest offers two geocoding endpoints one commercial (true) and one open (false)
@@ -117,9 +117,6 @@ public function __construct(ClientInterface $client, string $apiKey, bool $licen
         parent::__construct($client);
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function geocodeQuery(GeocodeQuery $query): Collection
     {
         $params = static::DEFAULT_GEOCODE_PARAMS;
@@ -167,9 +164,6 @@ public function geocodeQuery(GeocodeQuery $query): Collection
         }
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function reverseQuery(ReverseQuery $query): Collection
     {
         $coordinates = $query->getCoordinates();
@@ -185,9 +179,6 @@ public function reverseQuery(ReverseQuery $query): Collection
         return $this->executeGetQuery(static::REVERSE_ENDPOINT, $params);
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getName(): string
     {
         return 'map_quest';
@@ -252,12 +243,6 @@ private function executePostQuery(string $endpoint, array $params)
         return $this->parseResponseContent($content);
     }
 
-    /**
-     * @param string $endpoint
-     * @param array  $params
-     *
-     * @return AddressCollection
-     */
     private function executeGetQuery(string $endpoint, array $params): AddressCollection
     {
         $baseUrl = $this->getUrl($endpoint);

Tests/MapQuestTest.php

@@ -18,9 +18,9 @@
 use Geocoder\Model\AddressBuilder;
 use Geocoder\Model\AdminLevel;
 use Geocoder\Model\Bounds;
+use Geocoder\Provider\MapQuest\MapQuest;
 use Geocoder\Query\GeocodeQuery;
 use Geocoder\Query\ReverseQuery;
-use Geocoder\Provider\MapQuest\MapQuest;
 
 /**
  * @author William Durand <[email protected]>