Add PHP Coding Standards Fixer in CI (#1196)

* Update composer.json

* Update .gitignore

* Update php.yml

* Apply PHPCSFixer fixes

* Switch to php-cs-fixer/shim

* Create .php-cs-fixer.dist.php

Author: jbelien

Model/PhotonAddress.php

@@ -62,11 +62,6 @@ public function getName()
         return $this->name;
     }
 
-    /**
-     * @param string|null $name
-     *
-     * @return PhotonAddress
-     */
     public function withName(string $name = null): self
     {
         $new = clone $this;
@@ -83,11 +78,6 @@ public function getOSMId()
         return $this->osmId;
     }
 
-    /**
-     * @param int|null $osmId
-     *
-     * @return PhotonAddress
-     */
     public function withOSMId(int $osmId = null): self
     {
         $new = clone $this;
@@ -104,11 +94,6 @@ public function getOSMType()
         return $this->osmType;
     }
 
-    /**
-     * @param string|null $osmType
-     *
-     * @return PhotonAddress
-     */
     public function withOSMType(string $osmType = null): self
     {
         $new = clone $this;
@@ -125,12 +110,6 @@ public function getOSMTag()
         return $this->osmTag;
     }
 
-    /**
-     * @param string|null $key
-     * @param string|null $value
-     *
-     * @return PhotonAddress
-     */
     public function withOSMTag(string $key = null, string $value = null): self
     {
         $new = clone $this;
@@ -155,10 +134,6 @@ public function getState()
         return $this->state;
     }
 
-    /**
-     * @param string|null $state
-     * @return PhotonAddress
-     */
     public function withState(string $state = null): self
     {
         $new = clone $this;
@@ -175,10 +150,6 @@ public function getCounty()
         return $this->county;
     }
 
-    /**
-     * @param string|null $county
-     * @return PhotonAddress
-     */
     public function withCounty(string $county = null): self
     {
         $new = clone $this;
@@ -195,10 +166,6 @@ public function getDistrict()
         return $this->district;
     }
 
-    /**
-     * @param string|null $district
-     * @return PhotonAddress
-     */
     public function withDistrict(string $district = null): self
     {
         $new = clone $this;

Photon.php

@@ -15,14 +15,14 @@
 use Geocoder\Collection;
 use Geocoder\Exception\InvalidServerResponse;
 use Geocoder\Exception\UnsupportedOperation;
+use Geocoder\Http\Provider\AbstractHttpProvider;
 use Geocoder\Location;
 use Geocoder\Model\AddressBuilder;
 use Geocoder\Model\AddressCollection;
+use Geocoder\Provider\Photon\Model\PhotonAddress;
+use Geocoder\Provider\Provider;
 use Geocoder\Query\GeocodeQuery;
 use Geocoder\Query\ReverseQuery;
-use Geocoder\Http\Provider\AbstractHttpProvider;
-use Geocoder\Provider\Provider;
-use Geocoder\Provider\Photon\Model\PhotonAddress;
 use Psr\Http\Client\ClientInterface;
 
 /**
@@ -38,8 +38,6 @@ final class Photon extends AbstractHttpProvider implements Provider
 
     /**
      * @param ClientInterface $client an HTTP client
-     *
-     * @return Photon
      */
     public static function withKomootServer(ClientInterface $client): self
     {
@@ -57,9 +55,6 @@ public function __construct(ClientInterface $client, $rootUrl)
         $this->rootUrl = rtrim($rootUrl, '/');
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function geocodeQuery(GeocodeQuery $query): Collection
     {
         $address = $query->getText();
@@ -91,9 +86,6 @@ public function geocodeQuery(GeocodeQuery $query): Collection
         return new AddressCollection($results);
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function reverseQuery(ReverseQuery $query): Collection
     {
         $coordinates = $query->getCoordinates();
@@ -123,11 +115,6 @@ public function reverseQuery(ReverseQuery $query): Collection
         return new AddressCollection($results);
     }
 
-    /**
-     * @param \stdClass $feature
-     *
-     * @return Location
-     */
     private function featureToAddress(\stdClass $feature): Location
     {
         $builder = new AddressBuilder($this->getName());
@@ -166,19 +153,11 @@ private function featureToAddress(\stdClass $feature): Location
         return $address;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getName(): string
     {
         return 'photon';
     }
 
-    /**
-     * @param string $url
-     *
-     * @return \stdClass
-     */
     private function executeQuery(string $url): \stdClass
     {
         $content = $this->getUrlContents($url);

Tests/PhotonTest.php

@@ -13,9 +13,9 @@
 namespace Geocoder\Provider\Photon\Tests;
 
 use Geocoder\IntegrationTest\BaseTestCase;
+use Geocoder\Provider\Photon\Photon;
 use Geocoder\Query\GeocodeQuery;
 use Geocoder\Query\ReverseQuery;
-use Geocoder\Provider\Photon\Photon;
 
 class PhotonTest extends BaseTestCase
 {