Add PHPStan in CI (#1193)

jbelien · norkunas · web-flow · commit 71679041ddb2 · 2023-07-16T16:36:39.000+02:00
* Add PHPStan * Update php.yml * Update composer.json * Fix PHPStan level 0 * Fix PHPStan level 1 * Update phpstan.neon * Fix PHPStan level 2 * Update composer.json * Fix PHPStan level 3 * Fix tests * Fix PHPStan level 4 * Update src/Common/Tests/TimedGeocoderTest.php Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com> * Update src/Provider/Cache/Tests/ProviderCacheTest.php Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com> * Update src/Provider/Cache/Tests/ProviderCacheTest.php Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com> * Update src/Provider/GeoIP2/Tests/GeoIP2Test.php Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com> * Fix PHPStan level 5 * Normalize composer.json * Rename analyse script * Update composer.json * Update IntegrationTest * Update AlgoliaPlacesTest * Update composer.json * Update RequestInterface vs. getParsedResponse() * Update src/Plugin/PluginProvider.php Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com> * Update src/Plugin/PluginProvider.php Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com> * Use PHPStan baseline instead of ignore See https://phpstan.org/user-guide/baseline --------- Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>
diff --git a/Tests/IntegrationTest.php b/Tests/IntegrationTest.php
@@ -21,25 +21,25 @@
  */
 class IntegrationTest extends ProviderIntegrationTest
 {
-    protected $skippedTests = [
+    protected array $skippedTests = [
         'testReverseQueryWithNoResults' => 'Null island exists. ',
     ];
 
-    protected $testIpv4 = false;
+    protected bool $testIpv4 = false;
 
-    protected $testIpv6 = false;
+    protected bool $testIpv6 = false;
 
     protected function createProvider(ClientInterface $httpClient)
     {
         return new TomTom($httpClient, $this->getApiKey());
     }
 
-    protected function getCacheDir()
+    protected function getCacheDir(): string
     {
         return __DIR__.'/.cached_responses';
     }
 
-    protected function getApiKey()
+    protected function getApiKey(): string
     {
         return $_SERVER['TOMTOM_MAP_KEY'];
     }

Original file line number	Diff line number	Diff line change
`@@ -21,25 +21,25 @@`
`21`	`21`	`*/`
`22`	`22`	`class IntegrationTest extends ProviderIntegrationTest`
`23`	`23`	`{`
`24`		`- protected $skippedTests = [`
	`24`	`+ protected array $skippedTests = [`
`25`	`25`	`'testReverseQueryWithNoResults' => 'Null island exists. ',`
`26`	`26`	`];`
`27`	`27`
`28`		`- protected $testIpv4 = false;`
	`28`	`+ protected bool $testIpv4 = false;`
`29`	`29`
`30`		`- protected $testIpv6 = false;`
	`30`	`+ protected bool $testIpv6 = false;`
`31`	`31`
`32`	`32`	`protected function createProvider(ClientInterface $httpClient)`
`33`	`33`	`{`
`34`	`34`	`return new TomTom($httpClient, $this->getApiKey());`
`35`	`35`	`}`
`36`	`36`
`37`		`- protected function getCacheDir()`
	`37`	`+ protected function getCacheDir(): string`
`38`	`38`	`{`
`39`	`39`	`return __DIR__.'/.cached_responses';`
`40`	`40`	`}`
`41`	`41`
`42`		`- protected function getApiKey()`
	`42`	`+ protected function getApiKey(): string`
`43`	`43`	`{`
`44`	`44`	`return $_SERVER['TOMTOM_MAP_KEY'];`
`45`	`45`	`}`