Skip to content

Commit 4d6064f

Browse files
Bundle PDB option (#25)
1 parent 98758d9 commit 4d6064f

File tree

3 files changed

+17
-1
lines changed

3 files changed

+17
-1
lines changed

.github/workflows/test.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,8 @@ jobs:
4343
cli: nightly
4444
sdk: nightly
4545
build-config: RelWithDebInfo
46+
export-pdb: true
47+
bundle-pdb: true
4648
path: textureldr
4749
combine: true
4850
target: ${{ matrix.config.target }}

README.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,11 @@ https://github.com/geode-sdk/build-geode-mod/tree/main/examples
3333
# Default: false
3434
export-pdb: ''
3535

36+
# Whether to bundle PDB files into the .geode package. Not required.
37+
# Requires SDK v4.2.0 and CLI v3.3.0 at minimum.
38+
# Default: false
39+
bundle-pdb: ''
40+
3641
# Path to the project which to build. Defaults to current directory.
3742
path: ''
3843

@@ -80,9 +85,11 @@ https://github.com/geode-sdk/build-geode-mod/tree/main/examples
8085
id: build
8186
with:
8287
build-config: RelWithDebInfo
88+
# Export the pdb alongside the .geode file
89+
export-pdb: true
8390
# Bundle the pdb inside the .geode file
8491
# Be warned, they can be quite big
85-
export-pdb: true
92+
bundle-pdb: true
8693
```
8794
8895
# Combine

action.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,10 @@ inputs:
6262
description: Whether to use LTO (Link Time Optimization) via the CMAKE_INTERPROCEDURAL_OPTIMIZATION flag, improving build size. Defaults to true
6363
required: false
6464
default: true
65+
bundle-pdb:
66+
description: Whether to bundle PDB files into the .geode package. Requires SDK v4.2.0 and CLI v3.3.0 at minimum. Defaults to false
67+
required: false
68+
default: false
6569

6670
outputs:
6771
build-output:
@@ -251,6 +255,9 @@ runs:
251255
if [ "${{ inputs.use-lto }}" = "true" ]; then
252256
CMAKE_EXTRA_ARGS="$CMAKE_EXTRA_ARGS -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=ON"
253257
fi
258+
if [ "${{ inputs.bundle-pdb }}" = "true" ] && [ ${{ steps.platform.outputs.id }} = "win" ]; then
259+
CMAKE_EXTRA_ARGS="$CMAKE_EXTRA_ARGS -DGEODE_BUNDLE_PDB=ON"
260+
fi
254261
cmake -B build -DCMAKE_BUILD_TYPE=${{ inputs.build-config }} -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DGEODE_CODEGEN_CMAKE_ARGS="-DCMAKE_C_COMPILER=clang;-DCMAKE_CXX_COMPILER=clang++;-G Ninja" -G Ninja $CMAKE_EXTRA_ARGS -DGEODE_DONT_INSTALL_MODS=ON -DGEODE_TARGET_PLATFORM=${{ steps.platform.outputs.target }} ${{ inputs.configure-args }}
255262
cmake --build build --config ${{ inputs.build-config }} ${{ inputs.build-args }}
256263

0 commit comments

Comments
 (0)