block storing data for the invalid mods

Author: qimiko

loader/src/loader/ModImpl.cpp

@@ -53,14 +53,19 @@ Mod::Impl::~Impl() = default;
 
 Result<> Mod::Impl::setup() {
     m_saveDirPath = dirs::getModsSaveDir() / m_metadata.getID();
+    m_settings = std::make_unique<ModSettingsManager>(m_metadata);
+
+    if (this->isEphemeral()) {
+        return Ok();
+    }
+
     (void) utils::file::createDirectoryAll(m_saveDirPath);
 
     // always create temp dir for all mods, even if disabled, so resources can be loaded
     GEODE_UNWRAP(this->createTempDir().mapErr([](auto const& err) {
         return fmt::format("Unable to create temp dir: {}", err);
     }));
 
-    m_settings = std::make_unique<ModSettingsManager>(m_metadata);
     auto loadRes = this->loadData();
     if (!loadRes) {
         log::warn("Unable to load data for \"{}\": {}", m_metadata.getID(), loadRes.unwrapErr());
@@ -103,6 +108,10 @@ std::string Mod::Impl::getName() const {
     return m_metadata.getName();
 }
 
+bool Mod::Impl::isEphemeral() const {
+    return ModMetadataImpl::getImpl(m_metadata).m_softInvalidReason.has_value();
+}
+
 std::vector<std::string> Mod::Impl::getDevelopers() const {
     return m_metadata.getDevelopers();
 }
@@ -219,6 +228,10 @@ Result<> Mod::Impl::saveData() {
         return Ok();
     }
 
+    if (this->isEphemeral()) {
+        return Ok();
+    }
+
     // ModSettingsManager keeps track of the whole savedata
     matjson::Value json = m_settings->save();
 

loader/src/loader/ModImpl.hpp

@@ -97,6 +97,12 @@ namespace geode {
         std::filesystem::path getTempDir() const;
         std::filesystem::path getBinaryPath() const;
 
+        /**
+         * If a mod should be considered ephemeral, in which case it will not attempt to save/load its data.
+         * Currently used for the invalid mod objects.
+         */
+        bool isEphemeral() const;
+
         matjson::Value& getSaveContainer();
 
 #if defined(GEODE_EXPOSE_SECRET_INTERNALS_IN_HEADERS_DO_NOT_DEFINE_PLEASE)

loader/src/loader/ModMetadataImpl.cpp

@@ -46,7 +46,11 @@ ModMetadataLinks& ModMetadataLinks::operator=(ModMetadataLinks&& other) noexcept
 }
 ModMetadataLinks::~ModMetadataLinks() = default;
 
-ModMetadata::Impl& ModMetadataImpl::getImpl(ModMetadata& info)  {
+ModMetadata::Impl& ModMetadataImpl::getImpl(ModMetadata& info) {
+    return *info.m_impl;
+}
+
+ModMetadata::Impl const& ModMetadataImpl::getImpl(ModMetadata const& info) {
     return *info.m_impl;
 }
 

loader/src/loader/ModMetadataImpl.hpp

@@ -135,6 +135,7 @@ namespace geode {
     class ModMetadataImpl : public ModMetadata::Impl {
     public:
         static ModMetadata::Impl& getImpl(ModMetadata& info);
+        static ModMetadata::Impl const& getImpl(ModMetadata const& info);
     };
 }