Make new mods by verified developers be pending (#36)

* feat(mods): creating a mod as verified sets it to pending

* fix(mods): remove unused variable

Author: Fleeym

src/types/models/mod_entity.rs

@@ -669,20 +669,19 @@ impl Mod {
         developer: FetchedDeveloper,
         pool: &mut PgConnection,
     ) -> Result<(), ApiError> {
-        if semver::Version::parse(json.version.trim_start_matches('v')).is_err() {
+        if Version::parse(json.version.trim_start_matches('v')).is_err() {
             return Err(ApiError::BadRequest(format!(
                 "Invalid mod version semver {}",
                 json.version
             )));
         };
 
-        if semver::Version::parse(json.geode.trim_start_matches('v')).is_err() {
+        if Version::parse(json.geode.trim_start_matches('v')).is_err() {
             return Err(ApiError::BadRequest(format!(
                 "Invalid geode version semver {}",
                 json.geode
             )));
         };
-        let dev_verified = developer.verified;
 
         Mod::create(json, developer, pool).await?;
         if let Some(l) = &json.links {
@@ -698,7 +697,7 @@ impl Mod {
                 ).await?;
             }
         }
-        ModVersion::create_from_json(json, dev_verified, pool).await?;
+        ModVersion::create_from_json(json, false, pool).await?;
         Ok(())
     }
 

src/types/models/mod_version.rs

@@ -532,14 +532,14 @@ impl ModVersion {
 
     pub async fn create_from_json(
         json: &ModJson,
-        dev_verified: bool,
+        make_accepted: bool,
         pool: &mut PgConnection,
     ) -> Result<(), ApiError> {
         if let Err(e) = sqlx::query!("SET CONSTRAINTS mod_versions_status_id_fkey DEFERRED")
             .execute(&mut *pool)
             .await
         {
-            log::error!("{}", e);
+            log::error!("Error while updating constraints for mod_version_statuses: {}", e);
             return Err(ApiError::DbError);
         };
 
@@ -595,7 +595,7 @@ impl ModVersion {
             }
         }
 
-        let status = if dev_verified {
+        let status = if make_accepted {
             ModVersionStatusEnum::Accepted
         } else {
             ModVersionStatusEnum::Pending
@@ -615,6 +615,7 @@ impl ModVersion {
             return Err(ApiError::DbError);
         }
 
+        // Revert deferred constraints
         if let Err(e) = sqlx::query!("SET CONSTRAINTS mod_versions_status_id_fkey IMMEDIATE")
             .execute(&mut *pool)
             .await