fix: fix some build warnings

Author: Fleeym

src/auth/mod.rs

@@ -6,8 +6,6 @@ pub enum AuthenticationError {
     NoToken,
     #[error("Provided token is invalid")]
     InvalidToken,
-    #[error("User didn't accept authentication")]
-    UserRejectedAuth,
     #[error("User auth pending")]
     UserAuthPending,
     #[error("Failed to communicate with GitHub")]

src/types/api.rs

@@ -1,76 +1,20 @@
-use std::error::Error;
-use actix_web::{error::QueryPayloadError, http::header::ContentType, HttpRequest, HttpResponse};
+use actix_web::{error::QueryPayloadError, HttpRequest};
 use serde::{Deserialize, Serialize};
-use std::fmt::Display;
-use actix_web::http::StatusCode;
+
+use crate::endpoints::ApiError;
 
 #[derive(Serialize, Deserialize)]
 pub struct PaginatedData<T> {
     pub data: Vec<T>,
     pub count: i64,
 }
 
-#[derive(Debug, PartialEq)]
-pub enum ApiError {
-    FilesystemError,
-    DbAcquireError,
-    DbError,
-    TransactionError,
-    InternalError,
-    BadRequest(String),
-    NotFound(String),
-    Unauthorized,
-    Forbidden,
-}
-
 #[derive(Debug, Serialize, Deserialize)]
 pub struct ApiResponse<T> {
     pub error: String,
     pub payload: T,
 }
 
-impl Error for ApiError {}
-
-impl Display for ApiError {
-    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        match self {
-            Self::FilesystemError => write!(f, "Unknown filesystem error"),
-            Self::DbAcquireError => write!(f, "Database is busy"),
-            Self::DbError => write!(f, "Unknown database error"),
-            Self::TransactionError => write!(f, "Unknown transaction error"),
-            Self::BadRequest(message) => write!(f, "{}", message),
-            Self::NotFound(message) => write!(f, "{}", message),
-            Self::InternalError => write!(f, "Internal server error"),
-            Self::Forbidden => write!(f, "You cannot perform this action"),
-            Self::Unauthorized => write!(f, "You need to be authenticated to perform this action"),
-        }
-    }
-}
-
-impl actix_web::ResponseError for ApiError {
-    fn status_code(&self) -> StatusCode {
-        match self {
-            Self::FilesystemError => StatusCode::INTERNAL_SERVER_ERROR,
-            Self::DbAcquireError => StatusCode::INTERNAL_SERVER_ERROR,
-            Self::DbError => StatusCode::INTERNAL_SERVER_ERROR,
-            Self::TransactionError => StatusCode::INTERNAL_SERVER_ERROR,
-            Self::BadRequest(_) => StatusCode::BAD_REQUEST,
-            Self::NotFound(_) => StatusCode::NOT_FOUND,
-            Self::InternalError => StatusCode::INTERNAL_SERVER_ERROR,
-            Self::Unauthorized => StatusCode::UNAUTHORIZED,
-            Self::Forbidden => StatusCode::FORBIDDEN,
-        }
-    }
-    fn error_response(&self) -> HttpResponse<actix_web::body::BoxBody> {
-        HttpResponse::build(self.status_code())
-            .append_header(ContentType::json())
-            .json(ApiResponse {
-                error: self.to_string(),
-                payload: "".to_string(),
-            })
-    }
-}
-
 pub fn query_error_handler(err: QueryPayloadError, _req: &HttpRequest) -> actix_web::Error {
     ApiError::BadRequest(err.to_string()).into()
 }

src/types/models/mod_version.rs

@@ -457,7 +457,7 @@ impl ModVersion {
         query_builder.push_bind(id);
         query_builder.push(") q WHERE q.rn = 1");
 
-        let mut version = query_builder
+        let version = query_builder
             .build_query_as::<ModVersionGetOne>()
             .fetch_optional(&mut *pool)
             .await

src/types/models/tag.rs

@@ -4,12 +4,6 @@ use crate::database::repository::mod_tags;
 use crate::{database::DatabaseError, endpoints::ApiError};
 use sqlx::PgConnection;
 
-#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
-pub struct FetchedTag {
-    pub id: i32,
-    pub name: String,
-}
-
 #[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
 pub struct Tag {
     pub id: i32,