Forbid and remove console.log and console.info calls (#835)

Author: mfisher87

.eslintrc.js

@@ -58,6 +58,7 @@ module.exports = {
       }
     ],
     "prefer-arrow-callback": "error",
+    "no-console": ["error", {"allow": ["error", "warn", "debug"]}],
     "no-duplicate-imports": "error",
   },
 };

packages/base/src/commands/index.ts

@@ -735,7 +735,6 @@ export function addCommands(
       if (!currentWidget || !completionProviderManager) {
         return;
       }
-      console.log('zooming');
       const model = tracker.currentWidget.model;
       const selectedItems = model.localState?.selected.value;
 
@@ -1140,7 +1139,7 @@ namespace Private {
     const selected = model?.localState?.selected?.value;
 
     if (!selected) {
-      console.info('Nothing selected');
+      console.error('Failed to remove selected item -- nothing selected');
       return;
     }
 

packages/base/src/dialogs/symbology/vector_layer/types/Categorized.tsx

@@ -207,8 +207,6 @@ const Categorized: React.FC<ISymbologyTabbedDialogWithAttributesProps> = ({
     const newStyle = { ...layer.parameters.color };
 
     if (method === 'color') {
-      console.log('delecol');
-
       delete newStyle['fill-color'];
       delete newStyle['stroke-color'];
       delete newStyle['circle-fill-color'];

packages/base/src/mainview/mainView.tsx

@@ -2270,7 +2270,7 @@ export class MainView extends React.Component<IProps, IStates> {
     const olLayer = this.getLayer(layerId);
 
     if (!jgisLayer || !olLayer) {
-      console.log('Layer not found');
+      console.error('Failed to update layer -- layer not found');
       return;
     }
 

packages/base/src/stacBrowser/hooks/useStacSearch.ts

@@ -209,7 +209,7 @@ function useStacSearch({ model }: IUseStacSearchProps): IUseStacSearchReturn {
       )) as IStacSearchResult;
 
       if (!data) {
-        console.log('No Results found');
+        console.debug('STAC search failed -- no results found');
         setResults([]);
         setTotalPages(1);
         setTotalResults(0);
@@ -221,7 +221,7 @@ function useStacSearch({ model }: IUseStacSearchProps): IUseStacSearchReturn {
       setTotalPages(Math.ceil(pages));
       setTotalResults(data.context.matched);
     } catch (error) {
-      console.error('Error fetching data:', error);
+      console.error('STAC search failed -- error fetching data:', error);
       setResults([]);
       setTotalPages(1);
       setTotalResults(0);

packages/base/src/tools.ts

@@ -111,7 +111,10 @@ export async function requestAPI<T>(
     try {
       data = JSON.parse(data);
     } catch (error) {
-      console.log('Not a JSON response body.', response);
+      console.error(
+        'Jupyter API request failed -- not a JSON response body:',
+        response,
+      );
     }
   }
 

packages/schema/src/model.ts

@@ -735,7 +735,7 @@ export class JupyterGISModel implements IJupyterGISModel {
         layerTreeInfo.mainGroup,
       );
     } else {
-      console.log('Something went wrong when renaming layer');
+      console.error('Layer group rename failed -- could not get layer tree.');
     }
   }
 

python/jupytergis_core/src/jgisplugin/plugins.ts

@@ -67,11 +67,8 @@ const activate = async (
     window.jupytergisMaps = {};
   }
 
-  let settings: ISettingRegistry.ISettings | null = null;
-
   try {
-    settings = await settingRegistry.load(SETTINGS_ID);
-    console.log(`Loaded settings for ${SETTINGS_ID}`, settings);
+    await settingRegistry.load(SETTINGS_ID);
   } catch (error) {
     console.warn(`Failed to load settings for ${SETTINGS_ID}`, error);
   }

python/jupytergis_core/src/plugin.ts

@@ -41,7 +41,7 @@ export const trackerPlugin: JupyterFrontEndPlugin<IJupyterGISTracker> = {
     const tracker = new WidgetTracker<IJupyterGISWidget>({
       namespace: NAME_SPACE,
     });
-    console.log('jupytergis:core:tracker is activated!');
+    console.debug('jupytergis:core:tracker is activated!');
     return tracker;
   },
 };
@@ -80,8 +80,7 @@ export const layerBrowserRegistryPlugin: JupyterFrontEndPlugin<IJGISLayerBrowser
     requires: [],
     provides: IJGISLayerBrowserRegistryToken,
     activate: (app: JupyterFrontEnd) => {
-      console.log('jupytergis:core:layer-browser-registry is activated');
-
+      console.debug('jupytergis:core:layer-browser-registry is activated');
       const registry = new JupyterGISLayerBrowserRegistry();
       return registry;
     },

python/jupytergis_lab/src/index.ts

@@ -49,7 +49,7 @@ const plugin: JupyterFrontEndPlugin<void> = {
     translator?: ITranslator,
     completionProviderManager?: ICompletionProviderManager,
   ): void => {
-    console.log('jupytergis:lab:main-menu is activated!');
+    console.debug('jupytergis:lab:main-menu is activated!');
     translator = translator ?? nullTranslator;
     const isEnabled = (): boolean => {
       return (