Move transition settings to landmark

Author: gjmooney

packages/base/src/commands/index.ts

@@ -1079,7 +1079,11 @@ export function addCommands(
         return;
       }
 
-      const layerParams: ILandmarkLayer = { extent, zoom };
+      const layerParams: ILandmarkLayer = {
+        extent,
+        zoom,
+        transition: { type: 'linear', time: 1 },
+      };
       const layerModel: IJGISLayer = {
         type: 'LandmarkLayer',
         visible: true,

packages/base/src/mainview/mainView.tsx

@@ -2053,13 +2053,13 @@ export class MainView extends React.Component<IProps, IStates> {
       const coords = getCenter(layerParams.extent);
 
       // TODO: Should pass args through signal??
-      const { story } = this._model.getSelectedStory();
+      // const { story } = this._model.getSelectedStory();
 
       this._flyToPosition(
         { x: coords[0], y: coords[1] },
         layerParams.zoom,
-        (story?.transition?.time ?? 1) * 1000, // second -> ms
-        story?.transition?.type,
+        (layerParams.transition.time ?? 1) * 1000, // seconds -> ms
+        layerParams.transition.type,
       );
 
       return;

packages/schema/src/schema/project/jgis.json

@@ -151,22 +151,6 @@
           "enum": ["guided", "unguided"],
           "description": "The type of story map"
         },
-        "transition": {
-          "type": "object",
-          "description": "Transition configuration between landmarks",
-          "properties": {
-            "type": {
-              "type": "string",
-              "enum": ["linear", "immediate", "smooth"],
-              "description": "Transition animation style"
-            },
-            "time": {
-              "type": "number",
-              "description": "The time in seconds for the transition"
-            }
-          },
-          "required": ["type", "time"]
-        },
         "landmarks": {
           "type": "array",
           "default": [],

packages/schema/src/schema/project/layers/landmarkLayer.json

@@ -3,7 +3,7 @@
   "description": "LandmarkLayer",
   "title": "ILandmarkLayer",
   "additionalProperties": false,
-  "required": ["zoom", "extent"],
+  "required": ["zoom", "extent", "transition"],
   "properties": {
     "content": {
       "type": "object",
@@ -32,6 +32,24 @@
       "items": {
         "type": "number"
       }
+    },
+    "transition": {
+      "type": "object",
+      "description": "Transition configuration between to this landmark",
+      "properties": {
+        "type": {
+          "type": "string",
+          "enum": ["linear", "immediate", "smooth"],
+          "description": "Transition animation style",
+          "default": "linear"
+        },
+        "time": {
+          "type": "number",
+          "description": "The time in seconds for the transition",
+          "default": 1
+        }
+      },
+      "required": ["type", "time"]
     }
   }
 }