Skip to content

Commit 11ba90b

Browse files
Add go to preference action, same actions list for both back key activations, #269
1 parent 70e5b50 commit 11ba90b

File tree

4 files changed

+8
-10
lines changed

4 files changed

+8
-10
lines changed

assets/resources/application/en.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -795,6 +795,7 @@
795795
</node>
796796
<node name="backKeyAction" value="Back key action">
797797
<node name="exit" value="Close FBReader"/>
798+
<node name="goToPreferences" value="Go directly to your preferences"/>
798799
<node name="goToPreviousBook" value="Go directly to your previously opened book"/>
799800
<node name="goToLibrary" value="Go directly to your library"/>
800801
<node name="goToNetworkLibrary" value="Go directly to your network library"/>
@@ -804,6 +805,7 @@
804805
</node>
805806
<node name="backKeyLongPressAction" value="Back key long press action">
806807
<node name="exit" value="Close FBReader"/>
808+
<node name="goToPreferences" value="Go directly to your preferences"/>
807809
<node name="goToPreviousBook" value="Go directly to your previously opened book"/>
808810
<node name="goToLibrary" value="Go directly to your library"/>
809811
<node name="goToNetworkLibrary" value="Go directly to your network library"/>

src/org/geometerplus/android/fbreader/FBReader.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,7 @@ public void run() {
286286
myFBReaderApp.addAction(ActionCode.OPEN_VIDEO, new OpenVideoAction(this, myFBReaderApp));
287287

288288
myFBReaderApp.addAction(ActionCode.SHOW_CANCEL_MENU, new ShowCancelMenuAction(this, myFBReaderApp));
289+
myFBReaderApp.addAction(ActionCode.GO_TO_PREFERENCES, new ShowPreferencesAction(this, myFBReaderApp));
289290
myFBReaderApp.addAction(ActionCode.GO_TO_LIBRARY, new ShowLibraryAction(this, myFBReaderApp));
290291
myFBReaderApp.addAction(ActionCode.GO_TO_NETWORK_LIBRARY, new ShowNetworkLibraryAction(this, myFBReaderApp));
291292
myFBReaderApp.addAction(ActionCode.GO_TO_PREVIOUS_BOOK, new GoToPreviousBookAction(this, myFBReaderApp));

src/org/geometerplus/android/fbreader/preferences/PreferenceActivity.java

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -716,27 +716,21 @@ protected void onDialogClosed(boolean result) {
716716
cancelMenuScreen.addOption(cancelMenuHelper.ShowNetworkLibraryItemOption, "networkLibrary");
717717
cancelMenuScreen.addOption(cancelMenuHelper.ShowPreviousBookItemOption, "previousBook");
718718
cancelMenuScreen.addOption(cancelMenuHelper.ShowPositionItemsOption, "positions");
719-
final String[] backKeyActions = {
719+
final String[] backKeyAndBackKeyLongPressActions = {
720720
ActionCode.SHOW_CANCEL_MENU,
721+
ActionCode.GO_TO_PREFERENCES,
721722
ActionCode.GO_TO_LIBRARY,
722723
ActionCode.GO_TO_NETWORK_LIBRARY,
723724
ActionCode.GO_TO_PREVIOUS_BOOK,
724725
ActionCode.EXIT,
725726
FBReaderApp.NoAction };
726727
cancelMenuScreen.addPreference(new ZLStringChoicePreference(
727728
this, cancelMenuScreen.Resource.getResource("backKeyAction"),
728-
keyBindings.getOption(KeyEvent.KEYCODE_BACK, false), backKeyActions
729+
keyBindings.getOption(KeyEvent.KEYCODE_BACK, false), backKeyAndBackKeyLongPressActions
729730
));
730-
final String[] backKeyLongPressActions = {
731-
ActionCode.SHOW_CANCEL_MENU,
732-
ActionCode.GO_TO_LIBRARY,
733-
ActionCode.GO_TO_NETWORK_LIBRARY,
734-
ActionCode.GO_TO_PREVIOUS_BOOK,
735-
ActionCode.EXIT,
736-
FBReaderApp.NoAction };
737731
cancelMenuScreen.addPreference(new ZLStringChoicePreference(
738732
this, cancelMenuScreen.Resource.getResource("backKeyLongPressAction"),
739-
keyBindings.getOption(KeyEvent.KEYCODE_BACK, true), backKeyLongPressActions
733+
keyBindings.getOption(KeyEvent.KEYCODE_BACK, true), backKeyAndBackKeyLongPressActions
740734
));
741735

742736
final Screen tipsScreen = createPreferenceScreen("tips");

src/org/geometerplus/fbreader/fbreader/ActionCode.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ public interface ActionCode {
5656
String GO_BACK = "goBack";
5757
String EXIT = "exit";
5858
String SHOW_CANCEL_MENU = "cancelMenu";
59+
String GO_TO_PREFERENCES = "goToPreferences";
5960
String GO_TO_LIBRARY = "goToLibrary";
6061
String GO_TO_NETWORK_LIBRARY = "goToNetworkLibrary";
6162
String GO_TO_PREVIOUS_BOOK = "goToPreviousBook";

0 commit comments

Comments
 (0)