Moved solver out of header

Author: rjc8237

src/optimization/CMakeLists.txt

@@ -1,6 +1,7 @@
 add_library(MetricOptimizationLib
   area.cpp
   constraint.cpp
+  common.cpp
   cone_metric.cpp
   convergence.cpp
   embedding.cpp

src/optimization/common.cpp

@@ -0,0 +1,22 @@
+#include "common.hh"
+
+#ifdef USE_SUITESPARSE
+#include <Eigen/CholmodSupport>
+#endif
+
+namespace CurvatureMetric {
+
+
+VectorX solve_psd_system(const MatrixX& A, const VectorX&b)
+{
+#ifdef USE_SUITESPARSE
+    Eigen::CholmodSupernodalLLT<MatrixX> solver;
+#else
+    Eigen::SimplicialLDLT<MatrixX> solver;
+#endif
+
+    solver.compute(A);
+    return solver.solve(b);
+}
+
+}

src/optimization/common.hh

@@ -17,10 +17,6 @@
 #include "spdlog/sinks/basic_file_sink.h"
 #include "spdlog/sinks/ostream_sink.h"
 
-#ifdef USE_SUITESPARSE
-#include <Eigen/CholmodSupport>
-#endif
-
 namespace CurvatureMetric {
 
 /// *************************
@@ -406,17 +402,7 @@ compute_condition_number(
   return sigma_1 / sigma_n;
 }
 
-inline VectorX solve_psd_system(const MatrixX& A, const VectorX&b)
-{
-#ifdef USE_SUITESPARSE
-    Eigen::CholmodSupernodalLLT<MatrixX> solver;
-#else
-    Eigen::SimplicialLDLT<MatrixX> solver;
-#endif
-
-    solver.compute(A);
-    return solver.solve(b);
-}
+VectorX solve_psd_system(const MatrixX& A, const VectorX&b);
 
 /// ********************
 /// Data Type Conversion