Routing: Allow implementing other search routes than /search in other router services #850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to allow implementing other search routes than /search in other router services
Contributor
|
Affected libs:
|
Contributor
|
📷 Screenshots are here! |
7 tasks
jahow
approved these changes
Apr 12, 2024
Member
jahow
left a comment
jahow
left a comment
There was a problem hiding this comment.
looking good, that had gone under the radar, thanks :)
jahow
reviewed
Apr 12, 2024
| } | ||
|
|
||
| getSearchRoute(): string { | ||
| return `${ROUTER_ROUTE_HOME}/${ROUTER_ROUTE_SEARCH}` |
Member
There was a problem hiding this comment.
It's quite curious that this always worked
Collaborator
Author
There was a problem hiding this comment.
Yep, maybe due to the redirect in lines https://github.com/geonetwork/geonetwork-ui/pull/850/files#diff-18147f3d9fd25936e42e709dea85cb97a42c69b44e19d92cde9d43f409ad6baaR30-R34 above...
Collaborator
Author
|
Oups I also forgot about it and missed the notification today. I think there is still an issue, when looking at the e2e tests. I'll take a look when coming back from holidays. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces uses
getSearchRoute()instead ofROUTER_ROUTE_SEARCHwithin therouter.facadeto allow implementing other search routes than/searchin other router services.Note: Needs to remove
ROUTER_ROUTE_HOMEfrom thedatahub-router.serviceto work (which is not part of the path due to a redirect).Quality Assurance Checklist
breaking changelabelbackport <release branch>label