Additional qa fixes from sonarcloud reports

Author: groldan

src/apps/base-images/geoserver/src/main/java/org/geoserver/cloud/InstallDuckDBExtensions.java

@@ -32,7 +32,7 @@ public class InstallDuckDBExtensions {
      *
      * @param args Command line arguments (not used)
      */
-    @SuppressWarnings("java:S4507") // printStackTrace() is ok in this class
+    @SuppressWarnings({"java:S4507", "java:S106"}) // printStackTrace() and System.out.println() are ok in this class
     public static void main(String[] args) {
         try {
             Class.forName("org.duckdb.DuckDBDriver");

src/apps/geoserver/wms/src/test/java/org/geoserver/cloud/wms/app/StatusCodeWmsExceptionHandlerTest.java

@@ -26,7 +26,7 @@
 import org.springframework.core.env.PropertyResolver;
 import org.springframework.http.HttpStatus;
 
-public class StatusCodeWmsExceptionHandlerTest {
+class StatusCodeWmsExceptionHandlerTest {
     private StatusCodeWmsExceptionHandler handler;
     private PropertyResolver propertyResolver = mock(PropertyResolver.class);
     private GeoServer geoServer = mock(GeoServer.class);

src/catalog/backends/common/src/main/java/org/geoserver/security/impl/GsCloudLayerGroupContainmentCache.java

@@ -371,7 +371,6 @@ private void updateContainedLayers(
                     String resourceId = layer.getResource().getId();
                     clearContainment(groupSummary, resourceId);
                 } else if (removed instanceof LayerGroupInfo child) {
-                    //// getGroupData(child)
                     LayerGroupSummary summary = groupCache.get(child.getId());
                     if (summary != null) {
                         summary.containerGroups.remove(groupSummary);

src/catalog/backends/datadir/src/main/java/org/geoserver/cloud/catalog/backend/datadir/EventuallyConsistentCatalogFacade.java

@@ -215,7 +215,7 @@ public void setDefaultDataStore(WorkspaceInfo workspace, DataStoreInfo store) {
         enforcer.setDefaultDataStore(workspace, store);
     }
 
-    ///////// point queries, apply retry if
+    // point queries, apply retry if
 
     @Override
     public <T extends StoreInfo> T getStore(String id, Class<T> clazz) {

src/catalog/backends/datadir/src/test/java/org/geoserver/cloud/catalog/backend/datadir/EventualConsistencyEnforcerTest.java

@@ -40,12 +40,13 @@ class EventualConsistencyEnforcerTest {
 
     private EventualConsistencyEnforcer enforcer;
 
-    public static @BeforeAll void oneTimeSetup() {
+    static @BeforeAll void oneTimeSetup() {
         // avoid the chatty warning logs due to catalog looking up a bean of type GeoServerConfigurationLock
         GeoServerExtensionsHelper.setIsSpringContext(false);
     }
 
-    public @BeforeEach void before() {
+    @BeforeEach
+    void before() {
         catalog = new CatalogPlugin();
         geoserver = new GeoServerImpl();
         geoserver.setCatalog(catalog);

src/catalog/backends/pgconfig/src/main/java/org/geoserver/cloud/backend/pgconfig/catalog/repository/LoggingTemplate.java

@@ -106,7 +106,6 @@ private void logAfter(long reqId, String sql, Duration elapsed, Exception error)
             if (error instanceof org.springframework.dao.EmptyResultDataAccessException) {
                 return;
             }
-            error.printStackTrace();
         }
         if (!log.isDebugEnabled()) {
             return;

src/catalog/backends/pgconfig/src/main/java/org/geoserver/cloud/backend/pgconfig/config/PgconfigConfigRepository.java

@@ -101,6 +101,7 @@ public SettingsInfo update(SettingsInfo settings, Patch patch) {
         return update(settings, patch, SettingsInfo.class, "settingsinfo", "settingsinfos", SettingsInfoRowMapper);
     }
 
+    @SuppressWarnings("java:S2077") // table is a safe argument, constrained to "settingsinfo" and "serviceinfo"
     private <T extends Info> T update(
             T value, Patch patch, Class<T> clazz, String table, String querytable, RowMapper<T> mapper) {
 

src/catalog/backends/pgconfig/src/main/java/org/geoserver/cloud/backend/pgconfig/resource/PgconfigResource.java

@@ -14,7 +14,6 @@
 import lombok.EqualsAndHashCode;
 import lombok.Getter;
 import lombok.NonNull;
-import lombok.ToString;
 import org.geoserver.platform.resource.Paths;
 import org.geoserver.platform.resource.Resource;
 import org.geoserver.platform.resource.ResourceListener;
@@ -23,7 +22,6 @@
  * @since 1.4
  */
 @EqualsAndHashCode(exclude = {"store", "lastChecked"})
-@ToString(exclude = "store")
 class PgconfigResource implements Resource {
 
     @Getter

src/catalog/backends/pgconfig/src/test/java/org/geoserver/cloud/backend/pgconfig/resource/PgconfigResourceTest.java

@@ -158,8 +158,7 @@ private LockRegistry pgconfigLockRegistry() {
     LockRepository pgconfigLockRepository() {
         DataSource dataSource = container.getDataSource();
         DefaultLockRepository lockRepository = new DefaultLockRepository(dataSource, "test-instance");
-        // override default table prefix "INT" by "RESOURCE_" (matching table definition
-        // RESOURCE_LOCK in init.XXX.sql
+        // override default table prefix "INT" by "RESOURCE_" (matching table RESOURCE_LOCK in flyway ddl scripts)
         lockRepository.setPrefix("RESOURCE_");
         // time in ms to expire dead locks (10k is the default)
         lockRepository.setTimeToLive(300_000);
@@ -516,6 +515,7 @@ public void testUpdateStateHandlesDeletedResource() throws Exception {
      * </p>
      */
     @Test
+    @SuppressWarnings("java:S2925") // Thread.sleep
     public void testUpdateStateHandlesModifiedResource() throws Exception {
         // Create a test resource in the database
         String path = "security/updated.properties";

src/catalog/cache/src/main/java/org/geoserver/cloud/catalog/cache/CachingCatalogFacade.java

@@ -66,7 +66,7 @@ public CachingCatalogFacade(@NonNull ExtendedCatalogFacade facade, @NonNull Cach
         this.support = support;
     }
 
-    /////////////////////  Eviction event listeners //////////////////////////
+    // ///////////////////  Eviction event listeners //////////////////////////
 
     @EventListener(classes = DefaultWorkspaceSet.class)
     public void onDefaultWorkspaceSet() {
@@ -114,7 +114,7 @@ public void onCatalogInfoRemovedEvent(CatalogInfoRemoved event) {
         }
     }
 
-    /////////////////////  CatalogFacade override methods //////////////////////////
+    // ///////////////////  CatalogFacade override methods //////////////////////////
 
     @Override
     public <T extends CatalogInfo> T add(@NonNull T info) {