#7653: Share panel advanced settings fix (#7662) (#7673)

(cherry picked from commit dae5b2c)

Author: dsuren1

web/client/components/share/SharePanel.jsx

@@ -25,7 +25,7 @@ import {
     Tooltip
 } from 'react-bootstrap';
 import Message from '../../components/I18N/Message';
-import { join, isNil, isEqual, inRange } from 'lodash';
+import { join, isNil, isEqual, inRange, isEmpty } from 'lodash';
 import { removeQueryFromUrl, getSharedGeostoryUrl, CENTERANDZOOM, BBOX, MARKERANDZOOM, SHARE_TABS } from '../../utils/ShareUtils';
 import { getLonLatFromPoint } from '../../utils/CoordinatesUtils';
 import { getMessageById } from '../../utils/LocaleUtils';
@@ -234,7 +234,7 @@ class SharePanel extends React.Component {
                 onClose={this.props.onClose}>
                 <div role="body" className="share-panels">
                     {tabs}
-                    {this.props.advancedSettings
+                    {!isEmpty(this.props.advancedSettings)
                         && currentTab !== SHARE_TABS[this.props?.advancedSettings?.hideInTab]
                         && this.renderAdvancedSettings()
                     }

web/client/components/share/__tests__/SharePanel-test.jsx

@@ -81,6 +81,19 @@ describe("The SharePanel component", () => {
         expect(document.querySelectorAll('h4')[1].innerHTML).toBe("<span>share.directLinkTitle</span>");
 
     });
+    it('test hide advancedSettings when no settings configured', () => {
+        const advancedSettings = {};
+        let panel = ReactDOM.render(<SharePanel showAPI={false} advancedSettings={advancedSettings} getCount={() => 2} shareUrl="www.geo-solutions.it" isVisible />, document.getElementById("container"));
+        expect(panel.state.eventKey).toBe(1);
+        expect(document.querySelectorAll('h4')[1].innerHTML).toBe("<span>share.directLinkTitle</span>");
+
+        let advancedSettingsPanel = document.querySelector('.mapstore-switch-panel');
+        expect(advancedSettingsPanel).toBeFalsy();
+
+        ReactDOM.render(<SharePanel showAPI={false} advancedSettings={false} getCount={() => 2} shareUrl="www.geo-solutions.it" isVisible />, document.getElementById("container"));
+        advancedSettingsPanel = document.querySelector('.mapstore-switch-panel');
+        expect(advancedSettingsPanel).toBeFalsy();
+    });
     it('test hide advancedSettings in specific tab', () => {
         const advancedSettings = {
             homeButton: true,